ProductTest::testGetProperty() - Code Metrics - Inspection of "Merge pull request #166 from xiaohome/master" - overtrue/wechat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a3c7a7...bd72ff )

by Carlos

created 2015-11-25 02:50 UTC

ProductTest::testGetProperty() A

↳ Parent: ProductTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	8
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	8
loc	8
rs	9.4286
cc	1
eloc	5
nc	1
nop	0

<?php

/**
 * Created by PhpStorm.
 * User: pjxh
 * Date: 15-11-1
 * Time: 下午5:10
 */
namespace Overtrue\Wechat\Test\Shop;


use Overtrue\Wechat\Image;
use Overtrue\Wechat\Shop\Product;
use Overtrue\Wechat\Test\TestBase;
use Symfony\Component\Yaml\Yaml;
use Overtrue\Wechat\Shop\Data\Product as ProductData;
use Overtrue\Wechat\Media;

class ProductTest extends TestBase
{

    public function testCreate()
    {

        $image = new Image($this->config->appId,$this->config->appSecret);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $images = $image->upload(__DIR__.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'Image'.DIRECTORY_SEPARATOR.'aa.jpg');

        $product = new Product($this->http);
        $response = $product->create(function(ProductData $product) use ($images)  {


            $product->setBaseAttr($images,array($images,$images),null,'商品名',536891949)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ->setDetail('text','text')
                ->setDetail('img',$images);

            $testData = Yaml::parse(file_get_contents(__DIR__.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'Config'.DIRECTORY_SEPARATOR.'Data.yml'));

            foreach ($testData['Overtrue\Wechat\Test\Shop\ProductTest']['testGetProperty'] as $value) {
                $product->setProperty($value['id'],$value['property_value'][0]['id']);
            }

            foreach ($testData['Overtrue\Wechat\Test\Shop\ProductTest']['testGetSku'] as $value) {
                foreach ($value['value_list'] as $key => $valueList) {
                    //此判断仅是为了 让子序列少点，实际程序按照自身的逻辑来
                    if ($key % 5 == 0 && $key % 2 == 0) {
                        $skuList[] = $valueList['id'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                    }

                }
                $skuInfo[] = array('id'=>$value['id'],'vid'=>$skuList);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $product->setSkuInfo($value['id'],$skuList);
            }

            foreach ($skuInfo[0]['vid'] as $vid) {
                foreach ($skuInfo[1]['vid'] as $vid1) {
                    $product->setSkuList(100, 20, $images, 100, array(array($skuInfo[0]['id'], $vid), array($skuInfo[1]['id'], $vid1)));
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                }
            }

            $product->setAttrext(0,1,1,1)
                ->setLocation('浙江省','杭州市','滨江区阿里园')
                ->setDeliveryInfo(1,'400184224');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            return $product;
        });

        $this->assertTrue(is_string($response));

        return $response;
    }

    /**
     * @depends testCreate
     */
    public function testUpdate($productId)
    {
        $image = new Image($this->config->appId,$this->config->appSecret);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $images = $image->upload(__DIR__.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'Image'.DIRECTORY_SEPARATOR.'aa.jpg');

        //未上架的
        $product = new Product($this->http);
        $response = $product->update(function(ProductData $product) use ($images)  {

            $product->setBaseAttr($images,array($images,$images),null,'商品名',536891949)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ->setDetail('text','text')
                ->setDetail('img',$images);

            $testData = Yaml::parse(file_get_contents(__DIR__.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'Config'.DIRECTORY_SEPARATOR.'Data.yml'));

            foreach ($testData['Overtrue\Wechat\Test\Shop\ProductTest']['testGetProperty'] as $value) {
                $product->setProperty($value['id'],$value['property_value'][0]['id']);
            }

            foreach ($testData['Overtrue\Wechat\Test\Shop\ProductTest']['testGetSku'] as $value) {
                foreach ($value['value_list'] as $key => $valueList) {
                    //此判断仅是为了 让子序列少点，实际程序按照自身的逻辑来
                    if ($key % 5 == 0 && $key % 2 == 0) {
                        $skuList[] = $valueList['id'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                    }

                }
                $skuInfo[] = array('id'=>$value['id'],'vid'=>$skuList);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $product->setSkuInfo($value['id'],$skuList);
            }

            foreach ($skuInfo[0]['vid'] as $vid) {
                foreach ($skuInfo[1]['vid'] as $vid1) {
                    $product->setSkuList(100, 20, $images, 100, array(array($skuInfo[0]['id'], $vid), array($skuInfo[1]['id'], $vid1)));
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                }
            }

            $product->setAttrext(0,1,1,1)
                ->setLocation('浙江省','杭州市','滨江区阿里园')
                ->setDeliveryInfo(1,'400184224');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            return $product;

        },$productId);

        $this->assertTrue(is_string($response));

    }

    /**
     * @depends testCreate
     */
    public function testGet($productId)
    {
        
        $product = new Product($this->http);
        $response = $product->get($productId);
        $this->assertTrue(is_array($response));
    }

    public function testGetByStatus()
    {
        
        $product = new Product($this->http);
        $response = $product->getByStatus();
        $this->assertTrue(is_array($response));
    }

    /**
     * @depends testCreate
     */
    public function testUpdateStatus($productId)
    {
        
        $product = new Product($this->http);
        $response = $product->updateStatus($productId,0);
        $this->assertTrue($response);
    }

    public function testGetSub()
    {
        
        $product = new Product($this->http);
        $response = $product->getSub();

        $this->assertTrue(is_array($response));

        foreach ($response as $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $this->assertArrayHasKey('id',$value);
            $this->assertArrayHasKey('name',$value);
        }


        $product = new Product($this->http);
        $response = $product->getSub(537891948);

        $this->assertTrue(is_array($response));

        foreach ($response as $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $this->assertArrayHasKey('id',$value);
            $this->assertArrayHasKey('name',$value);
        }

    }


    public function testGetSku()
    {
        $cateId = '536891949';

        $product = new Product($this->http);
        $response = $product->getSku($cateId);
        $this->assertTrue(is_array($response));
    }

    public function testGetProperty()
    {
        $cateId = '536891949';

        $product = new Product($this->http);
        $response = $product->getProperty($cateId);
        $this->assertTrue(is_array($response));
    }

    /**
     * @depends testCreate
     */
    public function testDelete($productId)
    {

        $product = new Product($this->http);
        $response = $product->delete($productId);
        $this->assertTrue($response);
    }
}


Push — master ( a3c7a7...bd72ff )

ProductTest::testGetProperty() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		/**
4		* Created by PhpStorm.
5		* User: pjxh
6		* Date: 15-11-1
7		* Time: 下午5:10
8		*/
9		namespace Overtrue\Wechat\Test\Shop;
10
11
12		use Overtrue\Wechat\Image;
13		use Overtrue\Wechat\Shop\Product;
14		use Overtrue\Wechat\Test\TestBase;
15		use Symfony\Component\Yaml\Yaml;
16		use Overtrue\Wechat\Shop\Data\Product as ProductData;
17		use Overtrue\Wechat\Media;
18
19		class ProductTest extends TestBase
20		{
21
22	View Code Duplication	public function testCreate()
23		{
24
25		$image = new Image($this->config->appId,$this->config->appSecret);
		0 ignored issues – show Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report The property `appId` does not exist on `object<Overtrue\Wechat\Shop\Config>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report The property `appSecret` does not exist on `object<Overtrue\Wechat\Shop\Config>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
26		$images = $image->upload(__DIR__.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'Image'.DIRECTORY_SEPARATOR.'aa.jpg');
27
28		$product = new Product($this->http);
29		$response = $product->create(function(ProductData $product) use ($images) {
30
31
32		$product->setBaseAttr($images,array($images,$images),null,'商品名',536891949)
		0 ignored issues – show Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `'商品名'` is of type `string`, but the function expects a `null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `536891949` is of type `integer`, but the function expects a `null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33		->setDetail('text','text')
34		->setDetail('img',$images);
35
36		$testData = Yaml::parse(file_get_contents(__DIR__.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'Config'.DIRECTORY_SEPARATOR.'Data.yml'));
37
38		foreach ($testData['Overtrue\Wechat\Test\Shop\ProductTest']['testGetProperty'] as $value) {

overtrue / wechat

Push — master ( a3c7a7...bd72ff )

ProductTest::testGetProperty() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like