ProductTest::testGetData() - Code Metrics - Inspection of "Merge pull request #166 from xiaohome/master" - overtrue/wechat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a3c7a7...bd72ff )

by Carlos

created 2015-11-25 02:50 UTC

ProductTest::testGetData() C

↳ Parent: ProductTest

Complexity

Conditions	8
Paths	24

Size

Total Lines	62
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	62
rs	6.943
cc	8
eloc	24
nc	24
nop	0

How to fix Long Method

<?php

/**
 * Created by PhpStorm.
 * User: pjxh
 * Date: 15-11-1
 * Time: 下午5:12
 */
namespace Overtrue\Wechat\Test\Shop\Data;


use Overtrue\Wechat\Media;
use Overtrue\Wechat\Shop\Data\Product;
use Overtrue\Wechat\Test\TestBase;
use Symfony\Component\Yaml\Yaml;

class ProductTest extends TestBase
{

    protected $categoryId = '536891949';

    public function testSetBaseAttr()
    {
        $product = new Product();

        $data = $product->setBaseAttr('主图',array('图一','图二'),null,'name',$this->categoryId);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertInstanceOf(Product::class,$data);

        $product = new Product(true);
        $data = $product->setBaseAttr('主图',array('图一','图二'));
        $this->assertInstanceOf(Product::class,$data);
    }

    public function testSetDetail()
    {
        $product = new Product();
        $data = $product->setDetail('img','图片');

        $this->assertInstanceOf(Product::class,$data);

        $data = $product->setDetail('text','文字');
        $this->assertInstanceOf(Product::class,$data);

    }

    public function testSetProperty()
    {

        $product = new Product();
        $data = $product->setProperty('id','vid');
        $this->assertInstanceOf(Product::class,$data);

    }


    public function testSetSkuInfo()
    {

        $product = new Product();
        $data = $product->setSkuInfo('id',array('vid','vid'));
        $this->assertInstanceOf(Product::class,$data);
    }


    public function testSetSkuList()
    {

        $product = new Product();
        $data = $product->setSkuList('原价','微信价','sku_ico','sku 库存',array('id'=>'vid','id1'=>'vid1'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertInstanceOf(Product::class,$data);
    }

    public function testSetAttrext()
    {
        $product = new Product();
        $data = $product->setAttrext(0,1,1,1);
        $this->assertInstanceOf(Product::class,$data);
    }


    public function testSetLocation()
    {
        $product = new Product();
        $data = $product->setLocation('浙江省','杭州市','滨江区阿里园');
        $this->assertInstanceOf(Product::class,$data);
    }

    public function testSetDeliveryInfo()
    {
        $product = new Product();
        $data = $product->setDeliveryInfo(1,'400184180');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertInstanceOf(Product::class,$data);
    }

    public function testSetExpress()
    {
        $product = new Product();
        $data = $product->setExpress('id','price');
        $this->assertInstanceOf(Product::class,$data);
    }


    public function testGetData()
    {

        $media = new Media($this->config->appId,$this->config->appSecret);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $image = $media->lists('image');

        //未上架
        $product = new Product();
        $product->setBaseAttr($image['item'][0]['url'],array($image['item'][0]['url'],$image['item'][0]['url']),null,'商品名',$this->categoryId)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setDetail('text','text')
            ->setDetail('img',$image['item'][0]['url']);

        $testData = Yaml::parse(file_get_contents(__DIR__.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'Config'.DIRECTORY_SEPARATOR.'Data.yml'));

        foreach ($testData['Overtrue\Wechat\Test\Shop\ProductTest']['testGetProperty'] as $value) {
            $product->setProperty($value['id'],$value['property_value'][0]['id']);
        }

        foreach ($testData['Overtrue\Wechat\Test\Shop\ProductTest']['testGetSku'] as $value) {
            foreach ($value['value_list'] as $key => $valueList) {
                //此判断仅是为了 让子序列少点，实际程序按照自身的逻辑来
                if ($key % 5 == 0 && $key % 2 == 0) {
                    $skuList[] = $valueList['id'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                }

            }
            $skuInfo[] = array('id'=>$value['id'],'vid'=>$skuList);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $product->setSkuInfo($value['id'],$skuList);
        }

        foreach ($skuInfo[0]['vid'] as $vid) {
            foreach ($skuInfo[1]['vid'] as $vid1) {
                $product->setSkuList(100, 20, $image['item'][0]['url'], 100, array(array($skuInfo[0]['id'], $vid), array($skuInfo[1]['id'], $vid1)));
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            }
        }

        $data = $product->setAttrext(0,1,1,1)
            ->setLocation('浙江省','杭州市','滨江区阿里园')
            ->setDeliveryInfo(1,'400184180')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->toArray();
        $this->assertTrue(is_array($data));

//        //以上架
//        $product = new Product(true);
//        $data = $product->setBaseAttr('main_img',array('img','img'))
//            ->setDetail('text','text')
//            ->setDetail('img','image')
//            //->setProperty('id','vid')
//            //->setProperty('id','vid')
//            ->setSkuInfo('id',array('vid','vid'))
//            //统一售价
//            //->setSkuList('原价','微信价','sku_ico','sku 库存');
//            //设置ｓｋｕ售价
//            ->setSkuList('原价','微信价','sku_ico','sku 库存',array('id'=>'vid','id1'=>'vid1'))
//            ->setAttrext(0,1,1,1)
//            ->setLocation('浙江省','杭州市','滨江区阿里园')
//            ->setDeliveryInfo(1,'400184180')
//            ->toArray();
//        $this->assertTrue(is_array($data));


    }
}


1			<?php
2
3			/**
4			* Created by PhpStorm.
5			* User: pjxh
6			* Date: 15-11-1
7			* Time: 下午5:12
8			*/
9			namespace Overtrue\Wechat\Test\Shop\Data;
10
11
12			use Overtrue\Wechat\Media;
13			use Overtrue\Wechat\Shop\Data\Product;
14			use Overtrue\Wechat\Test\TestBase;
15			use Symfony\Component\Yaml\Yaml;
16
17			class ProductTest extends TestBase
18			{
19
20			protected $categoryId = '536891949';
21
22			public function testSetBaseAttr()
23			{
24			$product = new Product();
25
26			$data = $product->setBaseAttr('主图',array('图一','图二'),null,'name',$this->categoryId);
			0 ignored issues – show Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `'name'` is of type `string`, but the function expects a `null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `$this->categoryId` is of type `string`, but the function expects a `null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27			$this->assertInstanceOf(Product::class,$data);
28
29			$product = new Product(true);
30			$data = $product->setBaseAttr('主图',array('图一','图二'));
31			$this->assertInstanceOf(Product::class,$data);
32			}
33
34			public function testSetDetail()
35			{
36			$product = new Product();
37			$data = $product->setDetail('img','图片');
38
39			$this->assertInstanceOf(Product::class,$data);
40
41			$data = $product->setDetail('text','文字');
42			$this->assertInstanceOf(Product::class,$data);
43
44			}
45
46			public function testSetProperty()
47			{
48
49			$product = new Product();
50			$data = $product->setProperty('id','vid');
51			$this->assertInstanceOf(Product::class,$data);
52
53			}
54
55
56			public function testSetSkuInfo()
57			{
58
59			$product = new Product();
60			$data = $product->setSkuInfo('id',array('vid','vid'));
61			$this->assertInstanceOf(Product::class,$data);
62			}
63
64
65			public function testSetSkuList()
66			{
67
68			$product = new Product();
69			$data = $product->setSkuList('原价','微信价','sku_ico','sku 库存',array('id'=>'vid','id1'=>'vid1'));
			0 ignored issues – show Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `array('id' => 'vid', 'id1' => 'vid1')` is of type `array<string,string,{"id...tring","id1":"string"}>`, but the function expects a `null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
70			$this->assertInstanceOf(Product::class,$data);
71			}
72
73			public function testSetAttrext()
74			{
75			$product = new Product();
76			$data = $product->setAttrext(0,1,1,1);
77			$this->assertInstanceOf(Product::class,$data);
78			}
79
80
81			public function testSetLocation()
82			{
83			$product = new Product();
84			$data = $product->setLocation('浙江省','杭州市','滨江区阿里园');
85			$this->assertInstanceOf(Product::class,$data);
86			}
87
88			public function testSetDeliveryInfo()
89			{
90			$product = new Product();
91			$data = $product->setDeliveryInfo(1,'400184180');
			0 ignored issues – show Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `'400184180'` is of type `string`, but the function expects a `null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
92			$this->assertInstanceOf(Product::class,$data);
93			}
94
95			public function testSetExpress()
96			{
97			$product = new Product();
98			$data = $product->setExpress('id','price');
99			$this->assertInstanceOf(Product::class,$data);
100			}
101
102
103			public function testGetData()
104			{
105
106			$media = new Media($this->config->appId,$this->config->appSecret);
			0 ignored issues – show Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report The property `appId` does not exist on `object<Overtrue\Wechat\Shop\Config>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report The property `appSecret` does not exist on `object<Overtrue\Wechat\Shop\Config>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
107			$image = $media->lists('image');
108
109			//未上架
110			$product = new Product();
111			$product->setBaseAttr($image['item'][0]['url'],array($image['item'][0]['url'],$image['item'][0]['url']),null,'商品名',$this->categoryId)
			0 ignored issues – show Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `'商品名'` is of type `string`, but the function expects a `null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `$this->categoryId` is of type `string`, but the function expects a `null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
112			->setDetail('text','text')
113			->setDetail('img',$image['item'][0]['url']);
114
115			$testData = Yaml::parse(file_get_contents(__DIR__.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'Config'.DIRECTORY_SEPARATOR.'Data.yml'));
116
117			foreach ($testData['Overtrue\Wechat\Test\Shop\ProductTest']['testGetProperty'] as $value) {
118			$product->setProperty($value['id'],$value['property_value'][0]['id']);
119			}
120
121			foreach ($testData['Overtrue\Wechat\Test\Shop\ProductTest']['testGetSku'] as $value) {
122			foreach ($value['value_list'] as $key => $valueList) {
123			//此判断仅是为了让子序列少点，实际程序按照自身的逻辑来
124			if ($key % 5 == 0 && $key % 2 == 0) {
125			$skuList[] = $valueList['id'];
			0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `$skuList` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$skuList = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
126			}
127
128			}
129			$skuInfo[] = array('id'=>$value['id'],'vid'=>$skuList);
			0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `$skuInfo` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$skuInfo = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history... Bug introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report The variable `$skuList` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
130			$product->setSkuInfo($value['id'],$skuList);
131			}
132
133			foreach ($skuInfo[0]['vid'] as $vid) {
134			foreach ($skuInfo[1]['vid'] as $vid1) {
135			$product->setSkuList(100, 20, $image['item'][0]['url'], 100, array(array($skuInfo[0]['id'], $vid), array($skuInfo[1]['id'], $vid1)));
			0 ignored issues – show Bug introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report The variable `$skuInfo` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `array(array($skuInfo[0][...uInfo[1]['id'], $vid1))` is of type `array<integer,array<inte...:\"?\",\"1\":\"?\"}>"}>`, but the function expects a `null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
136			}
137			}
138
139			$data = $product->setAttrext(0,1,1,1)
140			->setLocation('浙江省','杭州市','滨江区阿里园')
141			->setDeliveryInfo(1,'400184180')
			0 ignored issues – show Documentation introduced 2015-11-25 02:49 UTC by Report Bug Copy Issue Report `'400184180'` is of type `string`, but the function expects a `null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
142			->toArray();
143			$this->assertTrue(is_array($data));
144
145			// //以上架
146			// $product = new Product(true);
147			// $data = $product->setBaseAttr('main_img',array('img','img'))
148			// ->setDetail('text','text')
149			// ->setDetail('img','image')
150			// //->setProperty('id','vid')
151			// //->setProperty('id','vid')
152			// ->setSkuInfo('id',array('vid','vid'))
153			// //统一售价
154			// //->setSkuList('原价','微信价','sku_ico','sku 库存');
155			// //设置ｓｋｕ售价
156			// ->setSkuList('原价','微信价','sku_ico','sku 库存',array('id'=>'vid','id1'=>'vid1'))
157			// ->setAttrext(0,1,1,1)
158			// ->setLocation('浙江省','杭州市','滨江区阿里园')
159			// ->setDeliveryInfo(1,'400184180')
160			// ->toArray();
161			// $this->assertTrue(is_array($data));
162
163
164			}
165			}
166

overtrue / wechat

Push — master ( a3c7a7...bd72ff )

ProductTest::testGetData() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like