Overtrue\Wechat\Shop\Stock

Complexity

Total Complexity

8

Size/Duplication

Total Lines	77
Duplicated Lines	27.27 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	add()	11	11	2
A	reduce()	10	10	2
B	getSkuInfo()	0	23	4

<?php
/**
 * Stock.php
 *
 * Part of Overtrue\Wechat.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author    a939638621 <a939638621@hotmail.com>
 * @copyright 2015 a939638621 <a939638621@hotmail.com>
 * @link      https://github.com/a939638621
 */

namespace Overtrue\Wechat\Shop;


use Overtrue\Wechat\Shop\Foundation\Base;
use Overtrue\Wechat\Shop\Foundation\Stock as StockInterface;
use Overtrue\Wechat\Shop\Foundation\ShopsException;

/**
 * Class Stock
 * @package Shop
 */
class Stock extends Base implements StockInterface
{

    const API_ADD = 'https://api.weixin.qq.com/merchant/stock/add';
    const API_REDUCE = 'https://api.weixin.qq.com/merchant/stock/reduce';

    /**
     * 增加库存
     *
     * @param $productId
     * @param $quantity
     * @param string|array $skuInfo
     * @return bool
     * @throws ShopsException
     */
    public function add($productId, $quantity, $skuInfo = null)
    {
        $this->response = $this->http->jsonPost(self::API_ADD,array(
            'product_id' => $productId,
            'sku_info' => is_null($skuInfo) ? '' : $this->getSkuInfo($skuInfo),

It seems like $skuInfo defined by parameter $skuInfo on line 41 can also be of type string; however, Overtrue\Wechat\Shop\Stock::getSkuInfo() does only seem to accept array, maybe add an additional type check?

            'quantity' => $quantity
        ));

        return $this->getResponse();

The expression $this->getResponse(); of type boolean|array adds the type array to the return on line 49 which is incompatible with the return type declared by the interface Overtrue\Wechat\Shop\Foundation\Stock::add of type boolean.

    }

    /**
     * 减少库存
     *
     * @param array $productId
     * @param string|array $skuInfo
     * @param int $quantity
     * @return bool
     * @throws ShopsException
     */
    public function reduce($productId, $quantity, $skuInfo = null)
    {
        $this->response = $this->http->jsonPost(self::API_REDUCE,array(
            'product_id' => $productId,
            'sku_info' => is_null($skuInfo) ? '' : $this->getSkuInfo($skuInfo),

It seems like $skuInfo defined by parameter $skuInfo on line 62 can also be of type string; however, Overtrue\Wechat\Shop\Stock::getSkuInfo() does only seem to accept array, maybe add an additional type check?

            'quantity' => $quantity
        ));

        return $this->getResponse();
    }

    /**
     * 拼装 SkuInfo Str
     *
     * @param array $skuInfo
     * @return string
     */
    public static function getSkuInfo($skuInfo)
    {
        if (is_string($skuInfo)) return $skuInfo;

        $str = '';
//        array(
//            array('id','vid'),
//            array('id1','vid1'),
//            //.....
//        );
        $i = 0;
        foreach ($skuInfo as $v) {
            $i++;
            if (count($skuInfo) > $i) {
                $str.= $v[0].':'.$v[1].';';
            } else {
                $str.= $v[0].':'.$v[1];
            }

        }

        return $str;
    }
}