EasyWeChat\Kernel\Support\XML

Complexity

Total Complexity

19

Size/Duplication

Total Lines	132
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	parse()	0	9	1
A	normalize()	0	22	6
B	data2Xml()	0	22	7
A	build()	0	24	4
A	cdata()	0	3	1

<?php

/*
 * This file is part of the overtrue/wechat.
 *
 * (c) overtrue <i@overtrue.me>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace EasyWeChat\Kernel\Support;

use SimpleXMLElement;

/**
 * Class XML.
 */
class XML
{
    /**
     * XML to array.
     *
     * @param string $xml XML string
     *
     * @return array
     */
    public static function parse($xml)
    {
        $backup = libxml_disable_entity_loader(true);

        $result = self::normalize(simplexml_load_string($xml, 'SimpleXMLElement', LIBXML_COMPACT | LIBXML_NOCDATA | LIBXML_NOBLANKS));

It seems like simplexml_load_string($xml, 'SimpleXMLElement', EasyWeChat\Kernel\Support\LIBXML_COMPACT | EasyWeChat\Kernel\Support\LIBXML_NOCDATA | EasyWeChat\Kernel\Support\LIBXML_NOBLANKS) can also be of type false; however, parameter $obj of EasyWeChat\Kernel\Support\XML::normalize() does only seem to accept SimpleXMLElement, maybe add an additional type check?

        libxml_disable_entity_loader($backup);

        return $result;
    }

    /**
     * XML encode.
     *
     * @param mixed  $data
     * @param string $root
     * @param string $item
     * @param string $attr
     * @param string $id
     *
     * @return string
     */
    public static function build(
        $data,
        $root = 'xml',
        $item = 'item',
        $attr = '',
        $id = 'id'
    ) {
        if (is_array($attr)) {

The condition is_array($attr) is always false.

            $_attr = [];

            foreach ($attr as $key => $value) {
                $_attr[] = "{$key}=\"{$value}\"";

As per coding-style, please use concatenation or sprintf for the variable $key instead of interpolation.

As per coding-style, please use concatenation or sprintf for the variable $value instead of interpolation.

            }

            $attr = implode(' ', $_attr);
        }

        $attr = trim($attr);
        $attr = empty($attr) ? '' : " {$attr}";

As per coding-style, please use concatenation or sprintf for the variable $attr instead of interpolation.

        $xml = "<{$root}{$attr}>";

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

As per coding-style, please use concatenation or sprintf for the variable $root instead of interpolation.

As per coding-style, please use concatenation or sprintf for the variable $attr instead of interpolation.

        $xml .= self::data2Xml($data, $item, $id);
        $xml .= "</{$root}>";

As per coding-style, please use concatenation or sprintf for the variable $root instead of interpolation.

        return $xml;
    }

    /**
     * Build CDATA.
     *
     * @param string $string
     *
     * @return string
     */
    public static function cdata($string)
    {
        return sprintf('<![CDATA[%s]]>', $string);
    }

    /**
     * Object to array.
     *
     *
     * @param SimpleXMLElement $obj
     *
     * @return array
     */
    protected static function normalize($obj)
    {
        $result = null;

        if (is_object($obj)) {
            $obj = (array) $obj;
        }

        if (is_array($obj)) {
            foreach ($obj as $key => $value) {
                $res = self::normalize($value);
                if (('@attributes' === $key) && ($key)) {
                    $result = $res; // @codeCoverageIgnore
                } else {
                    $result[$key] = $res;
                }
            }
        } else {
            $result = $obj;
        }

        return $result;
    }

    /**
     * Array to XML.
     *
     * @param array  $data
     * @param string $item
     * @param string $id
     *
     * @return string
     */
    protected static function data2Xml($data, $item = 'item', $id = 'id')
    {
        $xml = $attr = '';

        foreach ($data as $key => $val) {
            if (is_numeric($key)) {
                $id && $attr = " {$id}=\"{$key}\"";

As per coding-style, please use concatenation or sprintf for the variable $id instead of interpolation.

As per coding-style, please use concatenation or sprintf for the variable $key instead of interpolation.

                $key = $item;

Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space

            }

            $xml .= "<{$key}{$attr}>";

As per coding-style, please use concatenation or sprintf for the variable $key instead of interpolation.

As per coding-style, please use concatenation or sprintf for the variable $attr instead of interpolation.

            if ((is_array($val) || is_object($val))) {
                $xml .= self::data2Xml((array) $val, $item, $id);
            } else {
                $xml .= is_numeric($val) ? $val : self::cdata($val);
            }

            $xml .= "</{$key}>";

As per coding-style, please use concatenation or sprintf for the variable $key instead of interpolation.

        }

        return $xml;
    }
}