ExternalContact::__get() - Code Metrics - Inspection of "feat(企业微信): 增加外部联系人管理" - overtrue/wechat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1565)

by milkmeowo

created 2019-06-21 03:11 UTC

ExternalContact::__get() A

↳ Parent: ExternalContact

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	1
dl	0
loc	7
ccs	4
cts	4
cp	1
crap	2
rs	10
c	0
b	0
f	0

<?php

/*
 * This file is part of the overtrue/wechat.
 *
 * (c) overtrue <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace EasyWeChat\Work\ExternalContact;

use EasyWeChat\Kernel\Exceptions\InvalidArgumentException;

/**
 * Class ExternalContact.
 *
 * @author milkmeowo <[email protected]>
 *
 * @property \EasyWeChat\Work\ExternalContact\ContactWayClient $contact_way
 * @property \EasyWeChat\Work\ExternalContact\DataCubeClient $data_cube
 * @property \EasyWeChat\Work\ExternalContact\DimissionClient $dimission
 * @property \EasyWeChat\Work\ExternalContact\MessageClient $msg
 */
class ExternalContact extends Client
{
    /**
     * @param string $property
     *
     * @return mixed
     *
     * @throws \EasyWeChat\Kernel\Exceptions\InvalidArgumentException
     */
    public function __get($property)
    {
        if (isset($this->app["external_contact.{$property}"])) {
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            return $this->app["external_contact.{$property}"];
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        throw new InvalidArgumentException(sprintf('No external_contact service named "%s".', $property));
    }
}


1		<?php
2
3		/*
4		* This file is part of the overtrue/wechat.
5		*
6		* (c) overtrue <[email protected]>
7		*
8		* This source file is subject to the MIT license that is bundled
9		* with this source code in the file LICENSE.
10		*/
11
12		namespace EasyWeChat\Work\ExternalContact;
13
14		use EasyWeChat\Kernel\Exceptions\InvalidArgumentException;
15
16		/**
17		* Class ExternalContact.
18		*
19		* @author milkmeowo <[email protected]>
20		*
21		* @property \EasyWeChat\Work\ExternalContact\ContactWayClient $contact_way
22		* @property \EasyWeChat\Work\ExternalContact\DataCubeClient $data_cube
23		* @property \EasyWeChat\Work\ExternalContact\DimissionClient $dimission
24		* @property \EasyWeChat\Work\ExternalContact\MessageClient $msg
25		*/
26		class ExternalContact extends Client
27		{
28		/**
29		* @param string $property
30		*
31		* @return mixed
32		*
33		* @throws \EasyWeChat\Kernel\Exceptions\InvalidArgumentException
34		*/
35	1	public function __get($property)
36		{
37	1	if (isset($this->app["external_contact.{$property}"])) {
		0 ignored issues – show Coding Style Best Practice introduced 2019-06-21 03:15 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$property` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
38	1	return $this->app["external_contact.{$property}"];
		0 ignored issues – show Coding Style Best Practice introduced 2019-06-21 03:15 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$property` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
39		}
40
41	1	throw new InvalidArgumentException(sprintf('No external_contact service named "%s".', $property));
42		}
43		}
44

overtrue / wechat

Pull Request — master (#1565)

ExternalContact::__get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like