Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
30 | class Transformer |
||
31 | { |
||
32 | /** |
||
33 | * transform message to XML. |
||
34 | * |
||
35 | * @param array|string|AbstractMessage $message |
||
36 | * |
||
37 | * @return array |
||
38 | */ |
||
39 | 10 | View Code Duplication | public function transform($message) |
55 | |||
56 | /** |
||
57 | * Transform text message. |
||
58 | * |
||
59 | * @return array |
||
60 | */ |
||
61 | 5 | public function transformText(AbstractMessage $message) |
|
67 | |||
68 | /** |
||
69 | * Transform image message. |
||
70 | * |
||
71 | * @return array |
||
72 | */ |
||
73 | 1 | public function transformImage(AbstractMessage $message) |
|
81 | |||
82 | /** |
||
83 | * Transform video message. |
||
84 | * |
||
85 | * @return array |
||
86 | */ |
||
87 | 1 | public function transformVideo(AbstractMessage $message) |
|
88 | { |
||
89 | $response = [ |
||
90 | 'Video' => [ |
||
91 | 1 | 'MediaId' => $message->get('media_id'), |
|
92 | 1 | 'Title' => $message->get('title'), |
|
93 | 1 | 'Description' => $message->get('description'), |
|
94 | 1 | ], |
|
95 | 1 | ]; |
|
96 | |||
97 | 1 | return $response; |
|
98 | } |
||
99 | |||
100 | /** |
||
101 | * Transform voice message. |
||
102 | * |
||
103 | * @return array |
||
104 | */ |
||
105 | 1 | public function transformVoice(AbstractMessage $message) |
|
113 | |||
114 | /** |
||
115 | * Transform transfer message. |
||
116 | * |
||
117 | * @return array |
||
118 | */ |
||
119 | 1 | public function transformTransfer(AbstractMessage $message) |
|
132 | |||
133 | /** |
||
134 | * Transform news message. |
||
135 | * |
||
136 | * @param array|EasyWeChat\Message\News $news |
||
137 | * |
||
138 | * @return array |
||
139 | */ |
||
140 | 1 | View Code Duplication | public function transformNews($news) |
162 | } |
||
163 |