data_get() - Code Metrics - Inspection of "沙盒退款" - overtrue/wechat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1430)

by mingyoung

created 2018-12-18 04:47 UTC

data_get() B

↳ Parent: Project

Complexity

Conditions	8
Paths	7

Size

Total Lines	17
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	9.8645

Importance

Changes

Metric	Value
cc	8
eloc	15
nc	7
nop	3
dl	0
loc	17
ccs	9
cts	13
cp	0.6923
crap	9.8645
rs	8.4444
c	0
b	0
f	0

<?php

/*
 * This file is part of the overtrue/wechat.
 *
 * (c) overtrue <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace EasyWeChat\Kernel;

use EasyWeChat\Kernel\Contracts\Arrayable;
use EasyWeChat\Kernel\Exceptions\RuntimeException;
use EasyWeChat\Kernel\Support\Arr;
use EasyWeChat\Kernel\Support\Collection;

function data_get($data, $key, $default = null)

{
    switch (true) {
        case is_array($data):
            return Arr::get($data, $key, $default);
        case $data instanceof Collection:
            return $data->get($key, $default);
        case $data instanceof Arrayable:
            return Arr::get($data->toArray(), $key, $default);
        case $data instanceof \ArrayIterator:
            return $data->getArrayCopy()[$key] ?? $default;
        case $data instanceof \ArrayAccess:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
            return $data[$key] ?? $default;
        case $data instanceof \IteratorAggregate && $data->getIterator() instanceof \ArrayIterator:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
            return $data->getIterator()->getArrayCopy()[$key] ?? $default;
        default:
switch ($expr) {
    default: { //wrong
        doSomething();
        break;
    }
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
            throw new RuntimeException(sprintf('Can\'t access data with key "%s"', $key));
    }
}

function data_to_array($data)

{
    switch (true) {
        case is_array($data):
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
            return $data;
        case $data instanceof Collection:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
            return $data->all();
        case $data instanceof Arrayable:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
            return $data->toArray();
        case $data instanceof \IteratorAggregate && $data->getIterator() instanceof \ArrayIterator:
            return $data->getIterator()->getArrayCopy();
        case $data instanceof \ArrayIterator:
            return $data->getArrayCopy();
        default:
            throw new RuntimeException(sprintf('Can\'t transform data to array'));
    }
}


1		<?php
2
3		/*
4		* This file is part of the overtrue/wechat.
5		*
6		* (c) overtrue <[email protected]>
7		*
8		* This source file is subject to the MIT license that is bundled
9		* with this source code in the file LICENSE.
10		*/
11
12		namespace EasyWeChat\Kernel;
13
14		use EasyWeChat\Kernel\Contracts\Arrayable;
15		use EasyWeChat\Kernel\Exceptions\RuntimeException;
16		use EasyWeChat\Kernel\Support\Arr;
17		use EasyWeChat\Kernel\Support\Collection;
18
19		function data_get($data, $key, $default = null)
		0 ignored issues – show Coding Style introduced 2017-12-18 12:39 UTC by Report Bug Copy Issue Report As per coding-style, this function should be in camelCase. CamelCase (...) is the practice of writing compound words or phrases such that each word or abbreviation begins with a capital letter. Learn more about camelCase. Loading history...
20		{
21		switch (true) {
22	1	case is_array($data):
23	1	return Arr::get($data, $key, $default);
24		case $data instanceof Collection:
25	1	return $data->get($key, $default);
26		case $data instanceof Arrayable:
27	1	return Arr::get($data->toArray(), $key, $default);
28		case $data instanceof \ArrayIterator:
29	1	return $data->getArrayCopy()[$key] ?? $default;
30		case $data instanceof \ArrayAccess:
		0 ignored issues – show Coding Style introduced 2017-12-18 12:39 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
31	1	return $data[$key] ?? $default;
32	1	case $data instanceof \IteratorAggregate && $data->getIterator() instanceof \ArrayIterator:
		0 ignored issues – show Coding Style introduced 2017-12-18 12:39 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
33	1	return $data->getIterator()->getArrayCopy()[$key] ?? $default;
34		default:
		0 ignored issues – show Coding Style introduced 2017-12-18 12:39 UTC by Report Bug Copy Issue Report DEFAULT statements must be defined using a colon As per the PSR-2 coding standard, default statements should not be wrapped in curly braces. switch ($expr) { default: { //wrong doSomething(); break; } } switch ($expr) { default: //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
35	1	throw new RuntimeException(sprintf('Can\'t access data with key "%s"', $key));
36		}
37		}
38
39		function data_to_array($data)
		0 ignored issues – show Coding Style introduced 2017-12-18 12:39 UTC by Report Bug Copy Issue Report As per coding-style, this function should be in camelCase. CamelCase (...) is the practice of writing compound words or phrases such that each word or abbreviation begins with a capital letter. Learn more about camelCase. Loading history...
40		{
41		switch (true) {
42	1	case is_array($data):
		0 ignored issues – show Coding Style introduced 2017-12-18 12:39 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
43	1	return $data;
44		case $data instanceof Collection:
		0 ignored issues – show Coding Style introduced 2017-12-18 12:39 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
45	1	return $data->all();
46		case $data instanceof Arrayable:
		0 ignored issues – show Coding Style introduced 2017-12-18 12:39 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
47	1	return $data->toArray();
48	1	case $data instanceof \IteratorAggregate && $data->getIterator() instanceof \ArrayIterator:
49	1	return $data->getIterator()->getArrayCopy();
50	1	case $data instanceof \ArrayIterator:
51	1	return $data->getArrayCopy();
52		default:
53	1	throw new RuntimeException(sprintf('Can\'t transform data to array'));
54		}
55		}
56

overtrue / wechat

Pull Request — master (#1430)

data_get() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like