overtrue /
wechat
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 33 | class AccessToken extends WechatAccessToken |
||
| 34 | { |
||
| 35 | use VerifyTicket; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * API. |
||
| 39 | */ |
||
| 40 | const API_TOKEN_GET = 'https://api.weixin.qq.com/cgi-bin/component/api_component_token'; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * {@inheritdoc}. |
||
| 44 | */ |
||
| 45 | protected $queryName = 'component_access_token'; |
||
| 46 | |||
| 47 | /** |
||
| 48 | * {@inheritdoc}. |
||
| 49 | */ |
||
| 50 | protected $tokenJsonKey = 'component_access_token'; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * {@inheritdoc}. |
||
| 54 | */ |
||
| 55 | protected $prefix = 'easywechat.common.component_access_token.'; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * {@inheritdoc}. |
||
| 59 | */ |
||
| 60 | View Code Duplication | public function getTokenFromServer() |
|
| 78 | } |
||
| 79 |
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: