Overtrue\Pinyin\MemoryFileDictLoader

Complexity

Total Complexity

8

Size/Duplication

Total Lines	71
Duplicated Lines	9.86 %

Coupling/Cohesion

Components	2
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	12	3
A	map()	0	6	2
A	mapSurname()	0	12	3

<?php

/*
 * This file is part of the overtrue/pinyin.
 *
 * (c) 2016 overtrue <i@overtrue.me>
 */

namespace Overtrue\Pinyin;

use Closure;

/**
 * Memory Dict File loader.
 */
class MemoryFileDictLoader implements DictLoaderInterface
{
    /**
     * Words segment name.
     *
     * @var string
     */
    protected $segmentName = 'words_%s';

    /**
     * Segment files.
     *
     * @var array
     */
    protected $segments = array();

    /**
     * Surname cache.
     *
     * @var array
     */
    protected $surnames = array();

    /**
     * Constructor.
     *
     * @param string $path
     */
    public function __construct($path)
    {
        $this->path = $path;

The property path does not exist. Did you maybe forget to declare it?

        for ($i = 0; $i < 100; ++$i) {

This code seems to be duplicated across your project.

            $segment = $path.'/'.sprintf($this->segmentName, $i);

            if (file_exists($segment)) {
                $this->segments[] = (array) include $segment;
            }
        }
    }

    /**
     * Load dict.
     *
     * @param Closure $callback
     */
    public function map(Closure $callback)
    {
        foreach ($this->segments as $dictionary) {
            $callback($dictionary);
        }
    }

    /**
     * Load surname dict.
     *
     * @param Closure $callback
     */
    public function mapSurname(Closure $callback)
    {
        if (empty($this->surnames)) {
            $surnames = $this->path.'/surnames';

            if (file_exists($surnames)) {
                $this->surnames = (array) include $surnames;
            }
        }

        $callback($this->surnames);
    }
}