FileToMemoryDictLoader::__construct() - Code Metrics - Inspection of "新增一个读入内存的 loader 以提升效率 (#68)" - overtrue/pinyin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 339665...0b0f67 )

by Carlos

created 2016-11-17 05:20 UTC

FileToMemoryDictLoader::__construct() A

↳ Parent: FileToMemoryDictLoader

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	6

Duplication

Lines	10
Ratio	100 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	10
loc	10
ccs	9
cts	9
cp	1
rs	9.4285
cc	3
eloc	6
nc	3
nop	1
crap	3

<?php

/*
 * This file is part of the overtrue/pinyin.
 *
 * (c) 2016 overtrue <[email protected]>
 */

namespace Overtrue\Pinyin;

use Closure;

/**
 * Dict File loader.
 */
class FileToMemoryDictLoader extends FileDictLoader implements DictLoaderInterface
{
    /**
     * Segment files
     *
     * @var array
     */
    protected $segments = array();

    /**
     * Constructor.
     *
     * @param string $path
     */
    public function __construct($path)

    {
        parent::__construct($path);
        for ($i = 0; $i < 100; ++$i) {
            $segment = $this->path . '/' . sprintf($this->segmentName, $i);
            if (file_exists($segment)) {
                $this->segments[] = (array) include $segment;
            }
        }
    }

    /**
     * Load dict.
     *
     * @param Closure $callback
     */
    public function map(Closure $callback)
    {
        foreach ($this->segments as $dictionary) {
            $callback($dictionary);
        }

    }
}


1			<?php
2
3			/*
4			* This file is part of the overtrue/pinyin.
5			*
6			* (c) 2016 overtrue <[email protected]>
7			*/
8
9			namespace Overtrue\Pinyin;
10
11			use Closure;
12
13			/**
14			* Dict File loader.
15			*/
16			class FileToMemoryDictLoader extends FileDictLoader implements DictLoaderInterface
17			{
18			/**
19			* Segment files
20			*
21			* @var array
22			*/
23			protected $segments = array();
24
25			/**
26			* Constructor.
27			*
28			* @param string $path
29			*/
30	9	View Code Duplication	public function __construct($path)
			0 ignored issues – show Duplication introduced 2016-11-16 12:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31			{
32	9		parent::__construct($path);
33	9		for ($i = 0; $i < 100; ++$i) {
34	9		$segment = $this->path . '/' . sprintf($this->segmentName, $i);
35	9		if (file_exists($segment)) {
36	9		$this->segments[] = (array) include $segment;
37	9		}
38	9		}
39	9		}
40
41			/**
42			* Load dict.
43			*
44			* @param Closure $callback
45			*/
46	9		public function map(Closure $callback)
47			{
48	9		foreach ($this->segments as $dictionary) {
49	9		$callback($dictionary);
50	9		}
51
52	9		}
53			}
54

overtrue / pinyin

GitHub Access Token became invalid

Push — master ( 339665...0b0f67 )

FileToMemoryDictLoader::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like