Overtrue\LaravelFollow\Traits\CanBeVoted

Complexity

Total Complexity

6

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	isUpvotedBy()	0	3	1
A	downvoters()	0	5	1
A	isDownvotedBy()	0	3	1
A	isVotedBy()	0	3	1
A	voters()	0	5	1
A	upvoters()	0	5	1

<?php

/*
 * This file is part of the overtrue/laravel-follow
 *
 * (c) overtrue <i@overtrue.me>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Overtrue\LaravelFollow\Traits;

use Overtrue\LaravelFollow\Follow;

/**
 * Trait CanBeVoted.
 */
trait CanBeVoted
{
    /**
     * Check if item is voted by given user.
     *
     * @param int $user
     *
     * @return bool
     */
    public function isVotedBy($user, $type = null)

The parameter $type is not used and could be removed.

    {
        return Follow::isRelationExists($this, 'voters', $user);

$this of type Overtrue\LaravelFollow\Traits\CanBeVoted is incompatible with the type Illuminate\Database\Eloquent\Model expected by parameter $model of Overtrue\LaravelFollow\Follow::isRelationExists().

    }
	
	/**
	 * Check if item is upvoted by given user.
	 *
	 * @param int $user
	 *
	 * @return bool
	 */
	public function isUpvotedBy($user)
	{
		return Follow::isRelationExists($this, 'upvoters', $user);

$this of type Overtrue\LaravelFollow\Traits\CanBeVoted is incompatible with the type Illuminate\Database\Eloquent\Model expected by parameter $model of Overtrue\LaravelFollow\Follow::isRelationExists().

	}
	
	/**
	 * Check if item is downvoted by given user.
	 *
	 * @param int $user
	 *
	 * @return bool
	 */
	public function isDownvotedBy($user)
	{
		return Follow::isRelationExists($this, 'downvoters', $user);

$this of type Overtrue\LaravelFollow\Traits\CanBeVoted is incompatible with the type Illuminate\Database\Eloquent\Model expected by parameter $model of Overtrue\LaravelFollow\Follow::isRelationExists().

	}

    /**
     * Return voters.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
     */
    public function voters()
    {
        return $this->morphToMany(config('follow.user_model'), config('follow.morph_prefix'), config('follow.followable_table'))

It seems like morphToMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                    ->wherePivotIn('relation', [Follow::RELATION_UPVOTE, Follow::RELATION_DOWNVOTE])
                    ->withPivot('followable_type', 'relation', 'created_at');
    }
	
	/**
	 * Return upvoters.
	 *
	 * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
	 */
	public function upvoters()
	{
		return $this->morphToMany(config('follow.user_model'), config('follow.morph_prefix'), config('follow.followable_table'))
		            ->wherePivot('relation', '=', Follow::RELATION_UPVOTE)
		            ->withPivot('followable_type', 'relation', 'created_at');
	}
	
	/**
	 * Return downvoters.
	 *
	 * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
	 */
	public function downvoters()
	{
		return $this->morphToMany(config('follow.user_model'), config('follow.morph_prefix'), config('follow.followable_table'))
		            ->wherePivot('relation', '=', Follow::RELATION_DOWNVOTE)
		            ->withPivot('followable_type', 'relation', 'created_at');
	}
}