Complex classes like QiniuAdapter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use QiniuAdapter, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
25 | class QiniuAdapter extends AbstractAdapter |
||
26 | { |
||
27 | use NotSupportingVisibilityTrait; |
||
28 | |||
29 | /** |
||
30 | * @var string |
||
31 | */ |
||
32 | protected $accessKey; |
||
33 | |||
34 | /** |
||
35 | * @var string |
||
36 | */ |
||
37 | protected $secretKey; |
||
38 | |||
39 | /** |
||
40 | * @var string |
||
41 | */ |
||
42 | protected $bucket; |
||
43 | |||
44 | /** |
||
45 | * @var string |
||
46 | */ |
||
47 | protected $domain; |
||
48 | |||
49 | /** |
||
50 | * @var \Qiniu\Auth |
||
51 | */ |
||
52 | protected $authManager; |
||
53 | |||
54 | /** |
||
55 | * @var \Qiniu\Storage\UploadManager |
||
56 | */ |
||
57 | protected $uploadManager; |
||
58 | |||
59 | /** |
||
60 | * @var \Qiniu\Storage\BucketManager |
||
61 | */ |
||
62 | protected $bucketManager; |
||
63 | |||
64 | /** |
||
65 | * @var \Qiniu\Cdn\CdnManager |
||
66 | */ |
||
67 | protected $cdnManager; |
||
68 | |||
69 | /** |
||
70 | * QiniuAdapter constructor. |
||
71 | * |
||
72 | * @param string $accessKey |
||
73 | * @param string $secretKey |
||
74 | * @param string $bucket |
||
75 | * @param string $domain |
||
76 | */ |
||
77 | 1 | public function __construct($accessKey, $secretKey, $bucket, $domain) |
|
84 | |||
85 | /** |
||
86 | * Write a new file. |
||
87 | * |
||
88 | * @param string $path |
||
89 | * @param string $contents |
||
90 | * @param Config $config Config object |
||
91 | * |
||
92 | * @return array|false false on failure file meta data on success |
||
93 | */ |
||
94 | 2 | public function write($path, $contents, Config $config) |
|
117 | |||
118 | /** |
||
119 | * Write a new file using a stream. |
||
120 | * |
||
121 | * @param string $path |
||
122 | * @param resource $resource |
||
123 | * @param Config $config Config object |
||
124 | * |
||
125 | * @return array|false false on failure file meta data on success |
||
126 | */ |
||
127 | 1 | public function writeStream($path, $resource, Config $config) |
|
143 | |||
144 | /** |
||
145 | * Update a file. |
||
146 | * |
||
147 | * @param string $path |
||
148 | * @param string $contents |
||
149 | * @param Config $config Config object |
||
150 | * |
||
151 | * @return array|false false on failure file meta data on success |
||
152 | */ |
||
153 | 1 | public function update($path, $contents, Config $config) |
|
159 | |||
160 | /** |
||
161 | * Update a file using a stream. |
||
162 | * |
||
163 | * @param string $path |
||
164 | * @param resource $resource |
||
165 | * @param Config $config Config object |
||
166 | * |
||
167 | * @return array|false false on failure file meta data on success |
||
168 | */ |
||
169 | 1 | public function updateStream($path, $resource, Config $config) |
|
175 | |||
176 | /** |
||
177 | * Rename a file. |
||
178 | * |
||
179 | * @param string $path |
||
180 | * @param string $newPath |
||
181 | * |
||
182 | * @return bool |
||
183 | */ |
||
184 | 1 | public function rename($path, $newPath) |
|
190 | |||
191 | /** |
||
192 | * Copy a file. |
||
193 | * |
||
194 | * @param string $path |
||
195 | * @param string $newPath |
||
196 | * |
||
197 | * @return bool |
||
198 | */ |
||
199 | 1 | public function copy($path, $newPath) |
|
205 | |||
206 | /** |
||
207 | * Delete a file. |
||
208 | * |
||
209 | * @param string $path |
||
210 | * |
||
211 | * @return bool |
||
212 | */ |
||
213 | 1 | public function delete($path) |
|
219 | |||
220 | /** |
||
221 | * Delete a directory. |
||
222 | * |
||
223 | * @param string $directory |
||
224 | * |
||
225 | * @return bool |
||
226 | */ |
||
227 | 1 | public function deleteDir($directory) |
|
231 | |||
232 | /** |
||
233 | * Create a directory. |
||
234 | * |
||
235 | * @param string $directory directory name |
||
236 | * @param Config $config |
||
237 | * |
||
238 | * @return array|false |
||
239 | */ |
||
240 | 1 | public function createDir($directory, Config $config) |
|
244 | |||
245 | /** |
||
246 | * Check whether a file exists. |
||
247 | * |
||
248 | * @param string $path |
||
249 | * |
||
250 | * @return array|bool|null |
||
251 | */ |
||
252 | 1 | public function has($path) |
|
258 | |||
259 | /** |
||
260 | * Get resource url. |
||
261 | * |
||
262 | * @param string $path |
||
263 | * |
||
264 | * @return string |
||
265 | */ |
||
266 | 3 | public function getUrl($path) |
|
273 | |||
274 | /** |
||
275 | * Read a file. |
||
276 | * |
||
277 | * @param string $path |
||
278 | 1 | * |
|
279 | * @return array|false |
||
280 | 1 | */ |
|
281 | public function read($path) |
||
287 | |||
288 | /** |
||
289 | * Read a file as a stream. |
||
290 | * |
||
291 | * @param string $path |
||
292 | 1 | * |
|
293 | * @return array|false |
||
294 | 1 | */ |
|
295 | 1 | public function readStream($path) |
|
305 | |||
306 | /** |
||
307 | * List contents of a directory. |
||
308 | * |
||
309 | * @param string $directory |
||
310 | * @param bool $recursive |
||
311 | 1 | * |
|
312 | * @return array |
||
313 | 1 | */ |
|
314 | public function listContents($directory = '', $recursive = false) |
||
326 | |||
327 | /** |
||
328 | * Get all the meta data of a file or directory. |
||
329 | * |
||
330 | * @param string $path |
||
331 | 1 | * |
|
332 | * @return array|false |
||
333 | 1 | */ |
|
334 | 1 | public function getMetadata($path) |
|
341 | |||
342 | /** |
||
343 | * Get the size of a file. |
||
344 | * |
||
345 | * @param string $path |
||
346 | 1 | * |
|
347 | * @return array|false |
||
348 | 1 | */ |
|
349 | public function getSize($path) |
||
353 | |||
354 | /** |
||
355 | * Fetch url to bucket. |
||
356 | * |
||
357 | * @param string $path |
||
358 | * @param string $url |
||
359 | * |
||
360 | * @return array|false |
||
361 | */ |
||
362 | public function fetch($path, $url) |
||
372 | |||
373 | /** |
||
374 | * Get private file download url. |
||
375 | * |
||
376 | * @param string $path |
||
377 | * @param int $expires |
||
378 | 1 | * |
|
379 | * @return string |
||
380 | 1 | */ |
|
381 | public function privateDownloadUrl($path, $expires = 3600) |
||
385 | |||
386 | /** |
||
387 | * Refresh file cache. |
||
388 | * |
||
389 | * @param string|array $path |
||
390 | * |
||
391 | * @return array |
||
392 | 1 | */ |
|
393 | public function refresh($path) |
||
404 | |||
405 | /** |
||
406 | * Get the mime-type of a file. |
||
407 | * |
||
408 | * @param string $path |
||
409 | * |
||
410 | * @return array|false |
||
411 | 1 | */ |
|
412 | public function getMimeType($path) |
||
422 | |||
423 | /** |
||
424 | * Get the timestamp of a file. |
||
425 | * |
||
426 | * @param string $path |
||
427 | * |
||
428 | * @return array|false |
||
429 | 1 | */ |
|
430 | public function getTimestamp($path) |
||
434 | |||
435 | /** |
||
436 | * @param \Qiniu\Storage\BucketManager $manager |
||
437 | * |
||
438 | * @return $this |
||
439 | 1 | */ |
|
440 | public function setBucketManager(BucketManager $manager) |
||
446 | |||
447 | /** |
||
448 | * @param \Qiniu\Storage\UploadManager $manager |
||
449 | * |
||
450 | * @return $this |
||
451 | 1 | */ |
|
452 | public function setUploadManager(UploadManager $manager) |
||
458 | |||
459 | /** |
||
460 | * @param \Qiniu\Auth $manager |
||
461 | * |
||
462 | * @return $this |
||
463 | 1 | */ |
|
464 | public function setAuthManager(Auth $manager) |
||
470 | |||
471 | /** |
||
472 | * @param CdnManager $manager |
||
473 | * |
||
474 | * @return $this |
||
475 | */ |
||
476 | public function setCdnManager(CdnManager $manager) |
||
482 | |||
483 | /** |
||
484 | * @return \Qiniu\Storage\BucketManager |
||
485 | 1 | */ |
|
486 | public function getBucketManager() |
||
490 | |||
491 | /** |
||
492 | * @return \Qiniu\Auth |
||
493 | 1 | */ |
|
494 | public function getAuthManager() |
||
498 | |||
499 | /** |
||
500 | * @return \Qiniu\Storage\UploadManager |
||
501 | 1 | */ |
|
502 | public function getUploadManager() |
||
506 | |||
507 | /** |
||
508 | * @return \Qiniu\Cdn\CdnManager |
||
509 | */ |
||
510 | public function getCdnManager() |
||
514 | |||
515 | /** |
||
516 | * @return string |
||
517 | */ |
||
518 | public function getBucket() |
||
522 | |||
523 | /** |
||
524 | * Get the upload token. |
||
525 | * |
||
526 | * @param string|null $key |
||
527 | * @param int $expires |
||
528 | * @param string|null $policy |
||
529 | * @param string|null $strictPolice |
||
530 | * |
||
531 | * @return string |
||
532 | 1 | */ |
|
533 | public function getUploadToken($key = null, $expires = 3600, $policy = null, $strictPolice = null) |
||
537 | |||
538 | /** |
||
539 | * @param array $stats |
||
540 | * |
||
541 | * @return array |
||
542 | 2 | */ |
|
543 | protected function normalizeFileInfo(array $stats) |
||
552 | |||
553 | /** |
||
554 | * @param string $domain |
||
555 | * |
||
556 | * @return string |
||
557 | 4 | */ |
|
558 | protected function normalizeHost($domain) |
||
566 | |||
567 | /** |
||
568 | * Does a UTF-8 safe version of PHP parse_url function |
||
569 | * |
||
570 | * @param string $url URL to parse |
||
571 | * |
||
572 | * @return mixed Associative array or false if badly formed URL. |
||
573 | * |
||
574 | * @see http://us3.php.net/manual/en/function.parse-url.php |
||
575 | * @since 11.1 |
||
576 | */ |
||
577 | protected static function parse_url($url) |
||
602 | } |
||
603 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: