Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 26 | class Config |
||
| 27 | { |
||
| 28 | /** |
||
| 29 | * @var array |
||
| 30 | */ |
||
| 31 | protected $formatters = []; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var array |
||
| 35 | */ |
||
| 36 | protected $handlers = []; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @var array |
||
| 40 | */ |
||
| 41 | protected $processors = []; |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @var array |
||
| 45 | */ |
||
| 46 | protected $channels = []; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Config constructor. |
||
| 50 | * |
||
| 51 | * @param array $config |
||
| 52 | */ |
||
| 53 | public function __construct(array $config) |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @param string $name |
||
| 60 | * |
||
| 61 | * @return array |
||
|
|
|||
| 62 | */ |
||
| 63 | public function getChannel(string $name) |
||
| 64 | { |
||
| 65 | if (empty($this->channels[$name])) { |
||
| 66 | throw new InvalidArgumentException("No channel named '{$name}' found."); |
||
| 67 | } |
||
| 68 | |||
| 69 | $channel = $this->channels[$name]; |
||
| 70 | $channel['handlers'] = array_flip($channel['handlers']); |
||
| 71 | $channel['processors'] = array_flip($channel['processors']); |
||
| 72 | |||
| 73 | foreach (array_keys($channel['handlers']) as $handlerId) { |
||
| 74 | $channel['handlers'][$handlerId] = $this->resolveHandler($handlerId); |
||
| 75 | } |
||
| 76 | |||
| 77 | foreach (array_keys($channel['processors']) as $processorId) { |
||
| 78 | $channel['processors'][] = $this->resolveProcessor($processorId); |
||
| 79 | } |
||
| 80 | |||
| 81 | $this->channels[$name] = $channel; |
||
| 82 | |||
| 83 | return $channel; |
||
| 84 | } |
||
| 85 | |||
| 86 | /** |
||
| 87 | * @return array |
||
| 88 | */ |
||
| 89 | public function getFormatters() |
||
| 90 | { |
||
| 91 | return $this->formatters; |
||
| 92 | } |
||
| 93 | |||
| 94 | /** |
||
| 95 | * @return array |
||
| 96 | */ |
||
| 97 | public function getHandlers() |
||
| 98 | { |
||
| 99 | return $this->handlers; |
||
| 100 | } |
||
| 101 | |||
| 102 | /** |
||
| 103 | * @return array |
||
| 104 | */ |
||
| 105 | public function getProcessors() |
||
| 106 | { |
||
| 107 | return $this->processors; |
||
| 108 | } |
||
| 109 | |||
| 110 | /** |
||
| 111 | * @return array |
||
| 112 | */ |
||
| 113 | public function getChannels() |
||
| 114 | { |
||
| 115 | return $this->channels; |
||
| 116 | } |
||
| 117 | |||
| 118 | /** |
||
| 119 | * @param string $formatterId |
||
| 120 | * |
||
| 121 | * @return \Monolog\Formatter\FormatterInterface |
||
| 122 | */ |
||
| 123 | protected function resolveFormatter(string $formatterId) |
||
| 124 | { |
||
| 125 | if (!$this->formatters[$formatterId] instanceof FormatterInterface) { |
||
| 126 | $this->formatters[$formatterId] = $this->makeInstance($this->formatters[$formatterId], 'formatter'); |
||
| 127 | } |
||
| 128 | |||
| 129 | return $this->formatters[$formatterId]; |
||
| 130 | } |
||
| 131 | |||
| 132 | /** |
||
| 133 | * @param string $handlerId |
||
| 134 | * |
||
| 135 | * @return \Monolog\Handler\HandlerInterface |
||
| 136 | */ |
||
| 137 | protected function resolveHandler(string $handlerId) |
||
| 138 | { |
||
| 139 | if ($this->handlers[$handlerId] instanceof HandlerInterface) { |
||
| 140 | return $this->handlers[$handlerId]; |
||
| 141 | } |
||
| 142 | |||
| 143 | View Code Duplication | if (!empty($this->handlers[$handlerId]['formatter'])) { |
|
| 144 | $this->handlers[$handlerId]['formatter'] = $this->resolveFormatter($this->handlers[$handlerId]['formatter']); |
||
| 145 | } |
||
| 146 | |||
| 147 | View Code Duplication | if (!empty($this->handlers[$handlerId]['processors'])) { |
|
| 148 | $this->handlers[$handlerId]['processors'] = $this->resolveFormatter($this->handlers[$handlerId]['processors']); |
||
| 149 | } |
||
| 150 | |||
| 151 | return $this->handlers[$handlerId] = $this->makeInstance($this->handlers[$handlerId], 'handler'); |
||
| 152 | } |
||
| 153 | |||
| 154 | /** |
||
| 155 | * @param string $processorId |
||
| 156 | * |
||
| 157 | * @return \Monolog\Handler\HandlerInterface |
||
| 158 | */ |
||
| 159 | protected function resolveProcessor(string $processorId) |
||
| 160 | { |
||
| 161 | if (!is_callable($this->processors[$processorId])) { |
||
| 162 | $this->processors[$processorId] = $this->makeInstance($this->processors[$processorId], 'processor'); |
||
| 163 | } |
||
| 164 | |||
| 165 | return $this->processors[$processorId]; |
||
| 166 | } |
||
| 167 | |||
| 168 | /** |
||
| 169 | * @param string $option |
||
| 170 | * @param string $name |
||
| 171 | * |
||
| 172 | * @return object |
||
| 173 | */ |
||
| 174 | protected function makeInstance($option, $name) |
||
| 175 | { |
||
| 176 | return (new ReflectionClass($option[$name])) |
||
| 177 | ->newInstanceArgs($option['args']); |
||
| 178 | } |
||
| 179 | |||
| 180 | /** |
||
| 181 | * @param array $config |
||
| 182 | */ |
||
| 183 | protected function parse(array $config): void |
||
| 184 | { |
||
| 185 | $config = array_merge([ |
||
| 186 | 'handlers' => [], |
||
| 187 | 'formatters' => [], |
||
| 188 | 'processors' => [], |
||
| 189 | 'channels' => [], |
||
| 190 | ], $config); |
||
| 191 | |||
| 192 | $this->formatters = $this->formatFormatters($config['formatters']); |
||
| 193 | $this->handlers = $this->formatHandlers($config['handlers']); |
||
| 194 | $this->processors = $this->formatProcessors($config['processors']); |
||
| 195 | $this->channels = $this->formatChannels($config['channels']); |
||
| 196 | } |
||
| 197 | |||
| 198 | /** |
||
| 199 | * @param array $formatters |
||
| 200 | * |
||
| 201 | * @return array |
||
| 202 | */ |
||
| 203 | protected function formatFormatters(array $formatters = []) |
||
| 204 | { |
||
| 205 | foreach ($formatters as $id => $option) { |
||
| 206 | $class = $option['formatter'] ?? LineFormatter::class; |
||
| 207 | unset($option['formatter']); |
||
| 208 | |||
| 209 | $formatters[$id] = [ |
||
| 210 | 'formatter' => $class, |
||
| 211 | 'args' => $option, |
||
| 212 | ]; |
||
| 213 | } |
||
| 214 | |||
| 215 | return $formatters; |
||
| 216 | } |
||
| 217 | |||
| 218 | /** |
||
| 219 | * @param array $handlers |
||
| 220 | * |
||
| 221 | * @return array |
||
| 222 | */ |
||
| 223 | protected function formatHandlers(array $handlers = []) |
||
| 224 | { |
||
| 225 | foreach ($handlers as $id => $option) { |
||
| 226 | if (isset($option['formatter']) && !isset($this->formatters[$option['formatter']])) { |
||
| 227 | throw new InvalidArgumentException(sprintf('Formatter %s not configured.', $option['formatter'])); |
||
| 228 | } |
||
| 229 | |||
| 230 | View Code Duplication | if (isset($option['processors'])) { |
|
| 231 | foreach ($option['processors'] as $processorId) { |
||
| 232 | if (!isset($this->processors[$processorId])) { |
||
| 233 | throw new InvalidArgumentException(sprintf('Processor %s not configured.', $processorId)); |
||
| 234 | } |
||
| 235 | } |
||
| 236 | } |
||
| 237 | |||
| 238 | $class = $option['handler'] ?? StreamHandler::class; |
||
| 239 | unset($option['handler']); |
||
| 240 | |||
| 241 | $handlers[$id] = [ |
||
| 242 | 'handler' => $class, |
||
| 243 | 'args' => $option, |
||
| 244 | ]; |
||
| 245 | } |
||
| 246 | |||
| 247 | return $handlers; |
||
| 248 | } |
||
| 249 | |||
| 250 | /** |
||
| 251 | * @param array $processors |
||
| 252 | * |
||
| 253 | * @return array |
||
| 254 | */ |
||
| 255 | protected function formatProcessors(array $processors = []) |
||
| 273 | |||
| 274 | /** |
||
| 275 | * @param array $channels |
||
| 276 | * |
||
| 277 | * @return array |
||
| 278 | */ |
||
| 279 | protected function formatChannels(array $channels = []) |
||
| 302 | } |
||
| 303 |
This check looks for the generic type
arrayas a return type and suggests a more specific type. This type is inferred from the actual code.