Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#123)
by Adrian
05:43
created
ExpressionLanguage/AuthorizationExpressionProvider.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -20,14 +20,14 @@  discard block
 block discarded – undo
20 20
         return [
21 21
             new ExpressionFunction(
22 22
                 'hasRole',
23
-                function ($role) {
23
+                function($role) {
24 24
                     return sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s)', $role);
25 25
                 }
26 26
             ),
27 27
 
28 28
             new ExpressionFunction(
29 29
                 'hasAnyRole',
30
-                function ($roles) {
30
+                function($roles) {
31 31
                     $code = sprintf('array_reduce(%s, function ($isGranted, $role) use ($container) { return $isGranted || $container->get(\'security.authorization_checker\')->isGranted($role); }, false)', $roles);
32 32
 
33 33
                     return $code;
@@ -36,35 +36,35 @@  discard block
 block discarded – undo
36 36
 
37 37
             new ExpressionFunction(
38 38
                 'isAnonymous',
39
-                function () {
39
+                function() {
40 40
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_ANONYMOUSLY\')';
41 41
                 }
42 42
             ),
43 43
 
44 44
             new ExpressionFunction(
45 45
                 'isRememberMe',
46
-                function () {
46
+                function() {
47 47
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\')';
48 48
                 }
49 49
             ),
50 50
 
51 51
             new ExpressionFunction(
52 52
                 'isFullyAuthenticated',
53
-                function () {
53
+                function() {
54 54
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
55 55
                 }
56 56
             ),
57 57
 
58 58
             new ExpressionFunction(
59 59
                 'isAuthenticated',
60
-                function () {
60
+                function() {
61 61
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\') || $container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
62 62
                 }
63 63
             ),
64 64
 
65 65
             new ExpressionFunction(
66 66
                 'hasPermission',
67
-                function ($object, $permission) {
67
+                function($object, $permission) {
68 68
                     $code = sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s, %s)', $permission, $object);
69 69
 
70 70
                     return $code;
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
             new ExpressionFunction(
75 75
                 'hasAnyPermission',
76
-                function ($object, $permissions) {
76
+                function($object, $permissions) {
77 77
                     $code = sprintf('array_reduce(%s, function ($isGranted, $permission) use ($container, $object) { return $isGranted || $container->get(\'security.authorization_checker\')->isGranted($permission, %s); }, false)', $permissions, $object);
78 78
 
79 79
                     return $code;
Please login to merge, or discard this patch.
Executor/Promise/Adapter/ReactPromiseAdapter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,10 +58,10 @@
 block discarded – undo
58 58
         /** @var \React\Promise\PromiseInterface $reactPromise */
59 59
         $reactPromise = $promise->adoptedPromise;
60 60
 
61
-        $reactPromise->then(function ($values) use (&$resolvedValue, &$wait) {
61
+        $reactPromise->then(function($values) use (&$resolvedValue, &$wait) {
62 62
             $resolvedValue = $values;
63 63
             $wait = false;
64
-        }, function ($reason) use (&$exception, &$wait) {
64
+        }, function($reason) use (&$exception, &$wait) {
65 65
             $exception = $reason;
66 66
             $wait = false;
67 67
         });
Please login to merge, or discard this patch.
Tests/Executor/Promise/Adapter/ReactPromiseAdapterTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
55 55
 EOF
56 56
         );
57 57
 
58
-        $promise = $this->adapter->create(function (callable $resolve) use (&$process) {
59
-            $process->start(function () use ($resolve, &$process) {
58
+        $promise = $this->adapter->create(function(callable $resolve) use (&$process) {
59
+            $process->start(function() use ($resolve, &$process) {
60 60
                 $output = $process->getOutput();
61 61
                 $resolve($output);
62 62
             });
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
         $this->assertEquals(
66 66
             $output,
67
-            $this->adapter->wait($promise, function () use (&$process) {
67
+            $this->adapter->wait($promise, function() use (&$process) {
68 68
                 $process->wait();
69 69
             })
70 70
         );
Please login to merge, or discard this patch.
Tests/DIContainerMockTrait.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -18,6 +18,9 @@
 block discarded – undo
18 18
  */
19 19
 trait DIContainerMockTrait
20 20
 {
21
+    /**
22
+     * @return null|\Symfony\Component\DependencyInjection\ContainerInterface
23
+     */
21 24
     private function getDIContainerMock(array $services = [], array $parameters = [])
22 25
     {
23 26
         $container = $this->getMockBuilder('Symfony\\Component\\DependencyInjection\\Container')
Please login to merge, or discard this patch.
Tests/Functional/Relay/Connection/ConnectionTest.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
         $expectedData = [
49 49
             'user' => [
50 50
                 'friends' => [
51
-                   'totalCount' => 4,
51
+                    'totalCount' => 4,
52 52
                     'edges' => [
53 53
                         [
54 54
                             'friendshipTime' => 'Yesterday',
Please login to merge, or discard this patch.
Tests/Functional/Controller/GraphControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@
 block discarded – undo
207 207
         $client->request('POST', $uri, [], [], ['CONTENT_TYPE' => 'application/json'], json_encode($data));
208 208
         $result = $client->getResponse()->getContent();
209 209
 
210
-        $expected  = [
210
+        $expected = [
211 211
             ['id' => 'friends', 'payload' => ['data' => $this->expectedData]],
212 212
             ['id' => 'friendsTotalCount', 'payload' => ['data' => ['user' => ['friends' => ['totalCount' => 4]]]]],
213 213
         ];
Please login to merge, or discard this patch.
Config/EnumTypeDefinition.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -26,10 +26,10 @@
 block discarded – undo
26 26
                 ->arrayNode('values')
27 27
                     ->useAttributeAsKey('name')
28 28
                     ->beforeNormalization()
29
-                        ->ifTrue(function ($v) {
29
+                        ->ifTrue(function($v) {
30 30
                             return is_array($v);
31 31
                         })
32
-                        ->then(function ($v) {
32
+                        ->then(function($v) {
33 33
                             foreach ($v as $name => &$options) {
34 34
                                 // short syntax NAME: VALUE
35 35
                                 if (!is_null($options) && !is_array($options)) {
Please login to merge, or discard this patch.
Config/ObjectTypeDefinition.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -50,10 +50,10 @@  discard block
 block discarded – undo
50 50
     private function treatFieldsDefaultAccess(ArrayNodeDefinition $node)
51 51
     {
52 52
         $node->validate()
53
-            ->ifTrue(function ($v) {
53
+            ->ifTrue(function($v) {
54 54
                 return array_key_exists('fieldsDefaultAccess', $v) && null !== $v['fieldsDefaultAccess'];
55 55
             })
56
-            ->then(function ($v) {
56
+            ->then(function($v) {
57 57
                 foreach ($v['fields'] as &$field) {
58 58
                     if (array_key_exists('access', $field) && null !== $field['access']) {
59 59
                         continue;
@@ -77,10 +77,10 @@  discard block
 block discarded – undo
77 77
     private function treatResolveField(ArrayNodeDefinition $node)
78 78
     {
79 79
         $node->validate()
80
-            ->ifTrue(function ($v) {
80
+            ->ifTrue(function($v) {
81 81
                 return array_key_exists('resolveField', $v) && null !== $v['resolveField'];
82 82
             })
83
-            ->then(function ($v) {
83
+            ->then(function($v) {
84 84
                 $resolveField = $v['resolveField'];
85 85
                 unset($v['resolveField']);
86 86
                 foreach ($v['fields'] as &$field) {
Please login to merge, or discard this patch.
DependencyInjection/Configuration.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -162,6 +162,9 @@  discard block
 block discarded – undo
162 162
         return $treeBuilder;
163 163
     }
164 164
 
165
+    /**
166
+     * @param string $name
167
+     */
165 168
     private function addBuilderSection($name)
166 169
     {
167 170
         $builder = new TreeBuilder();
@@ -195,6 +198,9 @@  discard block
 block discarded – undo
195 198
         return $node;
196 199
     }
197 200
 
201
+    /**
202
+     * @param string $name
203
+     */
198 204
     private function addSecurityQuerySection($name, $disabledValue)
199 205
     {
200 206
         $builder = new TreeBuilder();
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -49,14 +49,14 @@  discard block
 block discarded – undo
49 49
                         ->booleanNode('config_validation')->defaultValue($this->debug)->end()
50 50
                         ->arrayNode('schema')
51 51
                             ->beforeNormalization()
52
-                                ->ifTrue(function ($v) {
52
+                                ->ifTrue(function($v) {
53 53
                                     $needNormalization = isset($v['query']) && is_string($v['query']) ||
54 54
                                         isset($v['mutation']) && is_string($v['mutation']) ||
55 55
                                         isset($v['subscription']) && is_string($v['subscription']);
56 56
 
57 57
                                     return $needNormalization;
58 58
                                 })
59
-                                ->then(function ($v) {
59
+                                ->then(function($v) {
60 60
                                     return ['default' => $v];
61 61
                                 })
62 62
                             ->end()
@@ -167,10 +167,10 @@  discard block
 block discarded – undo
167 167
         $builder = new TreeBuilder();
168 168
         $node = $builder->root($name);
169 169
         $node->beforeNormalization()
170
-            ->ifTrue(function ($v) {
170
+            ->ifTrue(function($v) {
171 171
                 return is_array($v) && !empty($v);
172 172
             })
173
-            ->then(function ($v) {
173
+            ->then(function($v) {
174 174
                 foreach ($v as $key => &$config) {
175 175
                     if (is_string($config)) {
176 176
                         $config = [
@@ -203,16 +203,16 @@  discard block
 block discarded – undo
203 203
         $node
204 204
             ->info('Disabled if equal to false.')
205 205
             ->beforeNormalization()
206
-                ->ifTrue(function ($v) {
206
+                ->ifTrue(function($v) {
207 207
                     return false === $v;
208 208
                 })
209
-                ->then(function () use ($disabledValue) {
209
+                ->then(function() use ($disabledValue) {
210 210
                     return $disabledValue;
211 211
                 })
212 212
             ->end()
213 213
             ->defaultFalse()
214 214
             ->validate()
215
-                ->ifTrue(function ($v) {
215
+                ->ifTrue(function($v) {
216 216
                     return $v < 0;
217 217
                 })
218 218
                 ->thenInvalid('"overblog_graphql.security.'.$name.'" must be greater or equal to 0.')
Please login to merge, or discard this patch.