Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#73)
by Jérémiah
07:13
created
Config/TypeWithOutputFieldsDefinition.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -132,10 +132,10 @@  discard block
 block discarded – undo
132 132
         $prototype
133 133
             // build args if argsBuilder exists
134 134
             ->beforeNormalization()
135
-                ->ifTrue(function ($field) {
135
+                ->ifTrue(function($field) {
136 136
                     return isset($field['argsBuilder']);
137 137
                 })
138
-                ->then(function ($field) {
138
+                ->then(function($field) {
139 139
                     $argsBuilderName = null;
140 140
 
141 141
                     if (is_string($field['argsBuilder'])) {
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
             ->end()
157 157
             // build field if builder exists
158 158
             ->beforeNormalization()
159
-                ->always(function ($field) {
159
+                ->always(function($field) {
160 160
                     $fieldBuilderName = null;
161 161
 
162 162
                     if (isset($field['builder']) && is_string($field['builder'])) {
@@ -197,10 +197,10 @@  discard block
 block discarded – undo
197 197
                     ->prototype('array')
198 198
                         // Allow arg type short syntax (Arg: Type => Arg: {type: Type})
199 199
                         ->beforeNormalization()
200
-                            ->ifTrue(function ($options) {
200
+                            ->ifTrue(function($options) {
201 201
                                 return is_string($options);
202 202
                             })
203
-                            ->then(function ($options) {
203
+                            ->then(function($options) {
204 204
                                 return ['type' => $options];
205 205
                             })
206 206
                         ->end()
Please login to merge, or discard this patch.
Relay/Connection/Paginator.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
         $entities = call_user_func($this->fetcher, $offset, $limit);
60 60
 
61
-        return $this->handleEntities($entities, function ($entities) use ($args, $offset, $total) {
61
+        return $this->handleEntities($entities, function($entities) use ($args, $offset, $total) {
62 62
             return ConnectionBuilder::connectionFromArraySlice($entities, $args, [
63 63
                 'sliceStart' => $offset,
64 64
                 'arrayLength' => $total,
@@ -81,13 +81,13 @@  discard block
 block discarded – undo
81 81
         if (!is_numeric(ConnectionBuilder::cursorToOffset($args['after'])) || !$args['after']) {
82 82
             $entities = call_user_func($this->fetcher, $offset, $limit + 1);
83 83
 
84
-            return $this->handleEntities($entities, function ($entities) use ($args) {
84
+            return $this->handleEntities($entities, function($entities) use ($args) {
85 85
                 return ConnectionBuilder::connectionFromArray($entities, $args);
86 86
             });
87 87
         } else {
88 88
             $entities = call_user_func($this->fetcher, $offset, $limit + 2);
89 89
 
90
-            return $this->handleEntities($entities, function ($entities) use ($args, $offset) {
90
+            return $this->handleEntities($entities, function($entities) use ($args, $offset) {
91 91
                 return ConnectionBuilder::connectionFromArraySlice($entities, $args, [
92 92
                     'sliceStart' => $offset,
93 93
                     'arrayLength' => $offset + count($entities),
Please login to merge, or discard this patch.
Tests/Relay/Connection/PaginatorTest.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 
56 56
     public function testForward()
57 57
     {
58
-        $paginator = new Paginator(function ($offset, $limit) {
58
+        $paginator = new Paginator(function($offset, $limit) {
59 59
             $this->assertSame(0, $offset);
60 60
             $this->assertSame(5, $limit); // Includes the extra element to check if next page is available
61 61
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 
72 72
     public function testForwardAfterInMiddle()
73 73
     {
74
-        $paginator = new Paginator(function ($offset, $limit) {
74
+        $paginator = new Paginator(function($offset, $limit) {
75 75
             $this->assertSame(2, $offset);
76 76
             $this->assertSame(3, $limit); // Includes the extra element to check if next page is available
77 77
 
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
     public function testForwardAfterAtTheEnd()
89 89
     {
90
-        $paginator = new Paginator(function ($offset, $limit) {
90
+        $paginator = new Paginator(function($offset, $limit) {
91 91
             $this->assertSame(2, $offset);
92 92
             $this->assertSame(4, $limit); // Includes the extra element to check if next page is available
93 93
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 
104 104
     public function testForwardAfterLast()
105 105
     {
106
-        $paginator = new Paginator(function ($offset, $limit) {
106
+        $paginator = new Paginator(function($offset, $limit) {
107 107
             $this->assertSame(4, $offset);
108 108
             $this->assertSame(7, $limit); // Includes the extra element to check if next page is available
109 109
 
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 
120 120
     public function testForwardAfterWithUnvalidCursorAndSlice()
121 121
     {
122
-        $paginator = new Paginator(function ($offset, $limit) {
122
+        $paginator = new Paginator(function($offset, $limit) {
123 123
             $this->assertSame(0, $offset);
124 124
             $this->assertSame(5, $limit); // Includes the extra element to check if next page is available
125 125
 
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 
137 137
     public function testBackward()
138 138
     {
139
-        $paginator = new Paginator(function ($offset, $limit) {
139
+        $paginator = new Paginator(function($offset, $limit) {
140 140
             $this->assertSame(2, $offset);
141 141
             $this->assertSame(3, $limit);
142 142
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 
154 154
     public function testBackwardWithLimitEqualsToTotal()
155 155
     {
156
-        $paginator = new Paginator(function ($offset, $limit) {
156
+        $paginator = new Paginator(function($offset, $limit) {
157 157
             $this->assertSame(0, $offset);
158 158
             $this->assertSame(5, $limit);
159 159
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 
171 171
     public function testBackwardBeforeLast()
172 172
     {
173
-        $paginator = new Paginator(function ($offset, $limit) {
173
+        $paginator = new Paginator(function($offset, $limit) {
174 174
             $this->assertSame(4, $limit);
175 175
 
176 176
             return $this->getData($offset);
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
     public function testBackwardPartialBeforeInMiddle()
187 187
     {
188
-        $paginator = new Paginator(function ($offset, $limit) {
188
+        $paginator = new Paginator(function($offset, $limit) {
189 189
             $this->assertSame(1, $offset);
190 190
             $this->assertSame(2, $limit);
191 191
 
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 
202 202
     public function testAutoBackward()
203 203
     {
204
-        $paginator = new Paginator(function ($offset, $limit) {
204
+        $paginator = new Paginator(function($offset, $limit) {
205 205
             $this->assertSame(1, $offset);
206 206
             $this->assertSame(4, $limit);
207 207
 
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
 
219 219
     public function testAutoForward()
220 220
     {
221
-        $paginator = new Paginator(function ($offset, $limit) {
221
+        $paginator = new Paginator(function($offset, $limit) {
222 222
             $this->assertSame(0, $offset);
223 223
             $this->assertSame(5, $limit); // Includes the extra element to check if next page is available
224 224
 
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
 
235 235
     public function testAutoBackwardWithCallable()
236 236
     {
237
-        $paginator = new Paginator(function ($offset, $limit) {
237
+        $paginator = new Paginator(function($offset, $limit) {
238 238
             $this->assertSame(1, $offset);
239 239
             $this->assertSame(4, $limit);
240 240
 
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
         });
243 243
 
244 244
         $countCalled = false;
245
-        $result = $paginator->auto(new Argument(['last' => 4]), function () use (&$countCalled) {
245
+        $result = $paginator->auto(new Argument(['last' => 4]), function() use (&$countCalled) {
246 246
             $countCalled = true;
247 247
 
248 248
             return 5;
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
 
266 266
         $this->assertSame(5, call_user_func_array($callable, ['array' => $this->data]));
267 267
 
268
-        $paginator = new Paginator(function ($offset, $limit) {
268
+        $paginator = new Paginator(function($offset, $limit) {
269 269
             $this->assertSame(1, $offset);
270 270
             $this->assertSame(4, $limit);
271 271
 
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
 
293 293
         $promise->expects($this->once())->method('then');
294 294
 
295
-        $paginator = new Paginator(function ($offset, $limit) use ($promise) {
295
+        $paginator = new Paginator(function($offset, $limit) use ($promise) {
296 296
             $this->assertSame(0, $offset);
297 297
             $this->assertSame(5, $limit);
298 298
 
Please login to merge, or discard this patch.
Resolver/AccessResolver.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
                 $result = $this->promiseAdapter->convertThenable($result);
54 54
             }
55 55
 
56
-            return $this->promiseAdapter->then($result, function ($result) use ($accessChecker, $resolveArgs) {
56
+            return $this->promiseAdapter->then($result, function($result) use ($accessChecker, $resolveArgs) {
57 57
                 return $this->processFilter($result, $accessChecker, $resolveArgs);
58 58
             });
59 59
         }
@@ -65,14 +65,14 @@  discard block
 block discarded – undo
65 65
     {
66 66
         if (is_array($result)) {
67 67
             $result = array_map(
68
-                function ($object) use ($accessChecker, $resolveArgs) {
68
+                function($object) use ($accessChecker, $resolveArgs) {
69 69
                     return $this->hasAccess($accessChecker, $object, $resolveArgs) ? $object : null;
70 70
                 },
71 71
                 $result
72 72
             );
73 73
         } elseif ($result instanceof Connection) {
74 74
             $result->edges = array_map(
75
-                function (Edge $edge) use ($accessChecker, $resolveArgs) {
75
+                function(Edge $edge) use ($accessChecker, $resolveArgs) {
76 76
                     $edge->node = $this->hasAccess($accessChecker, $edge->node, $resolveArgs) ? $edge->node : null;
77 77
 
78 78
                     return $edge;
Please login to merge, or discard this patch.
Executor/Promise/Adapter/ReactPromiseAdapter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,10 +59,10 @@
 block discarded – undo
59 59
         $reactPromise = $promise->adoptedPromise;
60 60
 
61 61
         while ($wait) {
62
-            $reactPromise->then(function ($values) use (&$resolvedValue, &$wait) {
62
+            $reactPromise->then(function($values) use (&$resolvedValue, &$wait) {
63 63
                 $resolvedValue = $values;
64 64
                 $wait = false;
65
-            }, function ($reason) use (&$exception, &$wait) {
65
+            }, function($reason) use (&$exception, &$wait) {
66 66
                 $exception = $reason;
67 67
                 $wait = false;
68 68
             });
Please login to merge, or discard this patch.
Tests/Functional/app/Resolver/ConnectionResolver.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -56,21 +56,21 @@  discard block
 block discarded – undo
56 56
 
57 57
     public function friendsResolver($user, $args)
58 58
     {
59
-        return $this->promiseAdapter->create(function (callable $resolve) use ($user, $args) {
59
+        return $this->promiseAdapter->create(function(callable $resolve) use ($user, $args) {
60 60
             return $resolve(ConnectionBuilder::connectionFromArray($user['friends'], $args));
61 61
         });
62 62
     }
63 63
 
64 64
     public function resolveNode(Edge $edge)
65 65
     {
66
-        return $this->promiseAdapter->create(function (callable $resolve) use ($edge) {
66
+        return $this->promiseAdapter->create(function(callable $resolve) use ($edge) {
67 67
             return $resolve(isset($this->allUsers[$edge->node]) ? $this->allUsers[$edge->node] : null);
68 68
         });
69 69
     }
70 70
 
71 71
     public function resolveConnection()
72 72
     {
73
-        return $this->promiseAdapter->create(function (callable $resolve) {
73
+        return $this->promiseAdapter->create(function(callable $resolve) {
74 74
             return $resolve(count($this->allUsers) - 1);
75 75
         });
76 76
     }
@@ -78,11 +78,11 @@  discard block
 block discarded – undo
78 78
     public function resolveQuery()
79 79
     {
80 80
         if ($this->promiseAdapter instanceof GraphQLPromiseAdapter) {
81
-            return new Deferred(function () {
81
+            return new Deferred(function() {
82 82
                 return $this->allUsers[0];
83 83
             });
84 84
         } elseif ($this->promiseAdapter instanceof ReactPromiseAdapter) {
85
-            return new Promise(function (callable $resolve) {
85
+            return new Promise(function(callable $resolve) {
86 86
                 return $resolve($this->allUsers[0]);
87 87
             });
88 88
         }
Please login to merge, or discard this patch.
ExpressionLanguage/ExpressionFunction.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
 {
18 18
     public function __construct($name, callable $compiler)
19 19
     {
20
-        parent::__construct($name, $compiler, function () {
20
+        parent::__construct($name, $compiler, function() {
21 21
             throw new \RuntimeException('No need evaluator.');
22 22
         });
23 23
     }
Please login to merge, or discard this patch.
ExpressionLanguage/AuthorizationExpressionProvider.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -20,14 +20,14 @@  discard block
 block discarded – undo
20 20
         return [
21 21
             new ExpressionFunction(
22 22
                 'hasRole',
23
-                function ($role) {
23
+                function($role) {
24 24
                     return sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s)', $role);
25 25
                 }
26 26
             ),
27 27
 
28 28
             new ExpressionFunction(
29 29
                 'hasAnyRole',
30
-                function ($roles) {
30
+                function($roles) {
31 31
                     $code = sprintf('array_reduce(%s, function ($isGranted, $role) use ($container) { return $isGranted || $container->get(\'security.authorization_checker\')->isGranted($role); }, false)', $roles);
32 32
 
33 33
                     return $code;
@@ -36,37 +36,37 @@  discard block
 block discarded – undo
36 36
 
37 37
             new ExpressionFunction(
38 38
                 'isAnonymous',
39
-                function () {
39
+                function() {
40 40
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_ANONYMOUSLY\')';
41 41
                 }
42 42
             ),
43 43
 
44 44
             new ExpressionFunction(
45 45
                 'isRememberMe',
46
-                function () {
46
+                function() {
47 47
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\')';
48 48
                 }
49 49
             ),
50 50
 
51 51
             new ExpressionFunction(
52 52
                 'isFullyAuthenticated',
53
-                function () {
53
+                function() {
54 54
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
55 55
                 },
56
-                function () {
56
+                function() {
57 57
                 }
58 58
             ),
59 59
 
60 60
             new ExpressionFunction(
61 61
                 'isAuthenticated',
62
-                function () {
62
+                function() {
63 63
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\') || $container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
64 64
                 }
65 65
             ),
66 66
 
67 67
             new ExpressionFunction(
68 68
                 'hasPermission',
69
-                function ($object, $permission) {
69
+                function($object, $permission) {
70 70
                     $code = sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s, %s)', $permission, $object);
71 71
 
72 72
                     return $code;
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 
76 76
             new ExpressionFunction(
77 77
                 'hasAnyPermission',
78
-                function ($object, $permissions) {
78
+                function($object, $permissions) {
79 79
                     $code = sprintf('array_reduce(%s, function ($isGranted, $permission) use ($container, $object) { return $isGranted || $container->get(\'security.authorization_checker\')->isGranted($permission, %s); }, false)', $permissions, $object);
80 80
 
81 81
                     return $code;
Please login to merge, or discard this patch.
ExpressionLanguage/ConfigExpressionProvider.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -21,35 +21,35 @@  discard block
 block discarded – undo
21 21
         return [
22 22
             new ExpressionFunction(
23 23
                 'service',
24
-                function ($value) {
24
+                function($value) {
25 25
                     return sprintf('$container->get(%s)', $value);
26 26
                 }
27 27
             ),
28 28
 
29 29
             new ExpressionFunction(
30 30
                 'parameter',
31
-                function ($value) {
31
+                function($value) {
32 32
                     return sprintf('$container->getParameter(%s)', $value);
33 33
                 }
34 34
             ),
35 35
 
36 36
             new ExpressionFunction(
37 37
                 'isTypeOf',
38
-                function ($className) {
38
+                function($className) {
39 39
                     return sprintf('($className = %s) && $value instanceof $className', $className);
40 40
                 }
41 41
             ),
42 42
 
43 43
             new ExpressionFunction(
44 44
                 'resolver',
45
-                function ($alias, $args = '[]') {
45
+                function($alias, $args = '[]') {
46 46
                     return sprintf('$container->get(\'overblog_graphql.resolver_resolver\')->resolve([%s, %s])', $alias, $args);
47 47
                 }
48 48
             ),
49 49
 
50 50
             new ExpressionFunction(
51 51
                 'mutateAndGetPayloadCallback',
52
-                function ($mutateAndGetPayload) {
52
+                function($mutateAndGetPayload) {
53 53
                     $code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
54 54
                     $code .= 'return '.$mutateAndGetPayload.'; }';
55 55
 
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 
60 60
             new ExpressionFunction(
61 61
                 'idFetcherCallback',
62
-                function ($idFetcher) {
62
+                function($idFetcher) {
63 63
                     $code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
64 64
                     $code .= 'return '.$idFetcher.'; }';
65 65
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
             new ExpressionFunction(
71 71
                 'resolveSingleInputCallback',
72
-                function ($resolveSingleInput) {
72
+                function($resolveSingleInput) {
73 73
                     $code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
74 74
                     $code .= 'return '.$resolveSingleInput.'; }';
75 75
 
@@ -79,14 +79,14 @@  discard block
 block discarded – undo
79 79
 
80 80
             new ExpressionFunction(
81 81
                 'mutation',
82
-                function ($alias, $args = '[]') {
82
+                function($alias, $args = '[]') {
83 83
                     return sprintf('$container->get(\'overblog_graphql.mutation_resolver\')->resolve([%s, %s])', $alias, $args);
84 84
                 }
85 85
             ),
86 86
 
87 87
             new ExpressionFunction(
88 88
                 'globalId',
89
-                function ($id, $typeName = null) {
89
+                function($id, $typeName = null) {
90 90
                     $typeNameEmpty = null === $typeName || '""' === $typeName || 'null' === $typeName || 'false' === $typeName;
91 91
 
92 92
                     return sprintf(
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 
100 100
             new ExpressionFunction(
101 101
                 'fromGlobalId',
102
-                function ($globalId) {
102
+                function($globalId) {
103 103
                     return sprintf(
104 104
                         '\\Overblog\\GraphQLBundle\\Relay\\Node\\GlobalId::fromGlobalId(%s)',
105 105
                         $globalId
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 
110 110
             new ExpressionFunction(
111 111
                 'newObject',
112
-                function ($className, $args = '[]') {
112
+                function($className, $args = '[]') {
113 113
                     return sprintf('(new \ReflectionClass(%s))->newInstanceArgs(%s)', $className, $args);
114 114
                 }
115 115
             ),
Please login to merge, or discard this patch.