CustomErrorFormatter::format() - Code Metrics - Inspection of "Enable error formatting customization" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#264)

by Jérémiah

created 2017-12-21 09:57 UTC

CustomErrorFormatter::format() A

↳ Parent: CustomErrorFormatter

Complexity

Conditions	3
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	12
rs	9.4285
cc	3
eloc	7
nc	2
nop	1

<?php

namespace Overblog\GraphQLBundle\Tests\Error;

use GraphQL\Error\Error;
use GraphQL\Error\FormattedError;

class CustomErrorFormatter
{
    /**
     * @param \Error|\Exception $e
     *
     * @return array
     */
    public static function format($e)
    {
        $code = $e->getCode();
        if ($e instanceof Error && $e->getPrevious()) {
            $code = $e->getPrevious()->getCode();
        }

        $formattedError = FormattedError::createFromException($e);

        $formattedError['code'] = $code;

        return $formattedError;
    }

    /**
     * @param \Error|\Exception $e
     *
     * @return array
     */
    public function __invoke($e)
    {
        return static::format($e);
    }
}


1			<?php
2
3			namespace Overblog\GraphQLBundle\Tests\Error;
4
5			use GraphQL\Error\Error;
6			use GraphQL\Error\FormattedError;
7
8			class CustomErrorFormatter
9			{
10			/**
11			* @param \Error\|\Exception $e
12			*
13			* @return array
14			*/
15			public static function format($e)
16			{
17			$code = $e->getCode();
18			if ($e instanceof Error && $e->getPrevious()) {
19			$code = $e->getPrevious()->getCode();
20			}
21
22			$formattedError = FormattedError::createFromException($e);
			0 ignored issues – show Bug introduced 2017-12-21 10:09 UTC by Report Bug Copy Issue Report It seems like `$e` defined by parameter `$e` on line 15 can also be of type `object<Exception>`; however, `GraphQL\Error\FormattedE...::createFromException()` does only seem to accept `object<Throwable>`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
23			$formattedError['code'] = $code;
24
25			return $formattedError;
26			}
27
28			/**
29			* @param \Error\|\Exception $e
30			*
31			* @return array
32			*/
33			public function __invoke($e)
34			{
35			return static::format($e);
36			}
37			}
38

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#264)

CustomErrorFormatter::format() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like