overblog / GraphQLBundle

src/Annotation/Mutation.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         ?string $type = null,
         ?string $resolve = null,
         ?string $complexity = null,
-        array|string|null $targetTypes = null
+        array | string | null $targetTypes = null
     ) {
         parent::__construct($name, $type, $resolve, $complexity);
         if ($targetTypes) {

src/Config/Parser/MetadataParser/MetadataParser.php

Spacing +2 added lines, -2 removed lines

@@ -346,7 +346,7 @@ 
 
         $buildersAnnotations = self::getMetadataMatching($metadatas, Metadata\FieldsBuilder::class);
         if (!empty($buildersAnnotations)) {
-            $typeConfiguration['builders'] = array_map(fn ($fieldsBuilderAnnotation) => ['builder' => $fieldsBuilderAnnotation->name, 'builderConfig' => $fieldsBuilderAnnotation->config], $buildersAnnotations);
+            $typeConfiguration['builders'] = array_map(fn($fieldsBuilderAnnotation) => ['builder' => $fieldsBuilderAnnotation->name, 'builderConfig' => $fieldsBuilderAnnotation->config], $buildersAnnotations);
         }
 
         if (isset($typeAnnotation->isTypeOf)) {
@@ -440,7 +440,7 @@ 
             $reflectionConstant = new ReflectionClassConstant($reflectionClass->getName(), $name);
             $valueConfig = self::getDescriptionConfiguration(static::getMetadatas($reflectionConstant), true);
 
-            $enumValueAnnotation = current(array_filter($enumValues, fn ($enumValueAnnotation) => $enumValueAnnotation->name === $name));
+            $enumValueAnnotation = current(array_filter($enumValues, fn($enumValueAnnotation) => $enumValueAnnotation->name === $name));
             $valueConfig['value'] = $value;
 
             if (false !== $enumValueAnnotation) {

src/Annotation/Query.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         ?string $type = null,
         ?string $resolve = null,
         ?string $complexity = null,
-        array|string|null $targetTypes = null
+        array | string | null $targetTypes = null
     ) {
         parent::__construct($name, $type, $resolve, $complexity);
         if ($targetTypes) {

tests/Functional/Controller/GraphControllerTest.php

Spacing -318 removed lines

@@ -14,321 +14,3 @@
 final class GraphControllerTest extends TestCase
 {
     private string $friendsQuery = <<<'EOF'
-        query FriendsQuery {
-          user {
-            friends(first: 2) {
-              totalCount
-              edges {
-                friendshipTime
-                node {
-                  name
-                }
-              }
-            }
-          }
-        }
-        EOF;
-
-    private string $friendsTotalCountQuery = <<<'EOF'
-        query FriendsTotalCountQuery {
-          user {
-            friends {
-              totalCount
-            }
-          }
-        }
-        EOF;
-
-    private array $expectedData = [
-        'user' => [
-            'friends' => [
-                'totalCount' => 4,
-                'edges' => [
-                    [
-                        'friendshipTime' => 'Yesterday',
-                        'node' => [
-                            'name' => 'Nick',
-                        ],
-                    ],
-                    [
-                        'friendshipTime' => 'Yesterday',
-                        'node' => [
-                            'name' => 'Lee',
-                        ],
-                    ],
-                ],
-            ],
-        ],
-    ];
-
-    /**
-     * @dataProvider graphQLEndpointUriProvider
-     */
-    public function testEndpointAction(string $uri): void
-    {
-        $client = static::createClient(['test_case' => 'connectionWithCORS']);
-        $this->disableCatchExceptions($client);
-
-        $client->request('GET', $uri, ['query' => $this->friendsQuery], [], ['CONTENT_TYPE' => 'application/graphql;charset=utf8', 'HTTP_Origin' => 'http://example.com']);
-        $result = $client->getResponse()->getContent();
-        $this->assertSame(['data' => $this->expectedData], json_decode($result, true), $result);
-        $this->assertCORSHeadersExists($client);
-    }
-
-    public function graphQLEndpointUriProvider(): array
-    {
-        return [
-            ['/'],
-            ['/graphql/default'],
-        ];
-    }
-
-    public function testEndpointWithEmptyQuery(): void
-    {
-        $this->expectException(BadRequestHttpException::class);
-        $this->expectExceptionMessage('Must provide query parameter');
-        $client = static::createClient();
-        $this->disableCatchExceptions($client);
-        $client->request('GET', '/', []);
-        $client->getResponse()->getContent();
-    }
-
-    public function testEndpointWithEmptyPostJsonBodyQuery(): void
-    {
-        $this->expectException(BadRequestHttpException::class);
-        $this->expectExceptionMessage('The request content body must not be empty when using json content type request.');
-        $client = static::createClient();
-        $this->disableCatchExceptions($client);
-        $client->request('POST', '/', [], [], ['CONTENT_TYPE' => 'application/json']);
-    }
-
-    public function testEndpointWithJsonContentTypeAndGetQuery(): void
-    {
-        $client = static::createClient(['test_case' => 'connectionWithCORS']);
-        $this->disableCatchExceptions($client);
-        $client->request('GET', '/', ['query' => $this->friendsQuery], [], ['CONTENT_TYPE' => 'application/json']);
-        $result = $client->getResponse()->getContent();
-        $this->assertSame(['data' => $this->expectedData], json_decode($result, true), $result);
-    }
-
-    public function testEndpointWithInvalidBodyQuery(): void
-    {
-        $this->expectException(BadRequestHttpException::class);
-        $this->expectExceptionMessage('POST body sent invalid JSON');
-        $client = static::createClient();
-        $this->disableCatchExceptions($client);
-        $client->request('GET', '/', [], [], ['CONTENT_TYPE' => 'application/json'], '{');
-        $client->getResponse()->getContent();
-    }
-
-    public function testEndpointActionWithVariables(): void
-    {
-        $client = static::createClient(['test_case' => 'connection']);
-        $this->disableCatchExceptions($client);
-
-        $query = <<<'EOF'
-            query FriendsQuery($firstFriends: Int) {
-              user {
-                friends(first: $firstFriends) {
-                  totalCount
-                  edges {
-                    friendshipTime
-                    node {
-                      name
-                    }
-                  }
-                }
-              }
-            }
-            EOF;
-
-        $content = json_encode(['query' => $query, 'variables' => '{"firstFriends": 2}']) ?: null;
-        $client->request('GET', '/', [], [], ['CONTENT_TYPE' => 'application/json'], $content);
-        $this->assertSame(200, $client->getResponse()->getStatusCode());
-    }
-
-    public function testEndpointActionWithInvalidVariables(): void
-    {
-        $this->expectException(BadRequestHttpException::class);
-        $this->expectExceptionMessage('Variables are invalid JSON');
-        $client = static::createClient(['test_case' => 'connection']);
-        $this->disableCatchExceptions($client);
-
-        $query = <<<'EOF'
-            query {
-              user
-            }
-            EOF;
-
-        $client->request('GET', '/', ['query' => $query, 'variables' => '"firstFriends": 2}']);
-    }
-
-    public function testMultipleEndpointActionWithUnknownSchemaName(): void
-    {
-        $this->expectException(NotFoundHttpException::class);
-        $this->expectExceptionMessage('Could not find "fake" schema.');
-        $client = static::createClient(['test_case' => 'connection']);
-        $this->disableCatchExceptions($client);
-
-        $query = <<<'EOF'
-            query {
-              user
-            }
-            EOF;
-
-        $client->request('GET', '/graphql/fake', ['query' => $query]);
-    }
-
-    public function testEndpointActionWithOperationName(): void
-    {
-        $client = static::createClient(['test_case' => 'connection']);
-        $this->disableCatchExceptions($client);
-
-        $query = $this->friendsQuery."\n".$this->friendsTotalCountQuery;
-
-        $client->request('POST', '/', ['query' => $query, 'operationName' => 'FriendsQuery'], [], ['CONTENT_TYPE' => 'application/x-www-form-urlencoded']);
-        $result = $client->getResponse()->getContent();
-        $this->assertSame(['data' => $this->expectedData], json_decode($result, true), $result);
-    }
-
-    /**
-     * @dataProvider graphQLBatchEndpointUriProvider
-     */
-    public function testBatchEndpointAction(string $uri): void
-    {
-        $client = static::createClient(['test_case' => 'connection']);
-        $this->disableCatchExceptions($client);
-
-        $data = [
-            [
-                'id' => 'friends',
-                'query' => $this->friendsQuery,
-            ],
-            [
-                'id' => 'friendsTotalCount',
-                'query' => $this->friendsTotalCountQuery,
-            ],
-        ];
-
-        $content = json_encode($data) ?: null;
-        $client->request('POST', $uri, [], [], ['CONTENT_TYPE' => 'application/json'], $content);
-        $result = $client->getResponse()->getContent();
-
-        $expected = [
-            ['id' => 'friends', 'payload' => ['data' => $this->expectedData]],
-            ['id' => 'friendsTotalCount', 'payload' => ['data' => ['user' => ['friends' => ['totalCount' => 4]]]]],
-        ];
-        $this->assertSame($expected, json_decode($result, true), $result);
-    }
-
-    public function graphQLBatchEndpointUriProvider(): array
-    {
-        return [
-            ['/batch'],
-            ['/graphql/default/batch'],
-        ];
-    }
-
-    public function testBatchEndpointWithEmptyQuery(): void
-    {
-        $this->expectException(BadRequestHttpException::class);
-        $this->expectExceptionMessage('Must provide at least one valid query.');
-        $client = static::createClient();
-        $this->disableCatchExceptions($client);
-        $client->request('GET', '/batch', [], [], ['CONTENT_TYPE' => 'application/json'], '{}');
-        $client->getResponse()->getContent();
-    }
-
-    public function testBatchEndpointWrongContentType(): void
-    {
-        $this->expectException(BadRequestHttpException::class);
-        $this->expectExceptionMessage('Batching parser only accepts "application/json" or "multipart/form-data" content-type but got "".');
-        $client = static::createClient();
-        $this->disableCatchExceptions($client);
-        $client->request('GET', '/batch');
-        $client->getResponse()->getContent();
-    }
-
-    public function testBatchEndpointWithInvalidJson(): void
-    {
-        $this->expectException(BadRequestHttpException::class);
-        $this->expectExceptionMessage('POST body sent invalid JSON');
-        $client = static::createClient();
-        $this->disableCatchExceptions($client);
-        $client->request('GET', '/batch', [], [], ['CONTENT_TYPE' => 'application/json'], '{');
-        $client->getResponse()->getContent();
-    }
-
-    public function testBatchEndpointWithInvalidQuery(): void
-    {
-        $this->expectException(BadRequestHttpException::class);
-        $this->expectExceptionMessage('1 is not a valid query');
-        $client = static::createClient();
-        $this->disableCatchExceptions($client);
-        $client->request('GET', '/batch', [], [], ['CONTENT_TYPE' => 'application/json'], '{"test" : {"query": 1}}');
-        $client->getResponse()->getContent();
-    }
-
-    public function testPreflightedRequestWhenDisabled(): void
-    {
-        $client = static::createClient(['test_case' => 'connection']);
-        $this->disableCatchExceptions($client);
-        $client->request('OPTIONS', '/', [], [], ['HTTP_Origin' => 'http://example.com']);
-        $response = $client->getResponse();
-        $this->assertSame(200, $response->getStatusCode());
-        $this->assertCORSHeadersNotExists($client);
-    }
-
-    public function testUnAuthorizedMethod(): void
-    {
-        $client = static::createClient(['test_case' => 'connection']);
-        $this->disableCatchExceptions($client);
-        $client->request('PUT', '/', [], [], ['HTTP_Origin' => 'http://example.com']);
-        $this->assertSame(405, $client->getResponse()->getStatusCode());
-    }
-
-    public function testPreflightedRequestWhenEnabled(): void
-    {
-        $client = static::createClient(['test_case' => 'connectionWithCORS']);
-        $this->disableCatchExceptions($client);
-        $client->request('OPTIONS', '/batch', [], [], ['HTTP_Origin' => 'http://example.com']);
-        $this->assertCORSHeadersExists($client);
-    }
-
-    public function testNoCORSHeadersIfOriginHeaderNotExists(): void
-    {
-        $client = static::createClient(['test_case' => 'connectionWithCORS']);
-        $this->disableCatchExceptions($client);
-        $client->request('GET', '/', ['query' => $this->friendsQuery], [], ['CONTENT_TYPE' => 'application/graphql']);
-        $result = $client->getResponse()->getContent();
-        $this->assertSame(['data' => $this->expectedData], json_decode($result, true), $result);
-        $this->assertCORSHeadersNotExists($client);
-    }
-
-    /**
-     * @param KernelBrowser $client
-     */
-    private function assertCORSHeadersNotExists($client): void
-    {
-        $headers = $client->getResponse()->headers->all();
-        $this->assertArrayNotHasKey('access-control-allow-origin', $headers);
-        $this->assertArrayNotHasKey('access-control-allow-methods', $headers);
-        $this->assertArrayNotHasKey('access-control-allow-credentials', $headers);
-        $this->assertArrayNotHasKey('access-control-allow-headers', $headers);
-        $this->assertArrayNotHasKey('access-control-max-age', $headers);
-    }
-
-    /**
-     * @param KernelBrowser $client
-     */
-    private function assertCORSHeadersExists($client): void
-    {
-        $response = $client->getResponse();
-        $this->assertSame(200, $response->getStatusCode());
-        $this->assertSame('http://example.com', $response->headers->get('Access-Control-Allow-Origin'));
-        $this->assertSame('OPTIONS, GET, POST', $response->headers->get('Access-Control-Allow-Methods'));
-        $this->assertSame('true', $response->headers->get('Access-Control-Allow-Credentials'));
-        $this->assertSame('Content-Type, Authorization', $response->headers->get('Access-Control-Allow-Headers'));
-        $this->assertSame('3600', $response->headers->get('Access-Control-Max-Age'));
-    }
-}

tests/Functional/Security/QueryComplexityTest.php

Spacing -70 removed lines

@@ -9,73 +9,3 @@
 final class QueryComplexityTest extends TestCase
 {
     private string $userFriendsWithoutLimitQuery = <<<'EOF'
-        query {
-          user {
-            friends {
-              edges {
-                node {
-                  name
-                }
-              }
-            }
-          }
-        }
-        EOF;
-
-    private string $userFriendsWithLimitQuery = <<<'EOF'
-        query {
-          user {
-            friends(first: 1) {
-              edges {
-                node {
-                  name
-                }
-              }
-            }
-          }
-        }
-        EOF;
-
-    public function testComplexityReachLimitation(): void
-    {
-        $expected = [
-            'errors' => [
-                [
-                    'message' => 'Max query complexity should be 10 but got 54.',
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->userFriendsWithoutLimitQuery, $expected, self::ANONYMOUS_USER, 'queryComplexity');
-    }
-
-    public function testComplexityReachLimitationEnv(): void
-    {
-        $expected = [
-            'errors' => [
-                [
-                    'message' => 'Max query complexity should be 10 but got 54.',
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->userFriendsWithoutLimitQuery, $expected, self::ANONYMOUS_USER, 'queryComplexityEnv');
-    }
-
-    public function testComplexityUnderLimitation(): void
-    {
-        $expected = [
-            'data' => [
-                'user' => [
-                    'friends' => [
-                        'edges' => [
-                            ['node' => ['name' => 'Nick']],
-                        ],
-                    ],
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->userFriendsWithLimitQuery, $expected, self::ANONYMOUS_USER, 'queryComplexity');
-    }
-}

tests/Functional/Security/QueryMaxDepthTest.php

Spacing -77 removed lines

@@ -9,80 +9,3 @@
 final class QueryMaxDepthTest extends TestCase
 {
     private string $userFriendsWithoutViolationQuery = <<<'EOF'
-        query {
-          user {
-            friends(first:1) {
-              edges {
-                node {
-                  name
-                }
-              }
-            }
-          }
-        }
-        EOF;
-
-    private string $userFriendsWithViolationQuery = <<<'EOF'
-        query {
-          user {
-            friends(first: 1) {
-              edges {
-                node {
-                  name
-                  friends {
-                    edges {
-                      node {
-                        name
-                      }
-                    }
-                  }
-                }
-              }
-            }
-          }
-        }
-        EOF;
-
-    public function testMaxDepthReachLimitation(): void
-    {
-        $expected = [
-            'errors' => [
-                [
-                    'message' => 'Max query depth should be 3 but got 6.',
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->userFriendsWithViolationQuery, $expected, self::ANONYMOUS_USER, 'queryMaxDepth');
-    }
-
-    public function testMaxDepthReachLimitationEnv(): void
-    {
-        $expected = [
-            'errors' => [
-                [
-                    'message' => 'Max query depth should be 3 but got 6.',
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->userFriendsWithViolationQuery, $expected, self::ANONYMOUS_USER, 'queryMaxDepthEnv');
-    }
-
-    public function testComplexityUnderLimitation(): void
-    {
-        $expected = [
-            'data' => [
-                'user' => [
-                    'friends' => [
-                        'edges' => [
-                            ['node' => ['name' => 'Nick']],
-                        ],
-                    ],
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->userFriendsWithoutViolationQuery, $expected, self::ANONYMOUS_USER, 'queryMaxDepth');
-    }
-}

tests/Functional/Security/DisableIntrospectionTest.php

Spacing -29 removed lines

@@ -9,32 +9,3 @@
 final class DisableIntrospectionTest extends TestCase
 {
     private string $introspectionQuery = <<<'EOF'
-        query {
-          __schema {
-            types {
-              name
-              description
-            }
-          }
-        }
-        EOF;
-
-    public function testIntrospectionDisabled(): void
-    {
-        $expected = [
-            'errors' => [
-                [
-                    'message' => 'GraphQL introspection is not allowed, but the query contained __schema or __type',
-                    'locations' => [
-                        [
-                            'line' => 2,
-                            'column' => 3,
-                        ],
-                    ],
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->introspectionQuery, $expected, self::ANONYMOUS_USER, 'disableIntrospection');
-    }
-}

src/Validator/ValidationNode.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
     private ?ResolverArgs $__resolverArgs;
 
     public function __construct(
-        ObjectType|InputObjectType $type,
+        ObjectType | InputObjectType $type,
         string $field = null,
         ?ValidationNode $parent = null,
         ?ResolverArgs $resolverArgs = null

src/Validator/InputValidator.php

Spacing +4 added lines, -4 removed lines

@@ -62,7 +62,7 @@ 
     /**
      * @throws ArgumentsValidationException
      */
-    public function validate(string|array|null $groups = null, bool $throw = true): ?ConstraintViolationListInterface
+    public function validate(string | array | null $groups = null, bool $throw = true): ?ConstraintViolationListInterface
     {
         $rootNode = new ValidationNode(
             $this->info->parentType,
@@ -206,7 +206,7 @@ 
         return $rootObject;
     }
 
-    private static function isListOfType(GeneratedTypeInterface|ListOfType|NonNull $type): bool
+    private static function isListOfType(GeneratedTypeInterface | ListOfType | NonNull $type): bool
     {
         if ($type instanceof ListOfType || ($type instanceof NonNull && $type->getWrappedType() instanceof ListOfType)) {
             return true;
@@ -215,7 +215,7 @@ 
         return false;
     }
 
-    private function createCollectionNode(array $values, ObjectType|InputObjectType $type, ValidationNode $parent): array
+    private function createCollectionNode(array $values, ObjectType | InputObjectType $type, ValidationNode $parent): array
     {
         $collection = [];
 
@@ -226,7 +226,7 @@ 
         return $collection;
     }
 
-    private function createObjectNode(array $value, ObjectType|InputObjectType $type, ValidationNode $parent): ValidationNode
+    private function createObjectNode(array $value, ObjectType | InputObjectType $type, ValidationNode $parent): ValidationNode
     {
         /** @phpstan-ignore-next-line */
         $classValidation = static::normalizeConfig($type->config['validation'] ?? []);