OverblogGraphQLTypesExtensionTest::testCustomBuilders() - Code Metrics - Inspection of "Optimized types mapping configuration" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#40)

by Jérémiah

created 2016-05-16 11:11 UTC

testCustomBuilders() B

↳ Parent: OverblogGraphQLTypesExtensionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	109
Code Lines	64

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	109
rs	8.2857
cc	1
eloc	64
nc	1
nop	0

How to fix Long Method

<?php

/*
 * This file is part of the OverblogGraphQLBundle package.
 *
 * (c) Overblog <http://github.com/overblog/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Overblog\GraphQLBundle\Tests\DependencyInjection;

use Overblog\GraphQLBundle\DependencyInjection\OverblogGraphQLExtension;
use Overblog\GraphQLBundle\DependencyInjection\OverblogGraphQLTypesExtension;
use Symfony\Component\DependencyInjection\ContainerBuilder;

class OverblogGraphQLTypesExtensionTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var ContainerBuilder
     */
    private $container;
    /**
     * @var OverblogGraphQLTypesExtension
     */
    private $extension;

    public function setUp()
    {
        $this->container = new ContainerBuilder();
        $this->container->setParameter('kernel.bundles', []);
        $this->container->setParameter('kernel.debug', false);
        $this->extension = new OverblogGraphQLTypesExtension();
    }

    public function tearDown()
    {
        unset($this->container, $this->extension);
    }

    /**
     * @expectedException \Symfony\Component\Config\Definition\Exception\ForbiddenOverwriteException
     */
    public function testDuplicatedType()
    {
        $type = ['foo' => []];
        $configs = [$type, $type];
        $this->extension->load($configs, $this->container);
    }

    /**
     * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
     * @expectedExceptionMessageRegExp #The file "(.*)/broken.types.yml" does not contain valid YAML\.#
     */
    public function testBrokenYmlOnPrepend()
    {
        $this->extension->containerPrependExtensionConfig($this->getBrokenMappingConfig('yml'), $this->container);
    }

    /**
     * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
     * @expectedExceptionMessageRegExp #Unable to parse file "(.*)/broken.types.xml"\.#
     */
    public function testBrokenXmlOnPrepend()
    {
        $this->extension->containerPrependExtensionConfig($this->getBrokenMappingConfig('xml'), $this->container);
    }

    /**
     * @param $internalConfigKey
     * @dataProvider internalConfigKeys
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage Don't use internal config keys _object_config, _enum_config, _interface_config, _union_config, _input_object_config, replace it by "config" instead.
     */
    public function testInternalConfigKeysShouldNotBeUsed($internalConfigKey)
    {
        $configs = [
            ['bar' => [$internalConfigKey => []]],
        ];

        $this->extension->load($configs, $this->container);
    }

    public function testCustomBuilders()
    {
        $ext = new OverblogGraphQLExtension();
        $ext->load(
            [
                [
                    'definitions' => [
                        'builders' => [
                            'field' => [
                                [
                                    'alias' => 'RawId',
                                    'class' => 'Overblog\\GraphQLBundle\\Tests\\DependencyInjection\\Builder\\RawIdField',
                                ],
                            ],
                            'args' => [
                                [
                                    'alias' => 'Pager',
                                    'class' => 'Overblog\\GraphQLBundle\\Tests\\DependencyInjection\\Builder\\PagerArgs',
                                ],
                            ],
                        ],
                    ],
                ],
            ],
            $this->container
        );

        $this->extension->load(
            [
                [
                    'foo' => [
                        'type' => 'object',
                        'config' => [
                            'fields' => [
                                'rawIDWithDescriptionOverride' => [
                                    'builder' => 'RawId',
                                    'description' => 'rawIDWithDescriptionOverride description',
                                ],
                                'rawID' => 'RawId',
                                'rawIDs' => [
                                    'type' => '[RawID!]!',
                                    'argsBuilder' => 'Pager',
                                ],
                                'categories' => [
                                    'type' => '[String!]!',
                                    'argsBuilder' => ['builder' => 'Pager'],
                                ],
                            ],
                        ],
                    ],
                ],
            ],
            $this->container
        );

        $this->assertEquals(
            [
                'foo' => [
                    'type' => 'object',
                    'config' => [
                        'name' => 'foo',
                        'fields' => [
                            'rawIDWithDescriptionOverride' => [
                                'description' => 'rawIDWithDescriptionOverride description',
                                'type' => 'Int!',
                                'resolve' => '@=value.id',
                                'args' => [],
                            ],
                            'rawID' => [
                                'description' => 'The raw ID of an object',
                                'type' => 'Int!',
                                'resolve' => '@=value.id',
                                'args' => [],
                            ],
                            'rawIDs' => [
                                'type' => '[RawID!]!',
                                'args' => [
                                    'limit' => [
                                        'type' => 'Int!',
                                        'defaultValue' => 20,
                                    ],
                                    'offset' => [
                                        'type' => 'Int!',
                                        'defaultValue' => 0,
                                    ],
                                ],
                            ],
                            'categories' => [
                                'type' => '[String!]!',
                                'args' => [
                                    'limit' => [
                                        'type' => 'Int!',
                                        'defaultValue' => 20,
                                    ],
                                    'offset' => [
                                        'type' => 'Int!',
                                        'defaultValue' => 0,
                                    ],
                                ],
                            ],
                        ],
                        'interfaces' => [],
                    ],
                ],

            ],
            $this->container->getParameter('overblog_graphql_types.config')
        );
    }

    public function internalConfigKeys()
    {
        return [
            ['_object_config'],
            ['_enum_config'],
            ['_interface_config'],
            ['_union_config'],
            ['_input_object_config'],
        ];
    }

    private function getBrokenMappingConfig($type)
    {
        $config = [
            'definitions' => [
                'mappings' => [
                    'types' => [
                        [
                            'type' => $type,
                            'dir' => __DIR__.'/mapping/'.$type,
                        ],
                    ],
                ],
            ],
        ];

        return $config;
    }
}


1			<?php
2
3			/*
4			* This file is part of the OverblogGraphQLBundle package.
5			*
6			* (c) Overblog <http://github.com/overblog/>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Overblog\GraphQLBundle\Tests\DependencyInjection;
13
14			use Overblog\GraphQLBundle\DependencyInjection\OverblogGraphQLExtension;
15			use Overblog\GraphQLBundle\DependencyInjection\OverblogGraphQLTypesExtension;
16			use Symfony\Component\DependencyInjection\ContainerBuilder;
17
18			class OverblogGraphQLTypesExtensionTest extends \PHPUnit_Framework_TestCase
19			{
20			/**
21			* @var ContainerBuilder
22			*/
23			private $container;
24			/**
25			* @var OverblogGraphQLTypesExtension
26			*/
27			private $extension;
28
29			public function setUp()
30			{
31			$this->container = new ContainerBuilder();
32			$this->container->setParameter('kernel.bundles', []);
33			$this->container->setParameter('kernel.debug', false);
34			$this->extension = new OverblogGraphQLTypesExtension();
35			}
36
37			public function tearDown()
38			{
39			unset($this->container, $this->extension);
40			}
41
42			/**
43			* @expectedException \Symfony\Component\Config\Definition\Exception\ForbiddenOverwriteException
44			*/
45			public function testDuplicatedType()
46			{
47			$type = ['foo' => []];
48			$configs = [$type, $type];
49			$this->extension->load($configs, $this->container);
50			}
51
52			/**
53			* @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
54			* @expectedExceptionMessageRegExp #The file "(.*)/broken.types.yml" does not contain valid YAML\.#
55			*/
56			public function testBrokenYmlOnPrepend()
57			{
58			$this->extension->containerPrependExtensionConfig($this->getBrokenMappingConfig('yml'), $this->container);
59			}
60
61			/**
62			* @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
63			* @expectedExceptionMessageRegExp #Unable to parse file "(.*)/broken.types.xml"\.#
64			*/
65			public function testBrokenXmlOnPrepend()
66			{
67			$this->extension->containerPrependExtensionConfig($this->getBrokenMappingConfig('xml'), $this->container);
68			}
69
70			/**
71			* @param $internalConfigKey
72			* @dataProvider internalConfigKeys
73			* @expectedException \InvalidArgumentException
74			* @expectedExceptionMessage Don't use internal config keys _object_config, _enum_config, _interface_config, _union_config, _input_object_config, replace it by "config" instead.
75			*/
76			public function testInternalConfigKeysShouldNotBeUsed($internalConfigKey)
77			{
78			$configs = [
79			['bar' => [$internalConfigKey => []]],
80			];
81
82			$this->extension->load($configs, $this->container);
83			}
84
85			public function testCustomBuilders()
86			{
87			$ext = new OverblogGraphQLExtension();
88			$ext->load(
89			[
90			[
91			'definitions' => [
92			'builders' => [
93			'field' => [
94			[
95			'alias' => 'RawId',
96			'class' => 'Overblog\\GraphQLBundle\\Tests\\DependencyInjection\\Builder\\RawIdField',
97			],
98			],
99			'args' => [
100			[
101			'alias' => 'Pager',
102			'class' => 'Overblog\\GraphQLBundle\\Tests\\DependencyInjection\\Builder\\PagerArgs',
103			],
104			],
105			],
106			],
107			],
108			],
109			$this->container
110			);
111
112			$this->extension->load(
113			[
114			[
115			'foo' => [
116			'type' => 'object',
117			'config' => [
118			'fields' => [
119			'rawIDWithDescriptionOverride' => [
120			'builder' => 'RawId',
121			'description' => 'rawIDWithDescriptionOverride description',
122			],
123			'rawID' => 'RawId',
124			'rawIDs' => [
125			'type' => '[RawID!]!',
126			'argsBuilder' => 'Pager',
127			],
128			'categories' => [
129			'type' => '[String!]!',
130			'argsBuilder' => ['builder' => 'Pager'],
131			],
132			],
133			],
134			],
135			],
136			],
137			$this->container
138			);
139
140			$this->assertEquals(
141			[
142			'foo' => [
143			'type' => 'object',
144			'config' => [
145			'name' => 'foo',
146			'fields' => [
147			'rawIDWithDescriptionOverride' => [
148			'description' => 'rawIDWithDescriptionOverride description',
149			'type' => 'Int!',
150			'resolve' => '@=value.id',
151			'args' => [],
152			],
153			'rawID' => [
154			'description' => 'The raw ID of an object',
155			'type' => 'Int!',
156			'resolve' => '@=value.id',
157			'args' => [],
158			],
159			'rawIDs' => [
160			'type' => '[RawID!]!',
161			'args' => [
162			'limit' => [
163			'type' => 'Int!',
164			'defaultValue' => 20,
165			],
166			'offset' => [
167			'type' => 'Int!',
168			'defaultValue' => 0,
169			],
170			],
171			],
172			'categories' => [
173			'type' => '[String!]!',
174			'args' => [
175			'limit' => [
176			'type' => 'Int!',
177			'defaultValue' => 20,
178			],
179			'offset' => [
180			'type' => 'Int!',
181			'defaultValue' => 0,
182			],
183			],
184			],
185			],
186			'interfaces' => [],
187			],
188			],
189
190			],
191			$this->container->getParameter('overblog_graphql_types.config')
192			);
193			}
194
195			public function internalConfigKeys()
196			{
197			return [
198			['_object_config'],
199			['_enum_config'],
200			['_interface_config'],
201			['_union_config'],
202			['_input_object_config'],
203			];
204			}
205
206			private function getBrokenMappingConfig($type)
207			{
208			$config = [
209			'definitions' => [
210			'mappings' => [
211			'types' => [
212			[
213			'type' => $type,
214			'dir' => __DIR__.'/mapping/'.$type,
215			],
216			],
217			],
218			],
219			];
220
221			return $config;
222			}
223			}
224

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#40)

testCustomBuilders() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like