ExpressionFunctionProvider::addFunction() - Code Metrics - Inspection of "Improve expression language customization" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#265)

by Jérémiah

created 2018-01-03 18:59 UTC

ExpressionFunctionProvider::addFunction() A

↳ Parent: ExpressionFunctionProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

namespace Overblog\GraphQLBundle\ExpressionLanguage;

use Symfony\Component\ExpressionLanguage\ExpressionFunction;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Symfony\Component\ExpressionLanguage\ExpressionFunctionProviderInterface;

final class ExpressionFunctionProvider implements ExpressionFunctionProviderInterface
{
    /**
     * @var ExpressionFunction[]
     */
    private $functions = [];

    public function addFunction(ExpressionFunction $function)
    {
        $this->functions[] = $function;
    }

    /**
     * {@inheritdoc}
     */
    public function getFunctions()
    {
        return $this->functions;
    }
}


1			<?php
2
3			namespace Overblog\GraphQLBundle\ExpressionLanguage;
4
5			use Symfony\Component\ExpressionLanguage\ExpressionFunction;
			0 ignored issues – show Bug introduced 2018-01-03 18:53 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Overblog\GraphQLBundle\E...uage\ExpressionFunction`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
6			use Symfony\Component\ExpressionLanguage\ExpressionFunctionProviderInterface;
7
8			final class ExpressionFunctionProvider implements ExpressionFunctionProviderInterface
9			{
10			/**
11			* @var ExpressionFunction[]
12			*/
13			private $functions = [];
14
15			public function addFunction(ExpressionFunction $function)
16			{
17			$this->functions[] = $function;
18			}
19
20			/**
21			* {@inheritdoc}
22			*/
23			public function getFunctions()
24			{
25			return $this->functions;
26			}
27			}
28

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#265)

ExpressionFunctionProvider::addFunction() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like