DIContainerMockTrait - Code Metrics - Inspection of "Merge branch 'expression_language_and_controllers_..." - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8f549c...6f6f6a )

by Jérémiah

created 2016-03-09 09:19 UTC

DIContainerMockTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	3
c	2
b	0
f	1
lcom	0
cbo	0
dl	0
loc	27
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
B	getDIContainerMock()	0	24	3

<?php

/*
 * This file is part of the OverblogGraphQLBundle package.
 *
 * (c) Overblog <http://github.com/overblog/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Overblog\GraphQLBundle\Tests;

trait DIContainerMockTrait
{
    private function getDIContainerMock(array $services = [], array $parameters = [])
    {
        $container = $this->getMock('Symfony\\Component\\DependencyInjection\\Container', ['get', 'getParameter', 'has']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $getMethod = $container->expects($this->any())->method('get');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        foreach ($services as $id => $service) {
            $getMethod
                ->with($id)
                ->willReturn($service)
            ;
        }

        $getParameterMethod = $container->expects($this->any())->method('getParameter');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        foreach ($parameters as $id => $parameter) {
            $getParameterMethod
                ->with($id)
                ->willReturn($parameter)
            ;
        }

        return $container;
    }
}


1			<?php
2
3			/*
4			* This file is part of the OverblogGraphQLBundle package.
5			*
6			* (c) Overblog <http://github.com/overblog/>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Overblog\GraphQLBundle\Tests;
13
14			trait DIContainerMockTrait
15			{
16			private function getDIContainerMock(array $services = [], array $parameters = [])
17			{
18			$container = $this->getMock('Symfony\\Component\\DependencyInjection\\Container', ['get', 'getParameter', 'has']);
			0 ignored issues – show Bug introduced 2016-03-09 09:30 UTC by Report Bug Copy Issue Report It seems like `getMock()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19
20			$getMethod = $container->expects($this->any())->method('get');
			0 ignored issues – show Bug introduced 2016-03-09 09:30 UTC by Report Bug Copy Issue Report It seems like `any()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21
22			foreach ($services as $id => $service) {
23			$getMethod
24			->with($id)
25			->willReturn($service)
26			;
27			}
28
29			$getParameterMethod = $container->expects($this->any())->method('getParameter');
			0 ignored issues – show Bug introduced 2016-03-09 09:30 UTC by Report Bug Copy Issue Report It seems like `any()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30
31			foreach ($parameters as $id => $parameter) {
32			$getParameterMethod
33			->with($id)
34			->willReturn($parameter)
35			;
36			}
37
38			return $container;
39			}
40			}
41

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Push — master ( 8f549c...6f6f6a )

DIContainerMockTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like