Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#325)
by Jérémiah
13:59
created

ResolverMaps   A

Complexity

Total Complexity 13

Size/Duplication

Total Lines 65
Duplicated Lines 18.46 %

Coupling/Cohesion

Components 1
Dependencies 2

Test Coverage

Coverage 71.43%

Importance

Changes 0
Metric Value
wmc 13
c 0
b 0
f 0
lcom 1
cbo 2
dl 12
loc 65
ccs 20
cts 28
cp 0.7143
rs 10

5 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 5 1
A checkResolverMaps() 12 12 4
A resolve() 0 9 3
A isResolvable() 0 10 3
A covered() 0 10 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Overblog\GraphQLBundle\Resolver;
4
5
final class ResolverMaps implements ResolverMapInterface
6
{
7
    /** @var ResolverMapInterface[] */
8
    private $resolverMaps;
9
10 41
    public function __construct(array $resolverMaps)
11
    {
12 41
        self::checkResolverMaps($resolverMaps);
13 36
        $this->resolverMaps = $resolverMaps;
14 36
    }
15
16
    /**
17
     * {@inheritdoc}
18
     */
19 1
    public function resolve($typeName, $fieldName)
20
    {
21 1
        foreach ($this->resolverMaps as $resolverMap) {
22
            if ($resolverMap->isResolvable($typeName, $fieldName)) {
23
                return $resolverMap->resolve($typeName, $fieldName);
24
            }
25
        }
26 1
        throw new UnresolvableException(sprintf('Field "%s.%s" could not be resolved.', $typeName, $fieldName));
27
    }
28
29
    /**
30
     * {@inheritdoc}
31
     */
32
    public function isResolvable($typeName, $fieldName)
33
    {
34
        foreach ($this->resolverMaps as $resolverMap) {
35
            if ($resolverMap->isResolvable($typeName, $fieldName)) {
36
                return true;
37
            }
38
        }
39
40
        return false;
41
    }
42
43
    /**
44
     * {@inheritdoc}
45
     */
46 34
    public function covered($typeName = null)
47
    {
48 34
        $covered = [];
49 34
        foreach ($this->resolverMaps as $resolverMap) {
50
            $covered = array_merge($covered, $resolverMap->covered($typeName));
51
        }
52 34
        $covered = array_unique($covered);
53
54 34
        return $covered;
55
    }
56
57 41 View Code Duplication
    private static function checkResolverMaps(array $resolverMaps)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
58
    {
59 41
        foreach ($resolverMaps as $resolverMap) {
60 5
            if (!$resolverMap instanceof ResolverMapInterface) {
61 5
                throw new \InvalidArgumentException(sprintf(
62 5
                    'ResolverMap should be instance of "%s" but got "%s".',
63 5
                    ResolverMapInterface::class,
64 5
                    is_object($resolverMap) ? get_class($resolverMap) : gettype($resolverMap)
65
                ));
66
            }
67
        }
68 36
    }
69
}
70