Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#100)
by Pascal
22:38
created
Tests/DIContainerMockTrait.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -13,6 +13,9 @@
 block discarded – undo
13 13
 
14 14
 trait DIContainerMockTrait
15 15
 {
16
+    /**
17
+     * @return null|\Symfony\Component\DependencyInjection\ContainerInterface
18
+     */
16 19
     private function getDIContainerMock(array $services = [], array $parameters = [])
17 20
     {
18 21
         $container = $this->getMock('Symfony\\Component\\DependencyInjection\\Container', ['get', 'getParameter', 'has']);
Please login to merge, or discard this patch.
Tests/Functional/Controller/GraphControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@
 block discarded – undo
165 165
         $client->request('POST', '/?batch', [], [], ['CONTENT_TYPE' => 'application/json'], json_encode($data));
166 166
         $result = $client->getResponse()->getContent();
167 167
 
168
-        $expected  = [
168
+        $expected = [
169 169
             'friends' => ['data' => $this->expectedData],
170 170
             'friendsTotalCount' => ['data' => ['user' => ['friends' => ['totalCount' => 4]]]],
171 171
         ];
Please login to merge, or discard this patch.
Config/TypeWithOutputFieldsDefinition.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -51,6 +51,9 @@  discard block
 block discarded – undo
51 51
         self::$fieldBuilderClassMap[$name] = $fieldBuilderClass;
52 52
     }
53 53
 
54
+    /**
55
+     * @param string $type
56
+     */
54 57
     protected static function checkBuilderClass($builderClass, $type)
55 58
     {
56 59
         $interface = 'Overblog\\GraphQLBundle\\Definition\\Builder\\MappingInterface';
@@ -113,6 +116,9 @@  discard block
 block discarded – undo
113 116
         }
114 117
     }
115 118
 
119
+    /**
120
+     * @param string $name
121
+     */
116 122
     protected function outputFieldsSelection($name, $withAccess = false)
117 123
     {
118 124
         $builder = new TreeBuilder();
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -132,10 +132,10 @@  discard block
 block discarded – undo
132 132
         $prototype
133 133
             // build args if argsBuilder exists
134 134
             ->beforeNormalization()
135
-                ->ifTrue(function ($field) {
135
+                ->ifTrue(function($field) {
136 136
                     return isset($field['argsBuilder']);
137 137
                 })
138
-                ->then(function ($field) {
138
+                ->then(function($field) {
139 139
                     $argsBuilderName = null;
140 140
 
141 141
                     if (is_string($field['argsBuilder'])) {
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
             ->end()
157 157
             // build field if builder exists
158 158
             ->beforeNormalization()
159
-                ->always(function ($field) {
159
+                ->always(function($field) {
160 160
                     $fieldBuilderName = null;
161 161
 
162 162
                     if (isset($field['builder']) && is_string($field['builder'])) {
@@ -197,10 +197,10 @@  discard block
 block discarded – undo
197 197
                     ->prototype('array')
198 198
                         // Allow arg type short syntax (Arg: Type => Arg: {type: Type})
199 199
                         ->beforeNormalization()
200
-                            ->ifTrue(function ($options) {
200
+                            ->ifTrue(function($options) {
201 201
                                 return is_string($options);
202 202
                             })
203
-                            ->then(function ($options) {
203
+                            ->then(function($options) {
204 204
                                 return ['type' => $options];
205 205
                             })
206 206
                         ->end()
Please login to merge, or discard this patch.
Config/TypeDefinition.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
         $node = $builder->root('name', 'scalar');
44 44
         $node->isRequired();
45 45
         $node->validate()
46
-            ->ifTrue(function ($name) {
46
+            ->ifTrue(function($name) {
47 47
                 return !preg_match('/^[_a-z][_0-9a-z]*$/i', $name);
48 48
             })
49 49
                 ->thenInvalid('Invalid type name "%s". (see https://facebook.github.io/graphql/#Name)')
Please login to merge, or discard this patch.
Config/ObjectTypeDefinition.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,11 +36,11 @@
 block discarded – undo
36 36
             ->end();
37 37
 
38 38
         $node->validate()
39
-            ->ifTrue(function ($v) {
39
+            ->ifTrue(function($v) {
40 40
 
41 41
                 return array_key_exists('fieldsDefaultAccess', $v) && null !== $v['fieldsDefaultAccess'];
42 42
             })
43
-            ->then(function ($v) {
43
+            ->then(function($v) {
44 44
                 foreach ($v['fields'] as &$field) {
45 45
                     if (array_key_exists('access', $field) && null !== $field['access']) {
46 46
                         continue;
Please login to merge, or discard this patch.
Tests/Resolver/Toto.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 
41 41
     public function getPrivatePropertyWithoutGetterUsingCallBack()
42 42
     {
43
-        return function () {
43
+        return function() {
44 44
             return $this->privatePropertyWithoutGetter;
45 45
         };
46 46
     }
Please login to merge, or discard this patch.
DependencyInjection/Compiler/TypesPass.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
     private function processConfig(array $configs)
41 41
     {
42 42
         return array_map(
43
-            function ($v) {
43
+            function($v) {
44 44
                 if (is_array($v)) {
45 45
                     return call_user_func([$this, 'processConfig'], $v);
46 46
                 } elseif (is_string($v) && 0 === strpos($v, '@=')) {
Please login to merge, or discard this patch.
Resolver/AccessResolver.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
         switch (true) {
37 37
             case is_array($result):
38 38
                 $result = array_map(
39
-                    function ($object) use ($accessChecker, $resolveArgs) {
39
+                    function($object) use ($accessChecker, $resolveArgs) {
40 40
                         return $this->checkAccess($accessChecker, $object, $resolveArgs) ? $object : null;
41 41
                     },
42 42
                     $result
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
                 break;
45 45
             case $result instanceof Connection:
46 46
                 $result->edges = array_map(
47
-                    function (Edge $edge) use ($accessChecker, $resolveArgs) {
47
+                    function(Edge $edge) use ($accessChecker, $resolveArgs) {
48 48
                         $edge->node = $this->checkAccess($accessChecker, $edge->node, $resolveArgs) ? $edge->node : null;
49 49
 
50 50
                         return $edge;
Please login to merge, or discard this patch.
DependencyInjection/TypesConfiguration.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
         $rootNode = $treeBuilder->root('overblog_graphql_types');
37 37
 
38 38
         $configTypeKeys = array_map(
39
-            function ($type) {
39
+            function($type) {
40 40
                 return $this->normalizedConfigTypeKey($type);
41 41
             },
42 42
             self::$types
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             ->prototype('array')
50 50
                 // config is the unique config entry allowed
51 51
                 ->beforeNormalization()
52
-                    ->ifTrue(function ($v) use ($configTypeKeys) {
52
+                    ->ifTrue(function($v) use ($configTypeKeys) {
53 53
                         if (!empty($v) && is_array($v)) {
54 54
                             $keys = array_keys($v);
55 55
                             foreach ($configTypeKeys as $configTypeKey) {
@@ -64,16 +64,16 @@  discard block
 block discarded – undo
64 64
                         ->thenInvalid(
65 65
                             sprintf(
66 66
                                 'Don\'t use internal config keys %s, replace it by "config" instead.',
67
-                                implode(', ',  $configTypeKeys)
67
+                                implode(', ', $configTypeKeys)
68 68
                             )
69 69
                         )
70 70
                 ->end()
71 71
                 // config is renamed _{TYPE}_config
72 72
                 ->beforeNormalization()
73
-                    ->ifTrue(function ($v) {
73
+                    ->ifTrue(function($v) {
74 74
                         return isset($v['type']) && is_string($v['type']);
75 75
                     })
76
-                    ->then(function ($v) {
76
+                    ->then(function($v) {
77 77
                         $key = $this->normalizedConfigTypeKey($v['type']);
78 78
 
79 79
                         if (empty($v[$key])) {
@@ -96,10 +96,10 @@  discard block
 block discarded – undo
96 96
                 ->end()
97 97
                 // _{TYPE}_config is renamed config
98 98
                 ->validate()
99
-                    ->ifTrue(function ($v) {
99
+                    ->ifTrue(function($v) {
100 100
                         return isset($v[$this->normalizedConfigTypeKey($v['type'])]);
101 101
                     })
102
-                    ->then(function ($v) {
102
+                    ->then(function($v) {
103 103
                         $key = $this->normalizedConfigTypeKey($v['type']);
104 104
                         $v['config'] = $v[$key];
105 105
                         unset($v[$key]);
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 
116 116
     private function addBeforeNormalization(ArrayNodeDefinition $node)
117 117
     {
118
-        $typeKeyExists = function ($types) {
118
+        $typeKeyExists = function($types) {
119 119
             return !empty($types) && is_array($types);
120 120
         };
121 121
 
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
             // set type config.name
124 124
             ->beforeNormalization()
125 125
                 ->ifTrue($typeKeyExists)
126
-                ->then(function ($types) {
126
+                ->then(function($types) {
127 127
                     foreach ($types as $name => &$type) {
128 128
                         $type['config'] = isset($type['config']) && is_array($type['config']) ? $type['config'] : [];
129 129
                         $type['config']['name'] = $name;
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
             ->end()
150 150
             // normalized relay-mutation-payload
151 151
             ->beforeNormalization()
152
-                ->ifTrue(function ($types) {
152
+                ->ifTrue(function($types) {
153 153
                     return !empty($types) && is_array($types);
154 154
                 })
155 155
                 ->then($this->relayNormalizer('relay-mutation-payload', 'Overblog\GraphQLBundle\Relay\Mutation\PayloadDefinition'))
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 
159 159
     private function relayNormalizer($typeToTreat, $definitionBuilderClass)
160 160
     {
161
-        return function ($types) use ($typeToTreat, $definitionBuilderClass) {
161
+        return function($types) use ($typeToTreat, $definitionBuilderClass) {
162 162
             foreach ($types as $name => $type) {
163 163
                 if (isset($type['type']) && is_string($type['type']) && $typeToTreat === $type['type']) {
164 164
                     $config = isset($type['config']) && is_array($type['config']) ? $type['config'] : [];
Please login to merge, or discard this patch.