Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Push — master ( 4679be...840f05 )
by Jérémiah
19:13
created

EventDispatcherVersionHelper   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 13
Duplicated Lines 0 %

Test Coverage

Coverage 83.33%

Importance

Changes 0
Metric Value
wmc 3
eloc 6
dl 0
loc 13
ccs 5
cts 6
cp 0.8333
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A isForLegacy() 0 3 1
A dispatch() 0 6 2
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Overblog\GraphQLBundle\Event;
6
7
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
8
use Symfony\Component\HttpKernel\Kernel;
9
10
/**
11
 * @internal
12
 * TODO(mcg-web): delete hack after migrating Symfony >= 4.3
13
 */
14
final class EventDispatcherVersionHelper
15
{
16 116
    public static function isForLegacy(): bool
17
    {
18 116
        return Kernel::VERSION_ID < 40300;
19
    }
20
21 112
    public static function dispatch(EventDispatcherInterface $dispatcher, $event, ?string $eventName)
22
    {
23 112
        if (self::isForLegacy()) {
24
            return $dispatcher->dispatch($eventName, $event);
0 ignored issues
show
Unused Code introduced by
The call to Symfony\Contracts\EventD...erInterface::dispatch() has too many arguments starting with $event. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

24
            return $dispatcher->/** @scrutinizer ignore-call */ dispatch($eventName, $event);

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.

Loading history...
Bug introduced by
It seems like $eventName can also be of type string; however, parameter $event of Symfony\Contracts\EventD...erInterface::dispatch() does only seem to accept object, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

24
            return $dispatcher->dispatch(/** @scrutinizer ignore-type */ $eventName, $event);
Loading history...
25
        } else {
26 112
            return $dispatcher->dispatch($event, $eventName);
27
        }
28
    }
29
}
30