TypeDefinition::validationSection() - Code Metrics - Inspection of "[feature] Introduce input validation" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 83db66...8ac73c )

by Jérémiah

created 2019-09-29 17:11 UTC

TypeDefinition::validationSection() B

↳ Parent: TypeDefinition

Complexity

Conditions	8
Paths	2

Size

Total Lines	65
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	42
CRAP Score	8

Importance

Changes

Metric	Value
eloc	44
c	0
b	0
f	0
dl	0
loc	65
ccs	42
cts	42
cp	1
rs	7.9715
cc	8
nc	2
nop	1
crap	8

How to fix Long Method

<?php

declare(strict_types=1);

namespace Overblog\GraphQLBundle\Config;

use Overblog\GraphQLBundle\DependencyInjection\Configuration;
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\Definition\Builder\NodeDefinition;
use Symfony\Component\Config\Definition\Builder\NodeParentInterface;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;

abstract class TypeDefinition
{
    public const VALIDATION_LEVEL_CLASS = 0;
    public const VALIDATION_LEVEL_PROPERTY = 1;

    abstract public function getDefinition();

    protected function __construct()
    {
    }

    /**
     * @return static
     */
    public static function create()
    {
        return new static();
    }

    protected function resolveTypeSection()
    {
        $node = self::createNode('resolveType', 'variable');

        return $node;
    }

    protected function nameSection()
    {
        $node = self::createNode('name', 'scalar');
        $node->isRequired();
        $node->validate()
            ->ifTrue(function ($name) {
                return !\preg_match('/^[_a-z][_0-9a-z]*$/i', $name);
            })
                ->thenInvalid('Invalid type name "%s". (see https://facebook.github.io/graphql/October2016/#Name)')
        ->end();

        return $node;
    }

    protected function defaultValueSection()
    {
        $node = self::createNode('defaultValue', 'variable');

        return $node;
    }

    /**
     * @param int $level
     *
     * @return ArrayNodeDefinition|NodeDefinition
     */
    protected function validationSection(int $level): NodeParentInterface
    {
        $node = self::createNode('validation', 'array');

        $node
            // allow shorthands
            ->beforeNormalization()
                ->always(function ($value) {
                    if (\is_string($value)) {
                        // cascade or link
                        return 'cascade' === $value ? ['cascade' => null] : ['link' => $value];
                    }

                    if (\is_array($value)) {
                        foreach ($value as $k => $a) {
                            if (!\is_int($k)) {
                                // validation: { link: ... , constraints: ..., cascade: ... }
                                return $value;
                            }
                        }
                        // validation: [<validation constraints>]
                        return ['constraints' => $value];
                    }

                    return [];
                })
            ->end()
            ->children()
                ->scalarNode('link')
                    ->defaultNull()
                    ->validate()
                        ->ifTrue(function ($link) use ($level) {
                            if (self::VALIDATION_LEVEL_PROPERTY === $level) {
                                return !\preg_match('/^(?:\\\\?[A-Za-z][A-Za-z\d]+)*[A-Za-z\d]+::(?:[$]?[A-Za-z][A-Za-z_\d]+|[A-Za-z_\d]+\(\))$/m', $link);
                            } else {
                                return !\preg_match('/^(?:\\\\?[A-Za-z][A-Za-z\d]+)*[A-Za-z\d]$/m', $link);
                            }
                        })
                        ->thenInvalid('Invalid link provided: "%s".')
                    ->end()
                ->end()

                ->variableNode('constraints')
                    ->defaultNull()
                ->end()
            ->end();

        // Add the 'cascade' option if it's a property level validation section
        if (self::VALIDATION_LEVEL_PROPERTY === $level) {
            $node
                ->children()
                    ->arrayNode('cascade')
                        ->children()
                            ->arrayNode('groups')
                                ->beforeNormalization()
                                    ->castToArray()
                                ->end()
                                ->scalarPrototype()->end()
                            ->end()
                        ->end()
                    ->end()
                ->end();
        }

        return $node;
    }

    protected function descriptionSection()
    {
        $node = self::createNode('description', 'scalar');

        return $node;
    }

    protected function deprecationReasonSelection()
    {
        $node = self::createNode('deprecationReason', 'scalar');

        $node->info('Text describing why this field is deprecated. When not empty - field will not be returned by introspection queries (unless forced)');

        return $node;
    }

    protected function typeSelection($isRequired = false)
    {
        $node = self::createNode('type', 'scalar');

        $node->info('One of internal or custom types.');

        if ($isRequired) {
            $node->isRequired();
        }

        return $node;
    }

    /**
     * @param string $name
     * @param string $type
     *
     * @return ArrayNodeDefinition|NodeDefinition
     *
     *@internal
     */
    protected static function createNode(string $name, string $type = 'array')
    {
        return Configuration::getRootNodeWithoutDeprecation(new TreeBuilder($name, $type), $name, $type);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Overblog\GraphQLBundle\Config;
6
7		use Overblog\GraphQLBundle\DependencyInjection\Configuration;
8		use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
9		use Symfony\Component\Config\Definition\Builder\NodeDefinition;
10		use Symfony\Component\Config\Definition\Builder\NodeParentInterface;
11		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
12
13		abstract class TypeDefinition
14		{
15		public const VALIDATION_LEVEL_CLASS = 0;
16		public const VALIDATION_LEVEL_PROPERTY = 1;
17
18		abstract public function getDefinition();
19
20	46	protected function __construct()
21		{
22	46	}
23
24		/**
25		* @return static
26		*/
27	46	public static function create()
28		{
29	46	return new static();
30		}
31
32	46	protected function resolveTypeSection()
33		{
34	46	$node = self::createNode('resolveType', 'variable');
35
36	46	return $node;
37		}
38
39	46	protected function nameSection()
40		{
41	46	$node = self::createNode('name', 'scalar');
42	46	$node->isRequired();
43	46	$node->validate()
44		->ifTrue(function ($name) {
45	37	return !\preg_match('/^[_a-z][_0-9a-z]*$/i', $name);
46	46	})
47	46	->thenInvalid('Invalid type name "%s". (see https://facebook.github.io/graphql/October2016/#Name)')
48	46	->end();
49
50	46	return $node;
51		}
52
53	46	protected function defaultValueSection()
54		{
55	46	$node = self::createNode('defaultValue', 'variable');
56
57	46	return $node;
58		}
59
60		/**
61		* @param int $level
62		*
63		* @return ArrayNodeDefinition\|NodeDefinition
64		*/
65	46	protected function validationSection(int $level): NodeParentInterface
66		{
67	46	$node = self::createNode('validation', 'array');
68
69		$node
70		// allow shorthands
71	46	->beforeNormalization()
72		->always(function ($value) {
73	3	if (\is_string($value)) {
74		// cascade or link
75	2	return 'cascade' === $value ? ['cascade' => null] : ['link' => $value];
76		}
77
78	2	if (\is_array($value)) {
79	2	foreach ($value as $k => $a) {
80	2	if (!\is_int($k)) {
81		// validation: { link: ... , constraints: ..., cascade: ... }
82	1	return $value;
83		}
84		}
85		// validation: [<validation constraints>]
86	2	return ['constraints' => $value];
87		}
88
89	1	return [];
90	46	})
91	46	->end()
92	46	->children()
93	46	->scalarNode('link')
94	46	->defaultNull()
95	46	->validate()
96		->ifTrue(function ($link) use ($level) {
97	1	if (self::VALIDATION_LEVEL_PROPERTY === $level) {
98	1	return !\preg_match('/^(?:\\\\?[A-Za-z][A-Za-z\d]+)*[A-Za-z\d]+::(?:[$]?[A-Za-z][A-Za-z_\d]+\|[A-Za-z_\d]+\(\))$/m', $link);
99		} else {
100	1	return !\preg_match('/^(?:\\\\?[A-Za-z][A-Za-z\d]+)*[A-Za-z\d]$/m', $link);
101		}
102	46	})
103	46	->thenInvalid('Invalid link provided: "%s".')
104	46	->end()
105	46	->end()
106
107	46	->variableNode('constraints')
108	46	->defaultNull()
109	46	->end()
110	46	->end();
111
112		// Add the 'cascade' option if it's a property level validation section
113	46	if (self::VALIDATION_LEVEL_PROPERTY === $level) {
114		$node
115	46	->children()
116	46	->arrayNode('cascade')
117	46	->children()
118	46	->arrayNode('groups')
119	46	->beforeNormalization()
120	46	->castToArray()
121	46	->end()
122	46	->scalarPrototype()->end()
123	46	->end()
124	46	->end()
125	46	->end()
126	46	->end();
127		}
128
129	46	return $node;
130		}
131
132	46	protected function descriptionSection()
133		{
134	46	$node = self::createNode('description', 'scalar');
135
136	46	return $node;
137		}
138
139	46	protected function deprecationReasonSelection()
140		{
141	46	$node = self::createNode('deprecationReason', 'scalar');
142
143	46	$node->info('Text describing why this field is deprecated. When not empty - field will not be returned by introspection queries (unless forced)');
144
145	46	return $node;
146		}
147
148	46	protected function typeSelection($isRequired = false)
149		{
150	46	$node = self::createNode('type', 'scalar');
151
152	46	$node->info('One of internal or custom types.');
153
154	46	if ($isRequired) {
155	46	$node->isRequired();
156		}
157
158	46	return $node;
159		}
160
161		/**
162		* @param string $name
163		* @param string $type
164		*
165		* @return ArrayNodeDefinition\|NodeDefinition
166		*
167		*@internal
168		*/
169	46	protected static function createNode(string $name, string $type = 'array')
170		{
171	46	return Configuration::getRootNodeWithoutDeprecation(new TreeBuilder($name, $type), $name, $type);
172		}
173		}
174

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Push — master ( 83db66...8ac73c )

TypeDefinition::validationSection() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like