Overblog\GraphQLBundle\Config\EnumTypeDefinition::getDefinition()

Complexity

Conditions	5
Paths	1

Size

Total Lines	44
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	31
CRAP Score	5

Importance

Changes

0

<?php
    public function getDefinition()
    {
        $node = self::createNode('_enum_config');

        $node
            ->children()
                ->append($this->nameSection())
                ->arrayNode('values')
                    ->useAttributeAsKey('name')
                    ->beforeNormalization()
                        ->ifTrue(function ($v) {
                            return \is_array($v);
                        })
                        ->then(function ($v) {
                            foreach ($v as $name => &$options) {
                                // short syntax NAME: VALUE
                                if (!\is_null($options) && !\is_array($options)) {
                                    $options = ['value' => $options];
                                }

                                // use name as value if no value given
                                if (!\array_key_exists('value', $options)) {

It seems like $options can also be of type null; however, parameter $search of array_key_exists() does only seem to accept array, maybe add an additional type check?

                                    $options['value'] = $name;
                                }
                            }

                            return $v;
                        })
                    ->end()
                    ->prototype('array')
                        ->isRequired()
                        ->children()
                            ->scalarNode('value')->isRequired()->end()
                            ->append($this->descriptionSection())
                            ->append($this->deprecationReasonSelection())
                        ->end()
                    ->end()
                    ->isRequired()
                    ->requiresAtLeastOneElement()
                ->end()
                ->append($this->descriptionSection())
            ->end();

        return $node;
    }