DeprecatedPropertyPublicAccessTrait::accessProperty() - Code Metrics - Inspection of "Relay pagination customization" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#413)

by Jérémiah

created 2018-12-22 19:21 UTC

accessProperty() A

↳ Parent: DeprecatedPropertyPublicAccessTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	2.1715

Importance

Changes

Metric	Value
dl	0
loc	32
ccs	13
cts	20
cp	0.65
rs	9.408
c	0
b	0
f	0
cc	2
nc	2
nop	3
crap	2.1715

<?php

declare(strict_types=1);

namespace Overblog\GraphQLBundle\Relay\Connection\Output;

/**
 * @internal
 */
trait DeprecatedPropertyPublicAccessTrait
{
    public function __get($name)
    {
        return $this->accessProperty('get', $name);
    }

    public function __set($name, $value)
    {
        return $this->accessProperty('set', $name, $value);
    }

    private function accessProperty(string $type, string $name, $value = null)
    {
        if (\in_array($name, \array_keys(\get_object_vars($this)))) {
            $method = $type.\ucfirst($name);

            @\trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                \sprintf(
                    '%sting directly property %s::$%s value is deprecated as of 0.12 and will be removed in 0.13. '.
                    'You should now use method %s::%s.',
                    \ucfirst($type),
                    __CLASS__,
                    $name,
                    __CLASS__,
                    $method
                ),
                \E_USER_DEPRECATED
            );

            return $this->$method($value);
        }

        \trigger_error(
            \sprintf(
                'Undefined property %s::$%s.',
                __CLASS__,
                $name
            ),
            \E_USER_NOTICE
        );

        return null;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Overblog\GraphQLBundle\Relay\Connection\Output;
6
7		/**
8		* @internal
9		*/
10		trait DeprecatedPropertyPublicAccessTrait
11		{
12	1	public function __get($name)
13		{
14	1	return $this->accessProperty('get', $name);
15		}
16
17	1	public function __set($name, $value)
18		{
19	1	return $this->accessProperty('set', $name, $value);
20		}
21
22	2	private function accessProperty(string $type, string $name, $value = null)
23		{
24	2	if (\in_array($name, \array_keys(\get_object_vars($this)))) {
25	2	$method = $type.\ucfirst($name);
26
27	2	@\trigger_error(
		0 ignored issues – show Security Best Practice introduced 2018-12-22 19:28 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
28	2	\sprintf(
29		'%sting directly property %s::$%s value is deprecated as of 0.12 and will be removed in 0.13. '.
30	2	'You should now use method %s::%s.',
31	2	\ucfirst($type),
32	2	__CLASS__,
33	2	$name,
34	2	__CLASS__,
35	2	$method
36		),
37	2	\E_USER_DEPRECATED
38		);
39
40	2	return $this->$method($value);
41		}
42
43		\trigger_error(
44		\sprintf(
45		'Undefined property %s::$%s.',
46		__CLASS__,
47		$name
48		),
49		\E_USER_NOTICE
50		);
51
52		return null;
53		}
54		}
55

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#413)

accessProperty() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like