Connection::getEdges() - Code Metrics - Inspection of "Relay pagination customization" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#413)

by Vincent

created 2018-10-30 12:17 UTC

Connection::getEdges() A

↳ Parent: Connection

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
ccs	0
cts	0
cp	0
cc	1
nc	1
nop	0
crap	2

<?php

declare(strict_types=1);

namespace Overblog\GraphQLBundle\Relay\Connection\Output;

use Overblog\GraphQLBundle\Relay\Connection\ConnectionInterface;

class Connection implements ConnectionInterface
{
    /** @var Edge[] */
    protected $edges = [];

    /** @var PageInfo */
    protected $pageInfo = null;

    /** @var int */
    protected $totalCount = 0;

    public function __construct($edges = [], PageInfo $pageInfo = null)
    {
        $this->edges = $edges;
        $this->pageInfo = $pageInfo;
    }

    /**
     * {@inheritdoc}
     */
    public function getEdges()
    {
        return $this->edges;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     */
    public function setEdges(iterable $edges): void
    {
        $this->edges = $edges;

    }

    /**
     * {@inheritdoc}
     */
    public function getPageInfo(): ? PageInfo
    {
        return $this->pageInfo;
    }

    /**
     * {@inheritdoc}
     */
    public function setPageInfo(PageInfo $pageInfo): void
    {
        $this->pageInfo = $pageInfo;
    }

    /**
     * {@inheritdoc}
     */
    public function getTotalCount(): int
    {
        return $this->totalCount;
    }

    /**
     * {@inheritdoc}
     */
    public function setTotalCount(int $totalCount): void
    {
        $this->totalCount = $totalCount;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Overblog\GraphQLBundle\Relay\Connection\Output;
6
7		use Overblog\GraphQLBundle\Relay\Connection\ConnectionInterface;
8
9		class Connection implements ConnectionInterface
10		{
11		/** @var Edge[] */
12		protected $edges = [];
13
14		/** @var PageInfo */
15		protected $pageInfo = null;
16
17		/** @var int */
18	54	protected $totalCount = 0;
19
20	54	public function __construct($edges = [], PageInfo $pageInfo = null)
21	54	{
22	54	$this->edges = $edges;
23		$this->pageInfo = $pageInfo;
24		}
25
26		/**
27		* {@inheritdoc}
28		*/
29		public function getEdges()
30		{
31		return $this->edges;
		0 ignored issues – show Bug Best Practice introduced 2018-10-30 12:38 UTC by Report Bug Copy Issue Report The return type of `return $this->edges;` (`Overblog\GraphQLBundle\R...onnection\Output\Edge[]`) is incompatible with the return type declared by the interface `Overblog\GraphQLBundle\R...tionInterface::getEdges` of type `Overblog\GraphQLBundle\Relay\Connection\iterable`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
32		}
33
34		/**
35		* {@inheritdoc}
36		*/
37		public function setEdges(iterable $edges): void
38		{
39		$this->edges = $edges;
		0 ignored issues – show Documentation Bug introduced 2018-10-30 12:38 UTC by Report Bug Copy Issue Report It seems like `$edges` of type `object<Overblog\GraphQLB...ay\Connection\iterable>` is incompatible with the declared type `array<integer,object<Ove...onnection\Output\Edge>>` of property `$edges`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
40		}
41
42		/**
43		* {@inheritdoc}
44		*/
45		public function getPageInfo(): ? PageInfo
46		{
47		return $this->pageInfo;
48		}
49
50		/**
51		* {@inheritdoc}
52		*/
53		public function setPageInfo(PageInfo $pageInfo): void
54		{
55		$this->pageInfo = $pageInfo;
56		}
57
58		/**
59		* {@inheritdoc}
60		*/
61		public function getTotalCount(): int
62		{
63		return $this->totalCount;
64		}
65
66		/**
67		* {@inheritdoc}
68		*/
69		public function setTotalCount(int $totalCount): void
70		{
71		$this->totalCount = $totalCount;
72		}
73		}
74

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#413)

Connection::getEdges() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like