Configuration::getConfigTreeBuilder() - Code Metrics - Inspection of "Add query max depth security" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#21)

by Jérémiah

created 2016-03-27 14:02 UTC

Configuration::getConfigTreeBuilder() B

↳ Parent: Configuration

Complexity

Conditions	1
Paths	1

Size

Total Lines	80
Code Lines	75

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	71
CRAP Score	1

Importance

Changes	10
Bugs	0	Features	5

Metric	Value
c	10
b	0
f	5
dl	0
loc	80
ccs	71
cts	71
cp	1
rs	8.8387
cc	1
eloc	75
nc	1
nop	0
crap	1

How to fix Long Method

<?php

/*
 * This file is part of the OverblogGraphQLBundle package.
 *
 * (c) Overblog <http://github.com/overblog/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Overblog\GraphQLBundle\DependencyInjection;

use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\ConfigurationInterface;

/**
 * @todo fix xml
 */
class Configuration implements ConfigurationInterface
{
    private $debug;

    /**
     * Constructor.
     *
     * @param bool $debug Whether to use the debug mode
     */
    public function __construct($debug)
    {
        $this->debug = (Boolean) $debug;
    }

    public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root('overblog_graphql');

        $rootNode
            ->children()
                ->arrayNode('definitions')
                    ->addDefaultsIfNotSet()
                    ->children()
                        ->scalarNode('internal_error_message')->defaultNull()->end()
                        ->booleanNode('config_validation')->defaultValue($this->debug)->end()
                        ->arrayNode('schema')
                            ->addDefaultsIfNotSet()
                            ->children()
                                ->scalarNode('query')->defaultNull()->end()
                                ->scalarNode('mutation')->defaultNull()->end()
                                ->scalarNode('subscription')->defaultNull()->end()
                            ->end()
                        ->end()
                        ->arrayNode('mappings')
                            ->children()
                                ->arrayNode('types')
                                    ->prototype('array')
                                        ->addDefaultsIfNotSet()
                                        ->children()
                                            ->enumNode('type')->isRequired()->values(['yml', 'xml'])->end()
                                            ->scalarNode('dir')->defaultNull()->end()
                                        ->end()
                                    ->end()
                                ->end()
                            ->end()
                        ->end()
                        // TODO remove when types mapping 100% functional
                        ->variableNode('types')
                            ->info('Defining types using semantic config is deprecated and will be soon removed.')
                        ->end()
                    ->end()
                ->end()
                ->arrayNode('templates')
                    ->addDefaultsIfNotSet()
                    ->children()
                        ->scalarNode('graphiql')
                            ->defaultValue('OverblogGraphQLBundle:GraphiQL:index.html.twig')
                        ->end()
                    ->end()
                ->end()
                ->arrayNode('services')
                    ->addDefaultsIfNotSet()
                    ->children()
                        ->scalarNode('expression_language')
                            ->defaultValue('overblog_graphql.expression_language.default')
                        ->end()
                        ->scalarNode('cache_expression_language_parser')
                            ->defaultValue('overblog_graphql.cache_expression_language_parser.default')
                        ->end()
                    ->end()
                ->end()
                ->arrayNode('security')
                    ->addDefaultsIfNotSet()
                        ->children()
                            ->integerNode('query_max_depth')
                                ->info('Limit query depth. Disabled if equal to false or 0.')
                                ->beforeNormalization()
                                    ->ifTrue(function ($v) { return false === $v; })
                                    ->then(function () { return 0; })
                                ->end()
                                ->defaultFalse()
                                ->validate()
                                    ->ifTrue(function ($v) { return $v < 0; })
                                    ->thenInvalid('"overblog_graphql.security.query_max_depth" must be greater or equal to 0.')
                                ->end()
                            ->end()
                        ->end()
                    ->end()
                ->end()
            ->end();

        return $treeBuilder;
    }
}


1		<?php
2
3		/*
4		* This file is part of the OverblogGraphQLBundle package.
5		*
6		* (c) Overblog <http://github.com/overblog/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Overblog\GraphQLBundle\DependencyInjection;
13
14		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
15		use Symfony\Component\Config\Definition\ConfigurationInterface;
16
17		/**
18		* @todo fix xml
19		*/
20		class Configuration implements ConfigurationInterface
21		{
22		private $debug;
23
24		/**
25		* Constructor.
26		*
27		* @param bool $debug Whether to use the debug mode
28		*/
29	36	public function __construct($debug)
30		{
31	36	$this->debug = (Boolean) $debug;
32	36	}
33
34	36	public function getConfigTreeBuilder()
35		{
36	36	$treeBuilder = new TreeBuilder();
37	36	$rootNode = $treeBuilder->root('overblog_graphql');
38
39		$rootNode
40	36	->children()
41	36	->arrayNode('definitions')
42	36	->addDefaultsIfNotSet()
43	36	->children()
44	36	->scalarNode('internal_error_message')->defaultNull()->end()
45	36	->booleanNode('config_validation')->defaultValue($this->debug)->end()
46	36	->arrayNode('schema')
47	36	->addDefaultsIfNotSet()
48	36	->children()
49	36	->scalarNode('query')->defaultNull()->end()
50	36	->scalarNode('mutation')->defaultNull()->end()
51	36	->scalarNode('subscription')->defaultNull()->end()
52	36	->end()
53	36	->end()
54	36	->arrayNode('mappings')
55	36	->children()
56	36	->arrayNode('types')
57	36	->prototype('array')
58	36	->addDefaultsIfNotSet()
59	36	->children()
60	36	->enumNode('type')->isRequired()->values(['yml', 'xml'])->end()
61	36	->scalarNode('dir')->defaultNull()->end()
62	36	->end()
63	36	->end()
64	36	->end()
65	36	->end()
66	36	->end()
67		// TODO remove when types mapping 100% functional
68	36	->variableNode('types')
69	36	->info('Defining types using semantic config is deprecated and will be soon removed.')
70	36	->end()
71	36	->end()
72	36	->end()
73	36	->arrayNode('templates')
74	36	->addDefaultsIfNotSet()
75	36	->children()
76	36	->scalarNode('graphiql')
77	36	->defaultValue('OverblogGraphQLBundle:GraphiQL:index.html.twig')
78	36	->end()
79	36	->end()
80	36	->end()
81	36	->arrayNode('services')
82	36	->addDefaultsIfNotSet()
83	36	->children()
84	36	->scalarNode('expression_language')
85	36	->defaultValue('overblog_graphql.expression_language.default')
86	36	->end()
87	36	->scalarNode('cache_expression_language_parser')
88	36	->defaultValue('overblog_graphql.cache_expression_language_parser.default')
89	36	->end()
90	36	->end()
91	36	->end()
92	36	->arrayNode('security')
93	36	->addDefaultsIfNotSet()
94	36	->children()
95	36	->integerNode('query_max_depth')
96	36	->info('Limit query depth. Disabled if equal to false or 0.')
97	36	->beforeNormalization()
98		->ifTrue(function ($v) { return false === $v; })
99		->then(function () { return 0; })
100	36	->end()
101	36	->defaultFalse()
102	36	->validate()
103		->ifTrue(function ($v) { return $v < 0; })
104	36	->thenInvalid('"overblog_graphql.security.query_max_depth" must be greater or equal to 0.')
105	36	->end()
106	36	->end()
107	36	->end()
108	36	->end()
109	36	->end()
110	36	->end();
111
112	36	return $treeBuilder;
113		}
114		}
115

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#21)

Configuration::getConfigTreeBuilder() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like