Inspection of "Merge pull request #70 from mcg-web/optimizations" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 26279b...73877d )

by Jérémiah

created 2016-10-21 14:18 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
         switch (true) {
             case is_array($result):
                 $result = array_map(
-                    function ($object) use ($accessChecker, $resolveArgs) {
+                    function($object) use ($accessChecker, $resolveArgs) {
                         return $this->checkAccess($accessChecker, $object, $resolveArgs) ? $object : null;
                     },
                     $result
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
                 break;
             case $result instanceof Connection:
                 $result->edges = array_map(
-                    function (Edge $edge) use ($accessChecker, $resolveArgs) {
+                    function(Edge $edge) use ($accessChecker, $resolveArgs) {
                         $edge->node = $this->checkAccess($accessChecker, $edge->node, $resolveArgs) ? $edge->node : null;
 
                         return $edge;

Please login to merge, or discard this patch.

Tests/ExpressionLanguage/AuthorizationExpressionProviderTest.php 1 patch

Doc Comments +3 added lines patch added patch discarded remove patch

@@ -113,6 +113,9 @@
 block discarded – undo
         );
     }
 
+    /**
+     * @param string $expression
+     */
     private function assertExpressionCompile($expression, $with, array $expressionValues = [], $expects = null, $return = true, $assertMethod = 'assertTrue')
     {
         $authChecker = $this->getAuthorizationCheckerIsGrantedWithExpectation($with, $expects, $return);

Please login to merge, or discard this patch.

Request/Executor.php 1 patch

Doc Comments +3 added lines patch added patch discarded remove patch

@@ -121,6 +121,9 @@
 block discarded – undo
         return $node;
     }
 
+    /**
+     * @param string $name
+     */
     private function addFieldsSelection($name, $enabledBuilder = true)
     {
         $builder = new TreeBuilder();

Please login to merge, or discard this patch.

DependencyInjection/OverblogGraphQLTypesExtension.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -104,8 +104,8 @@
 block discarded – undo
         // from config
         if (!empty($config['definitions']['mappings']['types'])) {
             $typesMappings = array_filter(array_map(
-                function (array $typeMapping) use ($container) {
-                    $params = $this->detectConfigFiles($container, $typeMapping['dir'],  $typeMapping['type']);
+                function(array $typeMapping) use ($container) {
+                    $params = $this->detectConfigFiles($container, $typeMapping['dir'], $typeMapping['type']);
 
                     return $params;
                 },

Please login to merge, or discard this patch.

DependencyInjection/Configuration.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -48,14 +48,14 @@  discard block
 block discarded – undo
                         ->booleanNode('config_validation')->defaultValue($this->debug)->end()
                         ->arrayNode('schema')
                             ->beforeNormalization()
-                                ->ifTrue(function ($v) {
+                                ->ifTrue(function($v) {
                                     $needNormalization = isset($v['query']) && is_string($v['query']) ||
                                         isset($v['mutation']) && is_string($v['mutation']) ||
                                         isset($v['subscription']) && is_string($v['subscription']);
 
                                     return $needNormalization;
                                 })
-                                ->then(function ($v) {
+                                ->then(function($v) {
                                     return ['default' => $v];
                                 })
                             ->end()
@@ -175,16 +175,16 @@  discard block
 block discarded – undo
         $node
             ->info('Disabled if equal to false.')
             ->beforeNormalization()
-                ->ifTrue(function ($v) {
+                ->ifTrue(function($v) {
                     return false === $v;
                 })
-                ->then(function () use ($disabledValue) {
+                ->then(function() use ($disabledValue) {
                     return $disabledValue;
                 })
             ->end()
             ->defaultFalse()
             ->validate()
-                ->ifTrue(function ($v) {
+                ->ifTrue(function($v) {
                     return $v < 0;
                 })
                 ->thenInvalid('"overblog_graphql.security.'.$name.'" must be greater or equal to 0.')

Please login to merge, or discard this patch.

Tests/Request/ExecutorTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -60,7 +60,7 @@
 block discarded – undo
             'fields' => [
                 'myField' => [
                     'type' => Type::boolean(),
-                    'resolve' => function () {
+                    'resolve' => function() {
                         return false;
                     },
                 ],

Please login to merge, or discard this patch.

Config/EnumTypeDefinition.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -27,10 +27,10 @@
 block discarded – undo
                     ->useAttributeAsKey('name')
                     ->prototype('array')
                         ->beforeNormalization()
-                            ->ifTrue(function ($v) {
+                            ->ifTrue(function($v) {
                                 return !is_null($v) && !is_array($v);
                             })
-                            ->then(function ($v) {
+                            ->then(function($v) {
                                 return ['value' => $v];
                             })
                         ->end()

Please login to merge, or discard this patch.

ExpressionLanguage/ConfigExpressionProvider.php 1 patch

Spacing +24 added lines, -24 removed lines patch added patch discarded remove patch

@@ -22,100 +22,100 @@  discard block
 block discarded – undo
         return [
             new ExpressionFunction(
                 'service',
-                function ($value) {
+                function($value) {
                     return sprintf('$container->get(%s)', $value);
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'parameter',
-                function ($value) {
+                function($value) {
                     return sprintf('$container->getParameter(%s)', $value);
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'isTypeOf',
-                function ($className) {
+                function($className) {
                     return sprintf('($className = %s) && $value instanceof $className', $className);
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'resolver',
-                function ($alias, $args = '[]') {
+                function($alias, $args = '[]') {
                     return sprintf('$container->get(\'overblog_graphql.resolver_resolver\')->resolve([%s, %s])', $alias, $args);
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'mutateAndGetPayloadCallback',
-                function ($mutateAndGetPayload) {
+                function($mutateAndGetPayload) {
                     $code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
                     $code .= 'return '.$mutateAndGetPayload.'; }';
 
                     return $code;
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'mutateAndGetPayloadCallback',
-                function ($mutateAndGetPayload) {
+                function($mutateAndGetPayload) {
                     $code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
                     $code .= 'return '.$mutateAndGetPayload.'; }';
 
                     return $code;
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'idFetcherCallback',
-                function ($idFetcher) {
+                function($idFetcher) {
                     $code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
                     $code .= 'return '.$idFetcher.'; }';
 
                     return $code;
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'resolveSingleInputCallback',
-                function ($resolveSingleInput) {
+                function($resolveSingleInput) {
                     $code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
                     $code .= 'return '.$resolveSingleInput.'; }';
 
                     return $code;
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'mutation',
-                function ($alias, $args = '[]') {
+                function($alias, $args = '[]') {
                     return sprintf('$container->get(\'overblog_graphql.mutation_resolver\')->resolve([%s, %s])', $alias, $args);
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'globalId',
-                function ($id, $typeName = null) {
+                function($id, $typeName = null) {
                     $typeNameEmpty = null === $typeName || '""' === $typeName || 'null' === $typeName || 'false' === $typeName;
 
                     return sprintf(
@@ -124,28 +124,28 @@  discard block
 block discarded – undo
                         $id
                     );
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'fromGlobalId',
-                function ($globalId) {
+                function($globalId) {
                     return sprintf(
                         '\\Overblog\\GraphQLBundle\\Relay\\Node\\GlobalId::fromGlobalId(%s)',
                         $globalId
                     );
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'newObject',
-                function ($className, $args = '[]') {
+                function($className, $args = '[]') {
                     return sprintf('(new \ReflectionClass(%s))->newInstanceArgs(%s)', $className, $args);
                 },
-                function () {
+                function() {
                 }
             ),
         ];

Please login to merge, or discard this patch.

ExpressionLanguage/AuthorizationExpressionProvider.php 1 patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -21,79 +21,79 @@
 block discarded – undo
         return [
             new ExpressionFunction(
                 'hasRole',
-                function ($role) {
+                function($role) {
                     return sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s)', $role);
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'hasAnyRole',
-                function ($roles) {
+                function($roles) {
                     $code = sprintf('array_reduce(%s, function ($isGranted, $role) use ($container) { return $isGranted || $container->get(\'security.authorization_checker\')->isGranted($role); }, false)', $roles);
 
                     return $code;
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'isAnonymous',
-                function () {
+                function() {
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_ANONYMOUSLY\')';
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'isRememberMe',
-                function () {
+                function() {
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\')';
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'isFullyAuthenticated',
-                function () {
+                function() {
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'isAuthenticated',
-                function () {
+                function() {
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\') || $container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'hasPermission',
-                function ($object, $permission) {
+                function($object, $permission) {
                     $code = sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s, %s)', $permission, $object);
 
                     return $code;
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'hasAnyPermission',
-                function ($object, $permissions) {
+                function($object, $permissions) {
                     $code = sprintf('array_reduce(%s, function ($isGranted, $permission) use ($container, $object) { return $isGranted || $container->get(\'security.authorization_checker\')->isGranted($permission, %s); }, false)', $permissions, $object);
 
                     return $code;
                 },
-                function () {
+                function() {
                 }
             ),
         ];

Please login to merge, or discard this patch.

		@@ -113,6 +113,9 @@
		block discarded – undo
113	113	);
114	114	}
115	115
	116	+ /**
	117	+ * @param string $expression
	118	+ */
116	119	private function assertExpressionCompile($expression, $with, array $expressionValues = [], $expects = null, $return = true, $assertMethod = 'assertTrue')
117	120	{
118	121	$authChecker = $this->getAuthorizationCheckerIsGrantedWithExpectation($with, $expects, $return);

		@@ -104,8 +104,8 @@
		block discarded – undo
104	104	// from config
105	105	if (!empty($config['definitions']['mappings']['types'])) {
106	106	$typesMappings = array_filter(array_map(
107		- function (array $typeMapping) use ($container) {
108		- $params = $this->detectConfigFiles($container, $typeMapping['dir'], $typeMapping['type']);
	107	+ function(array $typeMapping) use ($container) {
	108	+ $params = $this->detectConfigFiles($container, $typeMapping['dir'], $typeMapping['type']);
109	109
110	110	return $params;
111	111	},

		@@ -48,14 +48,14 @@ discard block
		block discarded – undo
48	48	->booleanNode('config_validation')->defaultValue($this->debug)->end()
49	49	->arrayNode('schema')
50	50	->beforeNormalization()
51		- ->ifTrue(function ($v) {
	51	+ ->ifTrue(function($v) {
52	52	$needNormalization = isset($v['query']) && is_string($v['query']) \|\|
53	53	isset($v['mutation']) && is_string($v['mutation']) \|\|
54	54	isset($v['subscription']) && is_string($v['subscription']);
55	55
56	56	return $needNormalization;
57	57	})
58		- ->then(function ($v) {
	58	+ ->then(function($v) {
59	59	return ['default' => $v];
60	60	})
61	61	->end()
		@@ -175,16 +175,16 @@ discard block
		block discarded – undo
175	175	$node
176	176	->info('Disabled if equal to false.')
177	177	->beforeNormalization()
178		- ->ifTrue(function ($v) {
	178	+ ->ifTrue(function($v) {
179	179	return false === $v;
180	180	})
181		- ->then(function () use ($disabledValue) {
	181	+ ->then(function() use ($disabledValue) {
182	182	return $disabledValue;
183	183	})
184	184	->end()
185	185	->defaultFalse()
186	186	->validate()
187		- ->ifTrue(function ($v) {
	187	+ ->ifTrue(function($v) {
188	188	return $v < 0;
189	189	})
190	190	->thenInvalid('"overblog_graphql.security.'.$name.'" must be greater or equal to 0.')

		@@ -22,100 +22,100 @@ discard block
		block discarded – undo
22	22	return [
23	23	new ExpressionFunction(
24	24	'service',
25		- function ($value) {
	25	+ function($value) {
26	26	return sprintf('$container->get(%s)', $value);
27	27	},
28		- function () {
	28	+ function() {
29	29	}
30	30	),
31	31
32	32	new ExpressionFunction(
33	33	'parameter',
34		- function ($value) {
	34	+ function($value) {
35	35	return sprintf('$container->getParameter(%s)', $value);
36	36	},
37		- function () {
	37	+ function() {
38	38	}
39	39	),
40	40
41	41	new ExpressionFunction(
42	42	'isTypeOf',
43		- function ($className) {
	43	+ function($className) {
44	44	return sprintf('($className = %s) && $value instanceof $className', $className);
45	45	},
46		- function () {
	46	+ function() {
47	47	}
48	48	),
49	49
50	50	new ExpressionFunction(
51	51	'resolver',
52		- function ($alias, $args = '[]') {
	52	+ function($alias, $args = '[]') {
53	53	return sprintf('$container->get(\'overblog_graphql.resolver_resolver\')->resolve([%s, %s])', $alias, $args);
54	54	},
55		- function () {
	55	+ function() {
56	56	}
57	57	),
58	58
59	59	new ExpressionFunction(
60	60	'mutateAndGetPayloadCallback',
61		- function ($mutateAndGetPayload) {
	61	+ function($mutateAndGetPayload) {
62	62	$code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
63	63	$code .= 'return '.$mutateAndGetPayload.'; }';
64	64
65	65	return $code;
66	66	},
67		- function () {
	67	+ function() {
68	68	}
69	69	),
70	70
71	71	new ExpressionFunction(
72	72	'mutateAndGetPayloadCallback',
73		- function ($mutateAndGetPayload) {
	73	+ function($mutateAndGetPayload) {
74	74	$code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
75	75	$code .= 'return '.$mutateAndGetPayload.'; }';
76	76
77	77	return $code;
78	78	},
79		- function () {
	79	+ function() {
80	80	}
81	81	),
82	82
83	83	new ExpressionFunction(
84	84	'idFetcherCallback',
85		- function ($idFetcher) {
	85	+ function($idFetcher) {
86	86	$code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
87	87	$code .= 'return '.$idFetcher.'; }';
88	88
89	89	return $code;
90	90	},
91		- function () {
	91	+ function() {
92	92	}
93	93	),
94	94
95	95	new ExpressionFunction(
96	96	'resolveSingleInputCallback',
97		- function ($resolveSingleInput) {
	97	+ function($resolveSingleInput) {
98	98	$code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
99	99	$code .= 'return '.$resolveSingleInput.'; }';
100	100
101	101	return $code;
102	102	},
103		- function () {
	103	+ function() {
104	104	}
105	105	),
106	106
107	107	new ExpressionFunction(
108	108	'mutation',
109		- function ($alias, $args = '[]') {
	109	+ function($alias, $args = '[]') {
110	110	return sprintf('$container->get(\'overblog_graphql.mutation_resolver\')->resolve([%s, %s])', $alias, $args);
111	111	},
112		- function () {
	112	+ function() {
113	113	}
114	114	),
115	115
116	116	new ExpressionFunction(
117	117	'globalId',
118		- function ($id, $typeName = null) {
	118	+ function($id, $typeName = null) {
119	119	$typeNameEmpty = null === $typeName \|\| '""' === $typeName \|\| 'null' === $typeName \|\| 'false' === $typeName;
120	120
121	121	return sprintf(
		@@ -124,28 +124,28 @@ discard block
		block discarded – undo
124	124	$id
125	125	);
126	126	},
127		- function () {
	127	+ function() {
128	128	}
129	129	),
130	130
131	131	new ExpressionFunction(
132	132	'fromGlobalId',
133		- function ($globalId) {
	133	+ function($globalId) {
134	134	return sprintf(
135	135	'\\Overblog\\GraphQLBundle\\Relay\\Node\\GlobalId::fromGlobalId(%s)',
136	136	$globalId
137	137	);
138	138	},
139		- function () {
	139	+ function() {
140	140	}
141	141	),
142	142
143	143	new ExpressionFunction(
144	144	'newObject',
145		- function ($className, $args = '[]') {
	145	+ function($className, $args = '[]') {
146	146	return sprintf('(new \ReflectionClass(%s))->newInstanceArgs(%s)', $className, $args);
147	147	},
148		- function () {
	148	+ function() {
149	149	}
150	150	),
151	151	];

		@@ -21,79 +21,79 @@
		block discarded – undo
21	21	return [
22	22	new ExpressionFunction(
23	23	'hasRole',
24		- function ($role) {
	24	+ function($role) {
25	25	return sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s)', $role);
26	26	},
27		- function () {
	27	+ function() {
28	28	}
29	29	),
30	30
31	31	new ExpressionFunction(
32	32	'hasAnyRole',
33		- function ($roles) {
	33	+ function($roles) {
34	34	$code = sprintf('array_reduce(%s, function ($isGranted, $role) use ($container) { return $isGranted \|\| $container->get(\'security.authorization_checker\')->isGranted($role); }, false)', $roles);
35	35
36	36	return $code;
37	37	},
38		- function () {
	38	+ function() {
39	39	}
40	40	),
41	41
42	42	new ExpressionFunction(
43	43	'isAnonymous',
44		- function () {
	44	+ function() {
45	45	return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_ANONYMOUSLY\')';
46	46	},
47		- function () {
	47	+ function() {
48	48	}
49	49	),
50	50
51	51	new ExpressionFunction(
52	52	'isRememberMe',
53		- function () {
	53	+ function() {
54	54	return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\')';
55	55	},
56		- function () {
	56	+ function() {
57	57	}
58	58	),
59	59
60	60	new ExpressionFunction(
61	61	'isFullyAuthenticated',
62		- function () {
	62	+ function() {
63	63	return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
64	64	},
65		- function () {
	65	+ function() {
66	66	}
67	67	),
68	68
69	69	new ExpressionFunction(
70	70	'isAuthenticated',
71		- function () {
	71	+ function() {
72	72	return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\') \|\| $container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
73	73	},
74		- function () {
	74	+ function() {
75	75	}
76	76	),
77	77
78	78	new ExpressionFunction(
79	79	'hasPermission',
80		- function ($object, $permission) {
	80	+ function($object, $permission) {
81	81	$code = sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s, %s)', $permission, $object);
82	82
83	83	return $code;
84	84	},
85		- function () {
	85	+ function() {
86	86	}
87	87	),
88	88
89	89	new ExpressionFunction(
90	90	'hasAnyPermission',
91		- function ($object, $permissions) {
	91	+ function($object, $permissions) {
92	92	$code = sprintf('array_reduce(%s, function ($isGranted, $permission) use ($container, $object) { return $isGranted \|\| $container->get(\'security.authorization_checker\')->isGranted($permission, %s); }, false)', $permissions, $object);
93	93
94	94	return $code;
95	95	},
96		- function () {
	96	+ function() {
97	97	}
98	98	),
99	99	];

Scrutinizer GitHub App not installed

Push — master ( 26279b...73877d )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines patch added patch discarded remove patch

Doc Comments +3 added lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +24 added lines, -24 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36	switch (true) {
37	37	case is_array($result):
38	38	$result = array_map(
39		- function ($object) use ($accessChecker, $resolveArgs) {
	39	+ function($object) use ($accessChecker, $resolveArgs) {
40	40	return $this->checkAccess($accessChecker, $object, $resolveArgs) ? $object : null;
41	41	},
42	42	$result
		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	break;
45	45	case $result instanceof Connection:
46	46	$result->edges = array_map(
47		- function (Edge $edge) use ($accessChecker, $resolveArgs) {
	47	+ function(Edge $edge) use ($accessChecker, $resolveArgs) {
48	48	$edge->node = $this->checkAccess($accessChecker, $edge->node, $resolveArgs) ? $edge->node : null;
49	49
50	50	return $edge;

		@@ -121,6 +121,9 @@
		block discarded – undo
121	121	return $node;
122	122	}
123	123
	124	+ /**
	125	+ * @param string $name
	126	+ */
124	127	private function addFieldsSelection($name, $enabledBuilder = true)
125	128	{
126	129	$builder = new TreeBuilder();

		@@ -60,7 +60,7 @@
		block discarded – undo
60	60	'fields' => [
61	61	'myField' => [
62	62	'type' => Type::boolean(),
63		- 'resolve' => function () {
	63	+ 'resolve' => function() {
64	64	return false;
65	65	},
66	66	],

		@@ -27,10 +27,10 @@
		block discarded – undo
27	27	->useAttributeAsKey('name')
28	28	->prototype('array')
29	29	->beforeNormalization()
30		- ->ifTrue(function ($v) {
	30	+ ->ifTrue(function($v) {
31	31	return !is_null($v) && !is_array($v);
32	32	})
33		- ->then(function ($v) {
	33	+ ->then(function($v) {
34	34	return ['value' => $v];
35	35	})
36	36	->end()

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Push — master ( 26279b...73877d )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines patch added patch discarded remove patch

Doc Comments +3 added lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +24 added lines, -24 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch