Argument - Code Metrics - Inspection of "Fix Access resolving when field value is false or..." - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Jérémiah

created 2016-03-10 14:41 UTC

Argument A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

32%

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	12
c	1
b	0
f	1
lcom	1
cbo	0
dl	0
loc	52
ccs	8
cts	25
cp	0.32
rs	10

9 Methods

Rating	Name	Size	Complexity
A	offsetExists()	4	1
A	offsetGet()	4	2
A	offsetSet()	4	1
A	offsetUnset()	4	1
A	__get()	4	1
A	__set()	4	1
A	getRawArguments()	4	1
A	count()	4	1
A	__construct()	7	3

<?php

/*
 * This file is part of the OverblogGraphQLBundle package.
 *
 * (c) Overblog <http://github.com/overblog/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Overblog\GraphQLBundle\Definition;

class Argument implements \ArrayAccess, \Countable
{
    private $arguments = [];

    public function __construct($arguments)
    {
        if (!is_array($arguments) && !$arguments instanceof \ArrayAccess) {
            $arguments = [$arguments];
        }
        $this->arguments = $arguments;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    public function offsetExists($offset)
    {
        return isset($this->arguments[$offset]);
    }

    public function offsetGet($offset)
    {
        return isset($this->arguments[$offset]) ? $this->arguments[$offset] : null;
    }

    public function offsetSet($offset, $value)
    {
        $this->arguments[$offset] = $value;
    }

    public function offsetUnset($offset)
    {
        unset($this->arguments[$offset]);
    }

    public function __get($key)
    {
        return $this->offsetGet($key);
    }

    public function __set($key, $value)
    {
        $this->offsetSet($key, $value);
    }

    public function getRawArguments()
    {
        return $this->arguments;
    }

    public function count()
    {
        return count($this->arguments);
    }
}


1		<?php
2
3		/*
4		* This file is part of the OverblogGraphQLBundle package.
5		*
6		* (c) Overblog <http://github.com/overblog/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Overblog\GraphQLBundle\Definition;
13
14		class Argument implements \ArrayAccess, \Countable
15		{
16		private $arguments = [];
17
18	23	public function __construct($arguments)
19		{
20	23	if (!is_array($arguments) && !$arguments instanceof \ArrayAccess) {
21	5	$arguments = [$arguments];
22	5	}
23	23	$this->arguments = $arguments;
		0 ignored issues – show Documentation Bug introduced 2016-03-07 13:30 UTC by Report Bug Copy Issue Report It seems like `$arguments` can also be of type `object<ArrayAccess>`. However, the property `$arguments` is declared as type `array`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
24	23	}
25
26		public function offsetExists($offset)
27		{
28		return isset($this->arguments[$offset]);
29		}
30
31		public function offsetGet($offset)
32		{
33		return isset($this->arguments[$offset]) ? $this->arguments[$offset] : null;
34		}
35
36		public function offsetSet($offset, $value)
37		{
38		$this->arguments[$offset] = $value;
39		}
40
41		public function offsetUnset($offset)
42		{
43		unset($this->arguments[$offset]);
44		}
45
46		public function __get($key)
47		{
48		return $this->offsetGet($key);
49		}
50
51		public function __set($key, $value)
52		{
53		$this->offsetSet($key, $value);
54		}
55
56	6	public function getRawArguments()
57		{
58	6	return $this->arguments;
59		}
60
61		public function count()
62		{
63		return count($this->arguments);
64		}
65		}
66

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#1)

Argument A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

Duplication Side-by-Side

Filter issues like