FieldsConfigSolution::resolveAccessAndWrapResolveCallback() - Code Metrics - Inspection of "Config resolver and some extra refactor" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

by Jérémiah

created 2016-03-16 14:28 UTC

resolveAccessAndWrapResolveCallback() C

↳ Parent: FieldsConfigSolution

Complexity

Conditions	10
Paths	1

Size

Total Lines	57
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	38
CRAP Score	10

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	57
ccs	38
cts	38
cp	1
rs	6.7123
cc	10
eloc	34
nc	1
nop	2
crap	10

How to fix Long Method Complexity

<?php

/*
 * This file is part of the OverblogGraphQLBundle package.
 *
 * (c) Overblog <http://github.com/overblog/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Overblog\GraphQLBundle\Resolver\Config;

use Overblog\GraphQLBundle\Error\UserError;
use Overblog\GraphQLBundle\Relay\Connection\Output\Connection;
use Overblog\GraphQLBundle\Relay\Connection\Output\Edge;
use Overblog\GraphQLBundle\Resolver\ResolverInterface;

class FieldsConfigSolution extends AbstractConfigSolution implements UniqueConfigSolutionInterface
{
    /**
     * @var TypeConfigSolution
     */
    private $typeConfigSolution;

    /**
     * @var ResolveCallbackConfigSolution
     */
    private $resolveCallbackConfigSolution;

    public function __construct(
        TypeConfigSolution $typeConfigSolution,
        ResolveCallbackConfigSolution $resolveCallbackConfigSolution
    ) {
        $this->typeConfigSolution = $typeConfigSolution;
        $this->resolveCallbackConfigSolution = $resolveCallbackConfigSolution;
    }

    public function solve($values, $config = null)

    {
        foreach ($values as $field => &$options) {
            if (isset($options['builder'])) {
                $builderConfig = isset($options['builderConfig']) ? $options['builderConfig'] : [];

                $access = isset($options['access']) ? $options['access'] : null;
                $options = $this->solveBuilder($options['builder'], $builderConfig, $this->fieldResolver, $field);
                $options['access'] = $access;
                $options = $this->resolveResolveAndAccessIfNeeded($options);

                unset($options['builderConfig'], $options['builder']);

                continue;
            }

            if (isset($options['type'])) {
                $options['type'] = $this->typeConfigSolution->solveTypeCallback($options['type']);
            }

            if (isset($options['args'])) {
                foreach ($options['args'] as &$argsOptions) {
                    $argsOptions['type'] = $this->typeConfigSolution->solveTypeCallback($argsOptions['type']);
                    if (isset($argsOptions['defaultValue'])) {
                        $argsOptions['defaultValue'] = $this->solveUsingExpressionLanguageIfNeeded($argsOptions['defaultValue']);
                    }
                }
            }

            if (isset($options['argsBuilder'])) {
                $argsBuilderConfig = isset($options['argsBuilder']['config']) ? $options['argsBuilder']['config'] : [];

                $options['args'] = array_merge(
                    $this->solveBuilder($options['argsBuilder']['builder'], $argsBuilderConfig, $this->argResolver),
                    isset($options['args']) ? $options['args'] : []
                );

                unset($options['argsBuilder']);
            }

            $options = $this->resolveResolveAndAccessIfNeeded($options);

            if (isset($options['deprecationReason'])) {
                $options['deprecationReason'] = $this->solveUsingExpressionLanguageIfNeeded($options['deprecationReason']);
            }
        }

        return $values;
    }

    private function solveBuilder($rawBuilder, array $rawBuilderConfig, ResolverInterface $builderResolver, $name = null)
    {
        $builder = is_callable($rawBuilder) ? $rawBuilder : $builderResolver->resolve($rawBuilder);
        $builderConfig = [];
        if (!empty($rawBuilderConfig)) {
            $builderConfig = $rawBuilderConfig;

            if (!is_array($builderConfig)) {
                $builderConfig = [$builderConfig];
            }
            $builderConfig = $this->configResolver->resolve($builderConfig);
        }

        if (null !== $name) {
            $builderConfig['name'] = $name;
        }

        return call_user_func_array([$builder, 'toMappingDefinition'], [$builderConfig]);
    }

    private function resolveResolveAndAccessIfNeeded(array $options)
    {
        $treatedOptions = $options;

        if (isset($treatedOptions['resolve'])) {
            $treatedOptions['resolve'] = $this->resolveCallbackConfigSolution->solve($treatedOptions['resolve']);
        }

        if (isset($treatedOptions['access'])) {
            $resolveCallback = $this->configResolver->getDefaultResolveFn();

            if (isset($treatedOptions['resolve'])) {
                $resolveCallback = $treatedOptions['resolve'];
            }

            $treatedOptions['resolve'] = $this->resolveAccessAndWrapResolveCallback($treatedOptions['access'], $resolveCallback);
        }
        unset($treatedOptions['access']);

        return $treatedOptions;
    }

    private function resolveAccessAndWrapResolveCallback($expression, callable $resolveCallback = null)
    {
        return function () use ($expression, $resolveCallback) {
            $args = func_get_args();

            $result = null !== $resolveCallback  ? call_user_func_array($resolveCallback, $args) : null;

            $values = call_user_func_array([$this, 'solveResolveCallbackArgs'], $args);

            $checkAccess = function ($object, $throwException = false) use ($expression, $values) {
                try {
                    $access = $this->solveUsingExpressionLanguageIfNeeded(
                        $expression,
                        array_merge($values, ['object' => $object])
                    );
                } catch (\Exception $e) {
                    $access = false;
                }

                if ($throwException && !$access) {
                    throw new UserError('Access denied to this field.');
                }

                return $access;
            };

            switch (true) {
                case is_array($result) || $result instanceof \ArrayAccess:
                    $result = array_filter(
                        array_map(
                            function ($object) use ($checkAccess) {
                                return $checkAccess($object) ? $object : null;
                            },
                            $result
                        )
                    );
                    break;

                case $result instanceof Connection:
                    $result->edges = array_map(
                        function (Edge $edge) use ($checkAccess) {
                            $edge->node = $checkAccess($edge->node) ? $edge->node : null;

                            return $edge;
                        },
                        $result->edges
                    );
                    break;

                default:
                    $checkAccess($result, true);
                    break;
            }

            return $result;
        };
    }
}


1		<?php
2
3		/*
4		* This file is part of the OverblogGraphQLBundle package.
5		*
6		* (c) Overblog <http://github.com/overblog/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Overblog\GraphQLBundle\Resolver\Config;
13
14		use Overblog\GraphQLBundle\Error\UserError;
15		use Overblog\GraphQLBundle\Relay\Connection\Output\Connection;
16		use Overblog\GraphQLBundle\Relay\Connection\Output\Edge;
17		use Overblog\GraphQLBundle\Resolver\ResolverInterface;
18
19		class FieldsConfigSolution extends AbstractConfigSolution implements UniqueConfigSolutionInterface
20		{
21		/**
22		* @var TypeConfigSolution
23		*/
24		private $typeConfigSolution;
25
26		/**
27		* @var ResolveCallbackConfigSolution
28		*/
29		private $resolveCallbackConfigSolution;
30
31	31	public function __construct(
32		TypeConfigSolution $typeConfigSolution,
33		ResolveCallbackConfigSolution $resolveCallbackConfigSolution
34		) {
35	31	$this->typeConfigSolution = $typeConfigSolution;
36	31	$this->resolveCallbackConfigSolution = $resolveCallbackConfigSolution;
37	31	}
38
39	26	public function solve($values, $config = null)
		0 ignored issues – show Unused Code introduced 2016-03-16 14:37 UTC by Report Bug Copy Issue Report The parameter `$config` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
40		{
41	26	foreach ($values as $field => &$options) {
42	26	if (isset($options['builder'])) {
43	19	$builderConfig = isset($options['builderConfig']) ? $options['builderConfig'] : [];
44
45	19	$access = isset($options['access']) ? $options['access'] : null;
46	19	$options = $this->solveBuilder($options['builder'], $builderConfig, $this->fieldResolver, $field);
47	19	$options['access'] = $access;
48	19	$options = $this->resolveResolveAndAccessIfNeeded($options);
49
50	19	unset($options['builderConfig'], $options['builder']);
51
52	19	continue;
53		}
54
55	26	if (isset($options['type'])) {
56	26	$options['type'] = $this->typeConfigSolution->solveTypeCallback($options['type']);
57	26	}
58
59	26	if (isset($options['args'])) {
60		foreach ($options['args'] as &$argsOptions) {
61		$argsOptions['type'] = $this->typeConfigSolution->solveTypeCallback($argsOptions['type']);
62		if (isset($argsOptions['defaultValue'])) {
63		$argsOptions['defaultValue'] = $this->solveUsingExpressionLanguageIfNeeded($argsOptions['defaultValue']);
64		}
65		}
66		}
67
68	26	if (isset($options['argsBuilder'])) {
69	7	$argsBuilderConfig = isset($options['argsBuilder']['config']) ? $options['argsBuilder']['config'] : [];
70
71	7	$options['args'] = array_merge(
72	7	$this->solveBuilder($options['argsBuilder']['builder'], $argsBuilderConfig, $this->argResolver),
73	7	isset($options['args']) ? $options['args'] : []
74	7	);
75
76	7	unset($options['argsBuilder']);
77	7	}
78
79	26	$options = $this->resolveResolveAndAccessIfNeeded($options);
80
81	26	if (isset($options['deprecationReason'])) {
82		$options['deprecationReason'] = $this->solveUsingExpressionLanguageIfNeeded($options['deprecationReason']);
83		}
84	26	}
85
86	26	return $values;
87		}
88
89	26	private function solveBuilder($rawBuilder, array $rawBuilderConfig, ResolverInterface $builderResolver, $name = null)
90		{
91	26	$builder = is_callable($rawBuilder) ? $rawBuilder : $builderResolver->resolve($rawBuilder);
92	26	$builderConfig = [];
93	26	if (!empty($rawBuilderConfig)) {
94	19	$builderConfig = $rawBuilderConfig;
95
96	19	if (!is_array($builderConfig)) {
97		$builderConfig = [$builderConfig];
98		}
99	19	$builderConfig = $this->configResolver->resolve($builderConfig);
100	19	}
101
102	26	if (null !== $name) {
103	19	$builderConfig['name'] = $name;
104	19	}
105
106	26	return call_user_func_array([$builder, 'toMappingDefinition'], [$builderConfig]);
107		}
108
109	26	private function resolveResolveAndAccessIfNeeded(array $options)
110		{
111	26	$treatedOptions = $options;
112
113	26	if (isset($treatedOptions['resolve'])) {
114	26	$treatedOptions['resolve'] = $this->resolveCallbackConfigSolution->solve($treatedOptions['resolve']);
115	26	}
116
117	26	if (isset($treatedOptions['access'])) {
118		$resolveCallback = $this->configResolver->getDefaultResolveFn();
119
120		if (isset($treatedOptions['resolve'])) {
121		$resolveCallback = $treatedOptions['resolve'];
122		}
123
124		$treatedOptions['resolve'] = $this->resolveAccessAndWrapResolveCallback($treatedOptions['access'], $resolveCallback);
125		}
126	26	unset($treatedOptions['access']);
127
128	26	return $treatedOptions;
129		}
130
131	5	private function resolveAccessAndWrapResolveCallback($expression, callable $resolveCallback = null)
132		{
133		return function () use ($expression, $resolveCallback) {
134	5	$args = func_get_args();
135
136	5	$result = null !== $resolveCallback ? call_user_func_array($resolveCallback, $args) : null;
137
138	5	$values = call_user_func_array([$this, 'solveResolveCallbackArgs'], $args);
139
140		$checkAccess = function ($object, $throwException = false) use ($expression, $values) {
141		try {
142	5	$access = $this->solveUsingExpressionLanguageIfNeeded(
143	5	$expression,
144	5	array_merge($values, ['object' => $object])
145	5	);
146	5	} catch (\Exception $e) {
147	1	$access = false;
148		}
149
150	5	if ($throwException && !$access) {
151	2	throw new UserError('Access denied to this field.');
152		}
153
154	3	return $access;
155	5	};
156
157	5	switch (true) {
158	5	case is_array($result) \|\| $result instanceof \ArrayAccess:
159	1	$result = array_filter(
160	1	array_map(
161		function ($object) use ($checkAccess) {
162	1	return $checkAccess($object) ? $object : null;
163	1	},
164		$result
165	1	)
166	1	);
167	1	break;
168
169	4	case $result instanceof Connection:
170	1	$result->edges = array_map(
171	1	function (Edge $edge) use ($checkAccess) {
172	1	$edge->node = $checkAccess($edge->node) ? $edge->node : null;
173
174	1	return $edge;
175	1	},
176	1	$result->edges
177	1	);
178	1	break;
179
180	3	default:
181	3	$checkAccess($result, true);
182	1	break;
183	3	}
184
185	3	return $result;
186	5	};
187		}
188		}
189

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#7)

resolveAccessAndWrapResolveCallback() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like