overblog / GraphQLBundle

Relay/Node/GlobalIdField.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
             'name' => $name,
             'description' => 'The ID of an object',
             'type' => Type::nonNull(Type::id()),
-            'resolve' => function ($obj, $args, ResolveInfo $info) use ($idFetcher, $typeName) {
+            'resolve' => function($obj, $args, ResolveInfo $info) use ($idFetcher, $typeName) {
                 return GlobalId::toGlobalId(
                     !empty($typeName) ? $typeName : $info->parentType->name,
                     is_callable($idFetcher) ? call_user_func_array($idFetcher, [$obj, $info]) : (is_object($obj) ? $obj->id : $obj['id'])

Relay/Node/RawIdField.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
             'name' => $name,
             'description' => 'The raw ID of an object',
             'type' => Type::nonNull(Type::int()),
-            'resolve' => function ($obj, $args, ResolveInfo $info) use ($idFetcher) {
+            'resolve' => function($obj, $args, ResolveInfo $info) use ($idFetcher) {
                 return is_callable($idFetcher) ? $idFetcher($obj, $info) : $obj->id;
             },
         ];

Tests/DIContainerMockTrait.php

Doc Comments +3 added lines

@@ -13,6 +13,9 @@
 
 trait DIContainerMockTrait
 {
+    /**
+     * @return null|\Symfony\Component\DependencyInjection\ContainerInterface
+     */
     private function getDIContainerMock(array $services = [], array $parameters = [])
     {
         $container = $this->getMock('Symfony\\Component\\DependencyInjection\\Container', ['get', 'getParameter', 'has']);

ExpressionLanguage/ConfigExpressionProvider.php

Spacing +8 added lines, -8 removed lines

@@ -20,37 +20,37 @@
     public function getFunctions()
     {
         return [
-            new ExpressionFunction('service', function () {}, function (array $variables, $value) {
+            new ExpressionFunction('service', function() {}, function(array $variables, $value) {
                 return $variables['container']->get($value);
             }),
 
-            new ExpressionFunction('parameter', function () {}, function (array $variables, $value) {
+            new ExpressionFunction('parameter', function() {}, function(array $variables, $value) {
                 return $variables['container']->getParameter($value);
             }),
 
-            new ExpressionFunction('isTypeOf', function () {}, function (array $variables, $className) {
+            new ExpressionFunction('isTypeOf', function() {}, function(array $variables, $className) {
                 return $variables['value'] instanceof $className;
             }),
 
-            new ExpressionFunction('resolver', function () {}, function (array $variables, $alias, array $args = []) {
+            new ExpressionFunction('resolver', function() {}, function(array $variables, $alias, array $args = []) {
                 return $variables['container']->get('overblog_graphql.resolver_resolver')->resolve([$alias, $args]);
             }),
 
-            new ExpressionFunction('mutation', function () {}, function (array $variables, $alias, array $args = []) {
+            new ExpressionFunction('mutation', function() {}, function(array $variables, $alias, array $args = []) {
                 return $variables['container']->get('overblog_graphql.mutation_resolver')->resolve([$alias, $args]);
             }),
 
-            new ExpressionFunction('globalId', function () {}, function (array $variables, $id, $typeName = null) {
+            new ExpressionFunction('globalId', function() {}, function(array $variables, $id, $typeName = null) {
                 $type = !empty($typeName) ? $typeName : $variables['info']->parentType->name;
 
                 return GlobalId::toGlobalId($type, $id);
             }),
 
-            new ExpressionFunction('fromGlobalId', function () {}, function (array $variables, $globalId) {
+            new ExpressionFunction('fromGlobalId', function() {}, function(array $variables, $globalId) {
                 return GlobalId::fromGlobalId($globalId);
             }),
 
-            new ExpressionFunction('newObject', function () {}, function (array $variables, $className, array $args = []) {
+            new ExpressionFunction('newObject', function() {}, function(array $variables, $className, array $args = []) {
                 return (new \ReflectionClass($className))->newInstanceArgs($args);
             }),
         ];

ExpressionLanguage/AuthorizationExpressionProvider.php

Spacing +8 added lines, -8 removed lines

@@ -19,11 +19,11 @@ 
     public function getFunctions()
     {
         return [
-            new ExpressionFunction('hasRole', function () {}, function (array $variables, $role) {
+            new ExpressionFunction('hasRole', function() {}, function(array $variables, $role) {
                 return $variables['container']->get('security.authorization_checker')->isGranted($role);
             }),
 
-            new ExpressionFunction('hasAnyRole', function () {}, function (array $variables, array $roles) {
+            new ExpressionFunction('hasAnyRole', function() {}, function(array $variables, array $roles) {
                 foreach ($roles as $role) {
                     if ($variables['container']->get('security.authorization_checker')->isGranted($role)) {
                         return true;
@@ -33,29 +33,29 @@ 
                 return false;
             }),
 
-            new ExpressionFunction('isAnonymous', function () {}, function (array $variables) {
+            new ExpressionFunction('isAnonymous', function() {}, function(array $variables) {
                 return $variables['container']->get('security.authorization_checker')->isGranted('IS_AUTHENTICATED_ANONYMOUSLY');
             }),
 
-            new ExpressionFunction('isRememberMe', function () {}, function (array $variables) {
+            new ExpressionFunction('isRememberMe', function() {}, function(array $variables) {
                 return $variables['container']->get('security.authorization_checker')->isGranted('IS_AUTHENTICATED_REMEMBERED');
             }),
 
-            new ExpressionFunction('isFullyAuthenticated', function () {}, function (array $variables) {
+            new ExpressionFunction('isFullyAuthenticated', function() {}, function(array $variables) {
                 return $variables['container']->get('security.authorization_checker')->isGranted('IS_AUTHENTICATED_FULLY');
             }),
 
-            new ExpressionFunction('isAuthenticated', function () {}, function (array $variables) {
+            new ExpressionFunction('isAuthenticated', function() {}, function(array $variables) {
                 return
                     $variables['container']->get('security.authorization_checker')->isGranted('IS_AUTHENTICATED_REMEMBERED')
                     || $variables['container']->get('security.authorization_checker')->isGranted('IS_AUTHENTICATED_FULLY');
             }),
 
-            new ExpressionFunction('hasPermission', function () {}, function (array $variables, $object, $permission) {
+            new ExpressionFunction('hasPermission', function() {}, function(array $variables, $object, $permission) {
                 return $variables['container']->get('security.authorization_checker')->isGranted($permission, $object);
             }),
 
-            new ExpressionFunction('hasAnyPermission', function () {}, function (array $variables, $object, array $permissions) {
+            new ExpressionFunction('hasAnyPermission', function() {}, function(array $variables, $object, array $permissions) {
                 foreach ($permissions as $permission) {
                     if ($variables['container']->get('security.authorization_checker')->isGranted($permission, $object)) {
                         return true;

Resolver/ConfigResolver.php

Doc Comments +11 added lines

@@ -247,6 +247,9 @@ 
         return $type;
     }
 
+    /**
+     * @param callable $expression
+     */
     private function resolveAccessAndWrapResolveCallback($expression, callable $resolveCallback = null)
     {
         return function () use ($expression, $resolveCallback) {
@@ -277,6 +280,10 @@ 
                 case is_array($result) || $result instanceof \ArrayAccess:
                     $result = array_filter(
                         array_map(
+
+                            /**
+                             * @param callable $object
+                             */
                             function ($object) use ($checkAccess) {
                                 return $checkAccess($object) ? $object : null;
                             },
@@ -287,6 +294,10 @@ 
 
                 case $result instanceof Connection:
                     $result->edges = array_map(
+
+                        /**
+                         * @param callable $edge
+                         */
                         function (Edge $edge) use ($checkAccess) {
                             $edge->node = $checkAccess($edge->node) ? $edge->node : null;
 

Spacing +8 added lines, -8 removed lines

@@ -213,7 +213,7 @@ 
 
     private function resolveTypeCallback($expr)
     {
-        return function () use ($expr) {
+        return function() use ($expr) {
             return $this->resolveType($expr);
         };
     }
@@ -249,14 +249,14 @@ 
 
     private function resolveAccessAndWrapResolveCallback($expression, callable $resolveCallback = null)
     {
-        return function () use ($expression, $resolveCallback) {
+        return function() use ($expression, $resolveCallback) {
             $args = func_get_args();
 
-            $result = null !== $resolveCallback  ? call_user_func_array($resolveCallback, $args) : null;
+            $result = null !== $resolveCallback ? call_user_func_array($resolveCallback, $args) : null;
 
             $values = call_user_func_array([$this, 'resolveResolveCallbackArgs'], $args);
 
-            $checkAccess = function ($object, $throwException = false) use ($expression, $values) {
+            $checkAccess = function($object, $throwException = false) use ($expression, $values) {
                 try {
                     $access = $this->resolveUsingExpressionLanguageIfNeeded(
                         $expression,
@@ -277,7 +277,7 @@ 
                 case is_array($result) || $result instanceof \ArrayAccess:
                     $result = array_filter(
                         array_map(
-                            function ($object) use ($checkAccess) {
+                            function($object) use ($checkAccess) {
                                 return $checkAccess($object) ? $object : null;
                             },
                             $result
@@ -287,7 +287,7 @@ 
 
                 case $result instanceof Connection:
                     $result->edges = array_map(
-                        function (Edge $edge) use ($checkAccess) {
+                        function(Edge $edge) use ($checkAccess) {
                             $edge->node = $checkAccess($edge->node) ? $edge->node : null;
 
                             return $edge;
@@ -311,7 +311,7 @@ 
             return $value;
         }
 
-        return function () use ($value) {
+        return function() use ($value) {
             $args = func_get_args();
             $result = $this->resolveUsingExpressionLanguageIfNeeded(
                 $value,
@@ -360,7 +360,7 @@ 
 
     private function resolveUsingExpressionLanguageIfNeeded($expression, array $values = [])
     {
-        if (is_string($expression) &&  0 === strpos($expression, '@=')) {
+        if (is_string($expression) && 0 === strpos($expression, '@=')) {
             return $this->expressionLanguage->evaluate(substr($expression, 2), $values);
         }
 

Tests/Resolver/ConfigResolverTest.php

Spacing +1 added lines, -1 removed lines

@@ -163,7 +163,7 @@
     private function invokeResolveAccessAndWrapResolveCallback($hasAccess, callable $callback = null)
     {
         if (null === $callback) {
-            $callback = function ($value) {
+            $callback = function($value) {
                 return $value;
             };
         }

Doc Comments +1 added lines, -1 removed lines

@@ -183,7 +183,7 @@
      *
      * @see https://jtreminio.com/2013/03/unit-testing-tutorial-part-3-testing-protected-private-methods-coverage-reports-and-crap/
      *
-     * @param object $object     Instantiated object that we will run method on.
+     * @param ConfigResolver $object     Instantiated object that we will run method on.
      * @param string $methodName Method name to call
      * @param array  $parameters Array of parameters to pass into method.
      *

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use Overblog\GraphQLBundle\Relay\Connection\Output\ConnectionBuilder;
 use Overblog\GraphQLBundle\Resolver\ConfigResolver;
 use Overblog\GraphQLBundle\Tests\DIContainerMockTrait;
-use Symfony\Component\ExpressionLanguage\Expression;
 
 class ConfigResolverTest extends \PHPUnit_Framework_TestCase
 {

Resolver/Resolver.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
             } else if (is_object($source)) {
                 $property = $accessor->getValue($source, sprintf('%s', $fieldName));
             }
-        } catch(AccessException $e) {
+        } catch (AccessException $e) {
         }
 
         return $property instanceof \Closure ? $property($source) : $property;

Tests/Resolver/ResolverTest.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
 
     public function setUp()
     {
-        $this->closureProperty = function () {
+        $this->closureProperty = function() {
             return $this->privatePropertyWithoutGetter;
         };
     }