ArgumentsTransformer::populateObject() - Code Metrics - Inspection of "Always pass arguments from expression function" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#643)

by Stepan

created 2020-01-21 20:54 UTC

ArgumentsTransformer::populateObject() C

↳ Parent: ArgumentsTransformer

Complexity

Conditions	13
Paths	22

Size

Total Lines	57
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	30
CRAP Score	13.0412

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
eloc	34
c	2
b	1
f	0
dl	0
loc	57
ccs	30
cts	32
cp	0.9375
rs	6.6166
cc	13
nc	22
nop	4
crap	13.0412

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace Overblog\GraphQLBundle\Transformer;

use GraphQL\Type\Definition\EnumType;
use GraphQL\Type\Definition\InputObjectType;
use GraphQL\Type\Definition\ListOfType;
use GraphQL\Type\Definition\NonNull;
use GraphQL\Type\Definition\ResolveInfo;
use GraphQL\Type\Definition\Type;
use Overblog\GraphQLBundle\Error\InvalidArgumentError;
use Overblog\GraphQLBundle\Error\InvalidArgumentsError;
use Symfony\Component\PropertyAccess\PropertyAccess;
use Symfony\Component\PropertyAccess\PropertyAccessor;
use Symfony\Component\Validator\ConstraintViolationList;
use Symfony\Component\Validator\Validator\ValidatorInterface;

class ArgumentsTransformer
{
    /**
     * @var ValidatorInterface
     */
    protected $validator;

    /**
     * @var array
     */
    protected $classesMap;

    /**
     * @var PropertyAccessor
     */
    protected $accessor;

    public function __construct(ValidatorInterface $validator = null, $classesMap = [])
    {
        $this->validator = $validator;
        $this->accessor = PropertyAccess::createPropertyAccessor();
        $this->classesMap = $classesMap;
    }

    /**
     * Get the PHP class for a given type.
     *
     * @param string $type
     *
     * @return object|false
     */
    private function getTypeClassInstance(string $type)
    {
        $classname = isset($this->classesMap[$type]) ? $this->classesMap[$type]['class'] : false;

        return $classname ? new $classname() : false;
    }

    /**
     * Extract given type from Resolve Info.
     *
     * @param string      $type
     * @param ResolveInfo $info
     *
     * @return Type
     */
    private function getType(string $type, ResolveInfo $info): Type
    {
        return $info->schema->getType($type);
    }

    /**
     * Populate an object based on type with given data.
     *
     * @param Type        $type
     * @param mixed       $data
     * @param bool        $multiple
     * @param ResolveInfo $info
     *
     * @return mixed
     */
    private function populateObject(Type $type, $data, bool $multiple, ResolveInfo $info)
    {
        if (null === $data) {
            if ($type instanceof InputObjectType) {
                return $this->getTypeClassInstance($type->name) ?: null;
            }
            return $data;
        }

        if ($type instanceof NonNull) {
            $type = $type->getWrappedType();
        }

        if ($multiple) {
            return \array_map(function ($data) use ($type, $info) {
                return $this->populateObject($type, $data, false, $info);
            }, $data);
        }

        if ($type instanceof EnumType) {
            $instance = $this->getTypeClassInstance($type->name);
            if ($instance) {
                $this->accessor->setValue($instance, 'value', $data);

                return $instance;
            } else {
                return $data;
            }
        } elseif ($type instanceof InputObjectType) {
            $instance = $this->getTypeClassInstance($type->name);
            if (!$instance) {
                return $data;
            }

            $fields = $type->getFields();

            foreach ($fields as $name => $field) {
                $fieldData = $this->accessor->getValue($data, \sprintf('[%s]', $name));
                $fieldType = $field->getType();

                if ($fieldType instanceof NonNull) {
                    $fieldType = $fieldType->getWrappedType();
                }

                if ($fieldType instanceof ListOfType) {
                    $fieldValue = $this->populateObject($fieldType->getWrappedType(), $fieldData, true, $info);
                } else {
                    $fieldValue = $this->populateObject($fieldType, $fieldData, false, $info);
                }

                $this->accessor->setValue($instance, $name, $fieldValue);
            }

            return $instance;
        }

        return $data;
    }

    /**
     * Given a GraphQL type and an array of data, populate corresponding object recursively
     * using annoted classes.
     *
     * @param string      $argType
     * @param mixed       $data
     * @param ResolveInfo $info
     *
     * @return mixed
     */
    public function getInstanceAndValidate(string $argType, $data, ResolveInfo $info, string $argName)
    {
        $isRequired = '!' === $argType[\strlen($argType) - 1];
        $isMultiple = '[' === $argType[0];
        $endIndex = ($isRequired ? 1 : 0) + ($isMultiple ? 1 : 0);
        $type = \substr($argType, $isMultiple ? 1 : 0, $endIndex > 0 ? -$endIndex : \strlen($argType));

        $result = $this->populateObject($this->getType($type, $info), $data, $isMultiple, $info);
        $errors = new ConstraintViolationList();
        if ($this->validator) {
            if (\is_object($result)) {
                $errors = $this->validator->validate($result);
            }
            if (\is_array($result) && $isMultiple) {
                foreach ($result as $element) {
                    if (\is_object($element)) {
                        $errors->addAll(
                            $this->validator->validate($element)
                        );
                    }
                }
            }
        }

        if (\count($errors) > 0) {
            throw new InvalidArgumentError($argName, $errors);
        }

        return $result;
    }

    /**
     * Transform a list of arguments into their corresponding php class and validate them.
     *
     * @param array       $mapping
     * @param mixed       $data
     * @param ResolveInfo $info
     *
     * @return array
     */
    public function getArguments(array $mapping, $data, ResolveInfo $info)
    {
        $args = [];
        $exceptions = [];

        foreach ($mapping as $name => $type) {
            try {
                $value = $this->getInstanceAndValidate($type, $data[$name], $info, $name);
                $args[] = $value;
            } catch (InvalidArgumentError $exception) {
                $exceptions[] = $exception;
            }
        }

        if (!empty($exceptions)) {
            throw new InvalidArgumentsError($exceptions);
        }

        return $args;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Overblog\GraphQLBundle\Transformer;
6
7		use GraphQL\Type\Definition\EnumType;
8		use GraphQL\Type\Definition\InputObjectType;
9		use GraphQL\Type\Definition\ListOfType;
10		use GraphQL\Type\Definition\NonNull;
11		use GraphQL\Type\Definition\ResolveInfo;
12		use GraphQL\Type\Definition\Type;
13		use Overblog\GraphQLBundle\Error\InvalidArgumentError;
14		use Overblog\GraphQLBundle\Error\InvalidArgumentsError;
15		use Symfony\Component\PropertyAccess\PropertyAccess;
16		use Symfony\Component\PropertyAccess\PropertyAccessor;
17		use Symfony\Component\Validator\ConstraintViolationList;
18		use Symfony\Component\Validator\Validator\ValidatorInterface;
19
20		class ArgumentsTransformer
21		{
22		/**
23		* @var ValidatorInterface
24		*/
25		protected $validator;
26
27		/**
28		* @var array
29		*/
30		protected $classesMap;
31
32		/**
33		* @var PropertyAccessor
34		*/
35		protected $accessor;
36
37	147	public function __construct(ValidatorInterface $validator = null, $classesMap = [])
38		{
39	147	$this->validator = $validator;
40	147	$this->accessor = PropertyAccess::createPropertyAccessor();
41	147	$this->classesMap = $classesMap;
42	147	}
43
44		/**
45		* Get the PHP class for a given type.
46		*
47		* @param string $type
48		*
49		* @return object\|false
50		*/
51	4	private function getTypeClassInstance(string $type)
52		{
53	4	$classname = isset($this->classesMap[$type]) ? $this->classesMap[$type]['class'] : false;
54
55	4	return $classname ? new $classname() : false;
56		}
57
58		/**
59		* Extract given type from Resolve Info.
60		*
61		* @param string $type
62		* @param ResolveInfo $info
63		*
64		* @return Type
65		*/
66	4	private function getType(string $type, ResolveInfo $info): Type
67		{
68	4	return $info->schema->getType($type);
69		}
70
71		/**
72		* Populate an object based on type with given data.
73		*
74		* @param Type $type
75		* @param mixed $data
76		* @param bool $multiple
77		* @param ResolveInfo $info
78		*
79		* @return mixed
80		*/
81	4	private function populateObject(Type $type, $data, bool $multiple, ResolveInfo $info)
82		{
83	4	if (null === $data) {
84	4	if ($type instanceof InputObjectType) {
85	2	return $this->getTypeClassInstance($type->name) ?: null;
86		}
87	4	return $data;
88		}
89
90	4	if ($type instanceof NonNull) {
91		$type = $type->getWrappedType();
92		}
93
94	4	if ($multiple) {
95		return \array_map(function ($data) use ($type, $info) {
96	4	return $this->populateObject($type, $data, false, $info);
97	4	}, $data);
98		}
99
100	4	if ($type instanceof EnumType) {
101	4	$instance = $this->getTypeClassInstance($type->name);
102	4	if ($instance) {
103	2	$this->accessor->setValue($instance, 'value', $data);
104
105	2	return $instance;
106		} else {
107	3	return $data;
108		}
109	4	} elseif ($type instanceof InputObjectType) {
110	4	$instance = $this->getTypeClassInstance($type->name);
111	4	if (!$instance) {
112		return $data;
113		}
114
115	4	$fields = $type->getFields();
116
117	4	foreach ($fields as $name => $field) {
118	4	$fieldData = $this->accessor->getValue($data, \sprintf('[%s]', $name));
119	4	$fieldType = $field->getType();
120
121	4	if ($fieldType instanceof NonNull) {
122	4	$fieldType = $fieldType->getWrappedType();
123		}
124
125	4	if ($fieldType instanceof ListOfType) {
126	4	$fieldValue = $this->populateObject($fieldType->getWrappedType(), $fieldData, true, $info);
127		} else {
128	4	$fieldValue = $this->populateObject($fieldType, $fieldData, false, $info);
129		}
130
131	4	$this->accessor->setValue($instance, $name, $fieldValue);
132		}
133
134	4	return $instance;
135		}
136
137	4	return $data;
138		}
139
140		/**
141		* Given a GraphQL type and an array of data, populate corresponding object recursively
142		* using annoted classes.
143		*
144		* @param string $argType
145		* @param mixed $data
146		* @param ResolveInfo $info
147		*
148		* @return mixed
149		*/
150	4	public function getInstanceAndValidate(string $argType, $data, ResolveInfo $info, string $argName)
151		{
152	4	$isRequired = '!' === $argType[\strlen($argType) - 1];
153	4	$isMultiple = '[' === $argType[0];
154	4	$endIndex = ($isRequired ? 1 : 0) + ($isMultiple ? 1 : 0);
155	4	$type = \substr($argType, $isMultiple ? 1 : 0, $endIndex > 0 ? -$endIndex : \strlen($argType));
156
157	4	$result = $this->populateObject($this->getType($type, $info), $data, $isMultiple, $info);
158	4	$errors = new ConstraintViolationList();
159	4	if ($this->validator) {
160	4	if (\is_object($result)) {
161	3	$errors = $this->validator->validate($result);
162		}
163	4	if (\is_array($result) && $isMultiple) {
164	1	foreach ($result as $element) {
165	1	if (\is_object($element)) {
166	1	$errors->addAll(
167	1	$this->validator->validate($element)
168		);
169		}
170		}
171		}
172		}
173
174	4	if (\count($errors) > 0) {
175	2	throw new InvalidArgumentError($argName, $errors);
176		}
177
178	2	return $result;
179		}
180
181		/**
182		* Transform a list of arguments into their corresponding php class and validate them.
183		*
184		* @param array $mapping
185		* @param mixed $data
186		* @param ResolveInfo $info
187		*
188		* @return array
189		*/
190	4	public function getArguments(array $mapping, $data, ResolveInfo $info)
191		{
192	4	$args = [];
193	4	$exceptions = [];
194
195	4	foreach ($mapping as $name => $type) {
196		try {
197	4	$value = $this->getInstanceAndValidate($type, $data[$name], $info, $name);
198	2	$args[] = $value;
199	2	} catch (InvalidArgumentError $exception) {
200	2	$exceptions[] = $exception;
201		}
202		}
203
204	4	if (!empty($exceptions)) {
205	2	throw new InvalidArgumentsError($exceptions);
206		}
207
208	2	return $args;
209		}
210		}
211

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#643)

ArgumentsTransformer::populateObject() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like