FieldResolver::valueFromObjectOrArray() - Code Metrics - Inspection of "Improve default field resolver performance" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#563)

by Jérémiah

created 2019-09-30 07:05 UTC

FieldResolver::valueFromObjectOrArray() A

↳ Parent: FieldResolver

Complexity

Conditions	6
Paths	5

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	6

Importance

Changes

Metric	Value
eloc	9
dl	0
loc	14
ccs	10
cts	10
cp	1
rs	9.2222
c	0
b	0
f	0
cc	6
nc	5
nop	2
crap	6

<?php

declare(strict_types=1);

namespace Overblog\GraphQLBundle\Resolver;

use GraphQL\Type\Definition\ResolveInfo;

class FieldResolver
{
    public function __invoke($parentValue, $args, $context, ResolveInfo $info)
    {
        $fieldName = $info->fieldName;
        $value = self::valueFromObjectOrArray($parentValue, $fieldName);

        return $value instanceof \Closure ? $value($parentValue, $args, $context, $info) : $value;
    }

    public static function valueFromObjectOrArray($objectOrArray, $fieldName)
    {
        $value = null;
        if (\is_array($objectOrArray) && isset($objectOrArray[$fieldName])) {
            $value = $objectOrArray[$fieldName];
        } elseif (\is_object($objectOrArray)) {
            if (null !== $getter = self::guessObjectMethod($objectOrArray, $fieldName, 'get')) {
                $value = $objectOrArray->$getter();
            } elseif (isset($objectOrArray->$fieldName)) {
                $value = $objectOrArray->$fieldName;
            }
        }

        return $value;
    }

    private static function guessObjectMethod($object, string $fieldName, string $prefix): ?string
    {
        if (\is_callable([$object, $method = $prefix.\str_replace(' ', '', \ucwords(\str_replace('_', ' ', $fieldName)))])) {
            return $method;
        }

        return null;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Overblog\GraphQLBundle\Resolver;
6
7		use GraphQL\Type\Definition\ResolveInfo;
8
9		class FieldResolver
10		{
11	42	public function __invoke($parentValue, $args, $context, ResolveInfo $info)
12		{
13	42	$fieldName = $info->fieldName;
14	42	$value = self::valueFromObjectOrArray($parentValue, $fieldName);
15
16	42	return $value instanceof \Closure ? $value($parentValue, $args, $context, $info) : $value;
17		}
18
19	43	public static function valueFromObjectOrArray($objectOrArray, $fieldName)
20		{
21	43	$value = null;
22	43	if (\is_array($objectOrArray) && isset($objectOrArray[$fieldName])) {
23	36	$value = $objectOrArray[$fieldName];
24	21	} elseif (\is_object($objectOrArray)) {
25	19	if (null !== $getter = self::guessObjectMethod($objectOrArray, $fieldName, 'get')) {
26	17	$value = $objectOrArray->$getter();
27	2	} elseif (isset($objectOrArray->$fieldName)) {
28	1	$value = $objectOrArray->$fieldName;
29		}
30		}
31
32	43	return $value;
33		}
34
35	19	private static function guessObjectMethod($object, string $fieldName, string $prefix): ?string
36		{
37	19	if (\is_callable([$object, $method = $prefix.\str_replace(' ', '', \ucwords(\str_replace('_', ' ', $fieldName)))])) {
38	17	return $method;
39		}
40
41	2	return null;
42		}
43		}
44

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#563)

FieldResolver::valueFromObjectOrArray() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like