Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — master (#851)
by Jérémiah
01:47
created
tests/Resolver/TypeResolverTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,8 +18,8 @@
 block discarded – undo
18 18
     protected function getResolverSolutionsMapping(): array
19 19
     {
20 20
         return [
21
-            'Toto' => ['factory' => fn () => new ObjectType(['name' => 'Toto', 'fields' => []]), 'aliases' => ['foo']],
22
-            'Tata' => ['factory' => fn () => new ObjectType(['name' => 'Tata', 'fields' => []]), 'aliases' => ['bar']],
21
+            'Toto' => ['factory' => fn() => new ObjectType(['name' => 'Toto', 'fields' => []]), 'aliases' => ['foo']],
22
+            'Tata' => ['factory' => fn() => new ObjectType(['name' => 'Tata', 'fields' => []]), 'aliases' => ['bar']],
23 23
         ];
24 24
     }
25 25
 
Please login to merge, or discard this patch.
tests/Definition/Type/CustomScalarTypeTest.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -22,12 +22,12 @@  discard block
 block discarded – undo
22 22
     public function testScalarTypeConfig(): void
23 23
     {
24 24
         $this->assertScalarTypeConfig(new YearScalarType());
25
-        $this->assertScalarTypeConfig(fn () => new YearScalarType());
25
+        $this->assertScalarTypeConfig(fn() => new YearScalarType());
26 26
     }
27 27
 
28 28
     public function testWithoutScalarTypeConfig(): void
29 29
     {
30
-        $genericFunc = fn ($value) => $value;
30
+        $genericFunc = fn($value) => $value;
31 31
         /** @phpstan-ignore-next-line */
32 32
         $type = new CustomScalarType([
33 33
             'serialize' => $genericFunc,
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
             ScalarType::class,
58 58
             $got
59 59
         ));
60
-        $type = new CustomScalarType(['name' => $name, 'scalarType' => $scalarType, 'serialize' => fn (mixed $input): mixed => '']);
60
+        $type = new CustomScalarType(['name' => $name, 'scalarType' => $scalarType, 'serialize' => fn(mixed $input): mixed => '']);
61 61
         $type->assertValid();
62 62
     }
63 63
 
@@ -66,11 +66,11 @@  discard block
 block discarded – undo
66 66
         yield [false, 'false'];
67 67
         yield [new stdClass(), 'instance of stdClass'];
68 68
         yield [
69
-            fn () => false,
69
+            fn() => false,
70 70
             'false',
71 71
         ];
72 72
         yield [
73
-            fn () => new stdClass(),
73
+            fn() => new stdClass(),
74 74
             'instance of stdClass',
75 75
         ];
76 76
     }
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
     {
85 85
         $type = new CustomScalarType([
86 86
             'scalarType' => $scalarType,
87
-            'serialize' => fn () => 'serialize',
88
-            'parseValue' => fn () => 'parseValue',
89
-            'parseLiteral' => fn () => 'parseLiteral',
87
+            'serialize' => fn() => 'serialize',
88
+            'parseValue' => fn() => 'parseValue',
89
+            'parseLiteral' => fn() => 'parseLiteral',
90 90
         ]);
91 91
 
92 92
         $this->assertSame('50 AC', $type->serialize(50));
Please login to merge, or discard this patch.
src/Definition/Type/CustomScalarType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             return parent::$type($value);
78 78
         }
79 79
 
80
-        $scalarType = match (true) {
80
+        $scalarType = match(true) {
81 81
             $this->config['scalarType'] instanceof ScalarType => $this->config['scalarType'],
82 82
             is_callable($this->config['scalarType']) => $this->config['scalarType'](),
83 83
             default => $this->config['scalarType'],
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
             return;
95 95
         }
96 96
 
97
-        $scalarType = match (true) {
97
+        $scalarType = match(true) {
98 98
             $this->config['scalarType'] instanceof ScalarType => $this->config['scalarType'],
99 99
             is_callable($this->config['scalarType']) => $this->config['scalarType'](),
100 100
             default => $this->config['scalarType'],
Please login to merge, or discard this patch.
tests/Functional/Generator/TypeGeneratorTest.php 1 patch
Spacing   -35 removed lines patch added patch discarded remove patch
@@ -111,38 +111,3 @@
 block discarded – undo
111 111
 
112 112
         // this is the part is why we must make this test run in separate process
113 113
         $query = <<<'EOF'
114
-            mutation {
115
-              conflictingValidatorNamespaces(test: "123", test2: "1", test3: "4")
116
-            }
117
-            EOF;
118
-
119
-        $response = static::query(
120
-            $query,
121
-            self::USER_RYAN,
122
-            'conflictingValidatorNamespaces'
123
-        )->getResponse()->getContent();
124
-
125
-        $this->assertEquals('{"data":{"conflictingValidatorNamespaces":true}}', $response);
126
-        // end part
127
-
128
-        // Validate definition file
129
-        /** @var string $definitionFile */
130
-        $definitionFile = file_get_contents($kernel->getCacheDir().'/overblog/graphql-bundle/__definitions__/MutationType.php');
131
-
132
-        $this->assertStringContainsString(
133
-            'use Symfony\Component\Validator\Constraints as SymfonyConstraints;',
134
-            $definitionFile,
135
-            'Generated definition file should contain import of Symfony\Component\Validator\Constraints aliased as SymfonyConstraints'
136
-        );
137
-        $this->assertStringNotContainsString(
138
-            'use '.Validator\CustomValidator1\Constraint::class,
139
-            $definitionFile,
140
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
141
-        );
142
-        $this->assertStringNotContainsString(
143
-            'use '.Validator\CustomValidator2\Constraint::class,
144
-            $definitionFile,
145
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
146
-        );
147
-    }
148
-}
Please login to merge, or discard this patch.
tests/Functional/MultipleSchema/MultipleSchemaTest.php 1 patch
Spacing   -64 removed lines patch added patch discarded remove patch
@@ -26,67 +26,3 @@
 block discarded – undo
26 26
         $this->assertSame([['node' => ['username' => 'user1']]], $result['data']['users']['edges']);
27 27
 
28 28
         $query = <<<'EOF'
29
-            mutation M {
30
-              addUser(input: {username: "user1"}) {
31
-                user {
32
-                  username
33
-                }
34
-              }
35
-            }
36
-            EOF;
37
-
38
-        $expectedData = [
39
-            'addUser' => [
40
-                'user' => ['username' => 'user1'],
41
-            ],
42
-        ];
43
-
44
-        $this->assertGraphQL($query, $expectedData, null, [], 'public');
45
-    }
46
-
47
-    public function testInternalSchema(): void
48
-    {
49
-        $result = $this->executeGraphQLRequest('{bar foo}', [], 'internal');
50
-        $this->assertSame('bar', $result['data']['bar']);
51
-        $this->assertSame('foo', $result['data']['foo']);
52
-        $this->assertSchemaQueryTypeName('InternalQuery');
53
-
54
-        $result = $this->executeGraphQLRequest('{users{edges{node{username email}}}}', [], 'internal');
55
-        $this->assertSame([['node' => ['username' => 'user1', 'email' => 'topsecret']]], $result['data']['users']['edges']);
56
-
57
-        $query = <<<'EOF'
58
-            mutation M {
59
-              addUser(input: {username: "user1"}) {
60
-                user {
61
-                  username
62
-                  email
63
-                }
64
-              }
65
-            }
66
-            EOF;
67
-
68
-        $expectedData = [
69
-            'addUser' => [
70
-                'user' => ['username' => 'user1', 'email' => 'email1'],
71
-            ],
72
-        ];
73
-
74
-        $this->assertGraphQL($query, $expectedData, null, [], 'internal');
75
-    }
76
-
77
-    public function testUnknownTypeShouldThrowAnUnresolvableException(): void
78
-    {
79
-        // @phpstan-ignore-next-line
80
-        $schema = $this->getContainer()->get('overblog_graphql.request_executor')->getSchema('public');
81
-        $this->expectException(UnresolvableException::class);
82
-        $this->expectExceptionMessage('Could not find type with alias "unknown". Did you forget to define it?');
83
-        $schema->getType('unknown');
84
-    }
85
-
86
-    private function assertSchemaQueryTypeName(string $typeName): void
87
-    {
88
-        // @phpstan-ignore-next-line
89
-        $query = $this->getContainer()->get('overblog_graphql.type_resolver')->resolve($typeName);
90
-        $this->assertSame('Query', $query->name);
91
-    }
92
-}
Please login to merge, or discard this patch.
tests/ExpressionLanguage/TestCase.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -106,13 +106,13 @@
 block discarded – undo
106 106
     protected function createGraphQLServices(array $services = []): GraphQLServices
107 107
     {
108 108
         $locateableServices = [
109
-            TypeResolver::class => fn () => $this->createMock(TypeResolver::class),
110
-            QueryResolver::class => fn () => $this->createMock(QueryResolver::class),
111
-            MutationResolver::class => fn () => $$this->createMock(MutationResolver::class),
109
+            TypeResolver::class => fn() => $this->createMock(TypeResolver::class),
110
+            QueryResolver::class => fn() => $this->createMock(QueryResolver::class),
111
+            MutationResolver::class => fn() => $$this->createMock(MutationResolver::class),
112 112
         ];
113 113
 
114 114
         foreach ($services as $id => $service) {
115
-            $locateableServices[$id] = fn () => $service;
115
+            $locateableServices[$id] = fn() => $service;
116 116
         }
117 117
 
118 118
         return new GraphQLServices($locateableServices);
Please login to merge, or discard this patch.
src/DependencyInjection/Compiler/IdentifyCallbackServiceIdsPass.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
                 $alias = $container->getAlias($id);
72 72
                 $id = (string) $alias;
73 73
                 $definition = $container->getDefinition($id);
74
-            } catch (ServiceNotFoundException|InvalidArgumentException $e) {
74
+            } catch (ServiceNotFoundException | InvalidArgumentException $e) {
75 75
                 if ($throw) {
76 76
                     throw $e;
77 77
                 }
Please login to merge, or discard this patch.
tests/EventListener/TypeDecoratorListenerTest.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -32,10 +32,10 @@  discard block
 block discarded – undo
32 32
      *
33 33
      * @dataProvider specialTypeFieldProvider
34 34
      */
35
-    public function testSpecialField($fieldName, ObjectType|UnionType|InterfaceType|CustomScalarType $typeWithSpecialField, callable $fieldValueRetriever = null, $strict = true): void
35
+    public function testSpecialField($fieldName, ObjectType | UnionType | InterfaceType | CustomScalarType $typeWithSpecialField, callable $fieldValueRetriever = null, $strict = true): void
36 36
     {
37 37
         if (null === $fieldValueRetriever) {
38
-            $fieldValueRetriever = fn (ObjectType|UnionType|InterfaceType|CustomScalarType $type, $fieldName) => $type->config[$fieldName];
38
+            $fieldValueRetriever = fn(ObjectType | UnionType | InterfaceType | CustomScalarType $type, $fieldName) => $type->config[$fieldName];
39 39
         }
40 40
         $expected = static function (): void {
41 41
         };
@@ -66,8 +66,8 @@  discard block
 block discarded – undo
66 66
                 yield 'toto' => ['type' => Type::boolean(), 'resolve' => null];
67 67
             },
68 68
         ]);
69
-        $barResolver = static fn () => 'bar';
70
-        $bazResolver = static fn () => 'baz';
69
+        $barResolver = static fn() => 'bar';
70
+        $bazResolver = static fn() => 'baz';
71 71
 
72 72
         $this->decorate(
73 73
             [$objectType->name => $objectType],
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
             [$objectType->name => $objectType],
103 103
             [
104 104
                 $objectType->name => [
105
-                    'bar' => fn ($value, $args) => $args,
105
+                    'bar' => fn($value, $args) => $args,
106 106
                 ],
107 107
             ]
108 108
         );
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
 
221 221
     public function testCustomScalarTypeUnknownField(): void
222 222
     {
223
-        $customScalarType = new CustomScalarType(['name' => 'Foo', 'scalarType' => Type::string(), 'serialize' => fn (mixed $input): mixed => '']);
223
+        $customScalarType = new CustomScalarType(['name' => 'Foo', 'scalarType' => Type::string(), 'serialize' => fn(mixed $input): mixed => '']);
224 224
         $this->assertDecorateException(
225 225
             [$customScalarType->name => $customScalarType],
226 226
             [
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
 
273 273
     public function specialTypeFieldProvider(): array
274 274
     {
275
-        $objectWithResolveField = new ObjectType(['name' => 'Bar', 'fields' => [], 'resolveField' => fn () => '']);
275
+        $objectWithResolveField = new ObjectType(['name' => 'Bar', 'fields' => [], 'resolveField' => fn() => '']);
276 276
 
277 277
         return [
278 278
             // isTypeOf
@@ -281,18 +281,18 @@  discard block
 block discarded – undo
281 281
             [
282 282
                 ResolverMapInterface::RESOLVE_FIELD,
283 283
                 $objectWithResolveField,
284
-                fn (ObjectType $type) => $type->resolveFieldFn,
284
+                fn(ObjectType $type) => $type->resolveFieldFn,
285 285
                 false,
286 286
             ],
287 287
             [ResolverMapInterface::RESOLVE_FIELD, $objectWithResolveField, null, false],
288 288
             // resolveType
289
-            [ResolverMapInterface::RESOLVE_TYPE, new UnionType(['name' => 'Baz', 'resolveType' => fn () => '', 'types' => []])],
290
-            [ResolverMapInterface::RESOLVE_TYPE, new InterfaceType(['name' => 'Baz', 'fields' => [], 'resolveType' => fn (mixed $objectValue, mixed $context, ResolveInfo $resolveInfo): string => ''])],
289
+            [ResolverMapInterface::RESOLVE_TYPE, new UnionType(['name' => 'Baz', 'resolveType' => fn() => '', 'types' => []])],
290
+            [ResolverMapInterface::RESOLVE_TYPE, new InterfaceType(['name' => 'Baz', 'fields' => [], 'resolveType' => fn(mixed $objectValue, mixed $context, ResolveInfo $resolveInfo): string => ''])],
291 291
             // custom scalar
292
-            [ResolverMapInterface::SERIALIZE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn (mixed $input): mixed => ''])],
293
-            [ResolverMapInterface::PARSE_VALUE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn (mixed $input): mixed => '', 'parseValue' => fn (mixed $input): mixed => ''])],
294
-            [ResolverMapInterface::PARSE_LITERAL, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn (mixed $input): mixed => '', 'parseLiteral' => fn (Node $a, array|null $b): mixed => ''])],
295
-            [ResolverMapInterface::SCALAR_TYPE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn (mixed $input): mixed => ''])],
292
+            [ResolverMapInterface::SERIALIZE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn(mixed $input): mixed => ''])],
293
+            [ResolverMapInterface::PARSE_VALUE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn(mixed $input): mixed => '', 'parseValue' => fn(mixed $input): mixed => ''])],
294
+            [ResolverMapInterface::PARSE_LITERAL, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn(mixed $input): mixed => '', 'parseLiteral' => fn(Node $a, array | null $b): mixed => ''])],
295
+            [ResolverMapInterface::SCALAR_TYPE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn(mixed $input): mixed => ''])],
296 296
         ];
297 297
     }
298 298
 
Please login to merge, or discard this patch.
src/Config/TypeDefinition.php 1 patch
Spacing   +10 added lines, -11 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
         $node
43 43
             ->isRequired()
44 44
             ->validate()
45
-                ->ifTrue(fn ($name) => !preg_match('/^[_a-z][_0-9a-z]*$/i', $name))
45
+                ->ifTrue(fn($name) => !preg_match('/^[_a-z][_0-9a-z]*$/i', $name))
46 46
                 ->thenInvalid('Invalid type name "%s". (see http://spec.graphql.org/June2018/#sec-Names)')
47 47
             ->end()
48 48
         ;
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
     {
158 158
         $node
159 159
             ->beforeNormalization()
160
-                ->ifTrue(fn ($options) => !empty($options[$old]) && empty($options[$new]))
160
+                ->ifTrue(fn($options) => !empty($options[$old]) && empty($options[$new]))
161 161
                 ->then(function ($options) use ($old, $new) {
162 162
                     if (is_callable($options[$old])) {
163 163
                         if (is_array($options[$old])) {
@@ -167,8 +167,7 @@  discard block
 block discarded – undo
167 167
                         }
168 168
                     } elseif (is_string($options[$old])) {
169 169
                         $options[$new]['expression'] = ExpressionLanguage::stringHasTrigger($options[$old]) ?
170
-                            ExpressionLanguage::unprefixExpression($options[$old]) :
171
-                            json_encode($options[$old]);
170
+                            ExpressionLanguage::unprefixExpression($options[$old]) : json_encode($options[$old]);
172 171
                     } else {
173 172
                         $options[$new]['expression'] = json_encode($options[$old]);
174 173
                     }
@@ -177,7 +176,7 @@  discard block
 block discarded – undo
177 176
                 })
178 177
             ->end()
179 178
             ->beforeNormalization()
180
-                ->ifTrue(fn ($options) => is_array($options) && array_key_exists($old, $options))
179
+                ->ifTrue(fn($options) => is_array($options) && array_key_exists($old, $options))
181 180
                 ->then(function ($options) use ($old) {
182 181
                     unset($options[$old]);
183 182
 
@@ -185,7 +184,7 @@  discard block
 block discarded – undo
185 184
                 })
186 185
             ->end()
187 186
             ->validate()
188
-                ->ifTrue(fn (array $v) => !empty($v[$new]) && !empty($v[$old]))
187
+                ->ifTrue(fn(array $v) => !empty($v[$new]) && !empty($v[$old]))
189 188
                 ->thenInvalid(sprintf(
190 189
                     '"%s" and "%s" should not be used together in "%%s".',
191 190
                     $new,
@@ -203,17 +202,17 @@  discard block
 block discarded – undo
203 202
         $node
204 203
             ->info($info)
205 204
             ->validate()
206
-                ->ifTrue(fn (array $v) => !empty($v['method']) && !empty($v['expression']))
205
+                ->ifTrue(fn(array $v) => !empty($v['method']) && !empty($v['expression']))
207 206
                 ->thenInvalid('"method" and "expression" should not be use together.')
208 207
             ->end()
209 208
             ->beforeNormalization()
210 209
                 // Allow short syntax
211
-                ->ifTrue(fn ($options) => is_string($options) && ExpressionLanguage::stringHasTrigger($options))
212
-                ->then(fn ($options) => ['expression' => ExpressionLanguage::unprefixExpression($options)])
210
+                ->ifTrue(fn($options) => is_string($options) && ExpressionLanguage::stringHasTrigger($options))
211
+                ->then(fn($options) => ['expression' => ExpressionLanguage::unprefixExpression($options)])
213 212
             ->end()
214 213
             ->beforeNormalization()
215
-                ->ifTrue(fn ($options) => is_string($options) && !ExpressionLanguage::stringHasTrigger($options))
216
-                ->then(fn ($options) => ['method' => $options])
214
+                ->ifTrue(fn($options) => is_string($options) && !ExpressionLanguage::stringHasTrigger($options))
215
+                ->then(fn($options) => ['method' => $options])
217 216
             ->end()
218 217
             ->children()
219 218
                 ->scalarNode('method')->end()
Please login to merge, or discard this patch.