QueryComplexityTest::assertResponse() - Code Metrics - Inspection of "Query complexity security" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#23)

by Jérémiah

created 2016-04-03 14:02 UTC

QueryComplexityTest::assertResponse() A

↳ Parent: QueryComplexityTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	11
loc	11
rs	9.4285
cc	1
eloc	6
nc	1
nop	2

<?php

/*
 * This file is part of the OverblogGraphQLBundle package.
 *
 * (c) Overblog <http://github.com/overblog/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Overblog\GraphQLBundle\Tests\Functional\Security;

use Overblog\GraphQLBundle\Tests\Functional\TestCase;

class QueryComplexityTest extends TestCase
{
    private $userFriendsWithoutLimitQuery = <<<EOF
query MyQuery {
  user {
    friends {
      edges {
        node {
          name
        }
      }
    }
  }
}
EOF;

    private $userFriendsWithLimitQuery = <<<EOF
query MyQuery {
  user {
    friends(first: 1) {
      edges {
        node {
          name
        }
      }
    }
  }
}
EOF;

    public function testComplexityReachLimitation()
    {
        $expected = [
            'data' => null,
            'errors' => [
                [
                    'message' => 'Max query complexity should be 10 but got 54.',
                ],
            ],
        ];

        $this->assertResponse($this->userFriendsWithoutLimitQuery, $expected);
    }

    public function testComplexityUnderLimitation()
    {
        $expected = [
            'data' => [
                'user' => [
                    'friends' => [
                        'edges' => [
                            ['node' => ['name' => 'Nick']],
                        ],
                    ],
                ],
            ],
        ];

        $this->assertResponse($this->userFriendsWithLimitQuery, $expected);
    }

    private static function assertResponse($query, array $expected)

    {
        $client = static::createClient(['test_case' => 'queryComplexity']);
        $client->request('GET', '/', ['query' => $query]);

        $result = $client->getResponse()->getContent();

        static::assertEquals($expected, json_decode($result, true), $result);

        return $client;
    }
}


1		<?php
2
3		/*
4		* This file is part of the OverblogGraphQLBundle package.
5		*
6		* (c) Overblog <http://github.com/overblog/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Overblog\GraphQLBundle\Tests\Functional\Security;
13
14		use Overblog\GraphQLBundle\Tests\Functional\TestCase;
15
16		class QueryComplexityTest extends TestCase
17		{
18		private $userFriendsWithoutLimitQuery = <<<EOF
19		query MyQuery {
20		user {
21		friends {
22		edges {
23		node {
24		name
25		}
26		}
27		}
28		}
29		}
30		EOF;
31
32		private $userFriendsWithLimitQuery = <<<EOF
33		query MyQuery {
34		user {
35		friends(first: 1) {
36		edges {
37		node {
38		name
39		}
40		}
41		}
42		}
43		}
44		EOF;
45
46		public function testComplexityReachLimitation()
47		{
48		$expected = [
49		'data' => null,
50		'errors' => [
51		[
52		'message' => 'Max query complexity should be 10 but got 54.',
53		],
54		],
55		];
56
57		$this->assertResponse($this->userFriendsWithoutLimitQuery, $expected);
58		}
59
60		public function testComplexityUnderLimitation()
61		{
62		$expected = [
63		'data' => [
64		'user' => [
65		'friends' => [
66		'edges' => [
67		['node' => ['name' => 'Nick']],
68		],
69		],
70		],
71		],
72		];
73
74		$this->assertResponse($this->userFriendsWithLimitQuery, $expected);
75		}
76
77	View Code Duplication	private static function assertResponse($query, array $expected)
		0 ignored issues – show Duplication introduced 2016-04-02 20:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		{
79		$client = static::createClient(['test_case' => 'queryComplexity']);
80		$client->request('GET', '/', ['query' => $query]);
81
82		$result = $client->getResponse()->getContent();
83
84		static::assertEquals($expected, json_decode($result, true), $result);
85
86		return $client;
87		}
88		}
89

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#23)

QueryComplexityTest::assertResponse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like