ValidateCommand::__construct() - Code Metrics - Inspection of "Add CLI command to validate Schema" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#390)

unknown

created 2018-09-23 22:32 UTC

ValidateCommand::__construct() A

↳ Parent: ValidateCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php

declare(strict_types=1);

namespace Overblog\GraphQLBundle\Command;

use GraphQL\Error\InvariantViolation;
use Overblog\GraphQLBundle\Resolver\TypeResolver;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

final class ValidateCommand extends Command
{
    use RequestExecutorLazyLoaderTrait;

    private $typeResolver;

    public function __construct(TypeResolver $typeResolver)
    {
        parent::__construct();
        $this->typeResolver = $typeResolver;
    }

    protected function configure(): void
    {
        $this
            ->setName('graphql:validate')
            ->setDescription('Validate schema')
            ->addOption(
                'schema',
                null,
                InputOption::VALUE_OPTIONAL,
                'The schema name to validate.'
            )
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output): void
    {
        $schemaName = $input->getOption('schema');
        $schema = $this->getRequestExecutor()->getSchema($schemaName);

        try {
            @$schema->assertValid();
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        } catch (InvariantViolation $e) {

            $output->writeln('<comment>'.$e->getMessage().'</comment>');

            return;
        }
        $output->writeln('<info>No error</info>');
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Overblog\GraphQLBundle\Command;
6
7		use GraphQL\Error\InvariantViolation;
8		use Overblog\GraphQLBundle\Resolver\TypeResolver;
9		use Symfony\Component\Console\Command\Command;
10		use Symfony\Component\Console\Input\InputInterface;
11		use Symfony\Component\Console\Input\InputOption;
12		use Symfony\Component\Console\Output\OutputInterface;
13
14		final class ValidateCommand extends Command
15		{
16		use RequestExecutorLazyLoaderTrait;
17
18		private $typeResolver;
19
20	1	public function __construct(TypeResolver $typeResolver)
21		{
22	1	parent::__construct();
23	1	$this->typeResolver = $typeResolver;
24	1	}
25
26	1	protected function configure(): void
27		{
28		$this
29	1	->setName('graphql:validate')
30	1	->setDescription('Validate schema')
31	1	->addOption(
32	1	'schema',
33	1	null,
34	1	InputOption::VALUE_OPTIONAL,
35	1	'The schema name to validate.'
36		)
37		;
38	1	}
39
40	1	protected function execute(InputInterface $input, OutputInterface $output): void
41		{
42	1	$schemaName = $input->getOption('schema');
43	1	$schema = $this->getRequestExecutor()->getSchema($schemaName);
44
45		try {
46	1	@$schema->assertValid();
		0 ignored issues – show Security Best Practice introduced 2018-09-23 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
47		} catch (InvariantViolation $e) {
		0 ignored issues – show Bug introduced 2018-09-22 22:22 UTC by Report Bug Copy Issue Report The class `GraphQL\Error\InvariantViolation` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
48		$output->writeln('<comment>'.$e->getMessage().'</comment>');
49
50		return;
51		}
52	1	$output->writeln('<info>No error</info>');
53	1	}
54		}
55

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#390)

ValidateCommand::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like