overblog / GraphQLBundle

tests/Functional/Security/DisableIntrospectionTest.php

Indentation -29 removed lines

@@ -9,32 +9,3 @@
 final class DisableIntrospectionTest extends TestCase
 {
     private string $introspectionQuery = <<<'EOF'
-        query {
-          __schema {
-            types {
-              name
-              description
-            }
-          }
-        }
-        EOF;
-
-    public function testIntrospectionDisabled(): void
-    {
-        $expected = [
-            'errors' => [
-                [
-                    'message' => 'GraphQL introspection is not allowed, but the query contained __schema or __type',
-                    'locations' => [
-                        [
-                            'line' => 2,
-                            'column' => 3,
-                        ],
-                    ],
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->introspectionQuery, $expected, self::ANONYMOUS_USER, 'disableIntrospection');
-    }
-}

Switch Indentation -29 removed lines

@@ -9,32 +9,3 @@
 final class DisableIntrospectionTest extends TestCase
 {
     private string $introspectionQuery = <<<'EOF'
-        query {
-          __schema {
-            types {
-              name
-              description
-            }
-          }
-        }
-        EOF;
-
-    public function testIntrospectionDisabled(): void
-    {
-        $expected = [
-            'errors' => [
-                [
-                    'message' => 'GraphQL introspection is not allowed, but the query contained __schema or __type',
-                    'locations' => [
-                        [
-                            'line' => 2,
-                            'column' => 3,
-                        ],
-                    ],
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->introspectionQuery, $expected, self::ANONYMOUS_USER, 'disableIntrospection');
-    }
-}

Spacing -29 removed lines

@@ -9,32 +9,3 @@
 final class DisableIntrospectionTest extends TestCase
 {
     private string $introspectionQuery = <<<'EOF'
-        query {
-          __schema {
-            types {
-              name
-              description
-            }
-          }
-        }
-        EOF;
-
-    public function testIntrospectionDisabled(): void
-    {
-        $expected = [
-            'errors' => [
-                [
-                    'message' => 'GraphQL introspection is not allowed, but the query contained __schema or __type',
-                    'locations' => [
-                        [
-                            'line' => 2,
-                            'column' => 3,
-                        ],
-                    ],
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->introspectionQuery, $expected, self::ANONYMOUS_USER, 'disableIntrospection');
-    }
-}

Braces -29 removed lines

@@ -9,32 +9,3 @@
 final class DisableIntrospectionTest extends TestCase
 {
     private string $introspectionQuery = <<<'EOF'
-        query {
-          __schema {
-            types {
-              name
-              description
-            }
-          }
-        }
-        EOF;
-
-    public function testIntrospectionDisabled(): void
-    {
-        $expected = [
-            'errors' => [
-                [
-                    'message' => 'GraphQL introspection is not allowed, but the query contained __schema or __type',
-                    'locations' => [
-                        [
-                            'line' => 2,
-                            'column' => 3,
-                        ],
-                    ],
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->introspectionQuery, $expected, self::ANONYMOUS_USER, 'disableIntrospection');
-    }
-}

Upper-Lower-Casing -29 removed lines

@@ -9,32 +9,3 @@
 final class DisableIntrospectionTest extends TestCase
 {
     private string $introspectionQuery = <<<'EOF'
-        query {
-          __schema {
-            types {
-              name
-              description
-            }
-          }
-        }
-        EOF;
-
-    public function testIntrospectionDisabled(): void
-    {
-        $expected = [
-            'errors' => [
-                [
-                    'message' => 'GraphQL introspection is not allowed, but the query contained __schema or __type',
-                    'locations' => [
-                        [
-                            'line' => 2,
-                            'column' => 3,
-                        ],
-                    ],
-                ],
-            ],
-        ];
-
-        $this->assertResponse($this->introspectionQuery, $expected, self::ANONYMOUS_USER, 'disableIntrospection');
-    }
-}

src/Validator/ValidationNode.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
     private ?ResolverArgs $__resolverArgs;
 
     public function __construct(
-        ObjectType|InputObjectType $type,
+        ObjectType | InputObjectType $type,
         string $field = null,
         ?ValidationNode $parent = null,
         ?ResolverArgs $resolverArgs = null

src/EventListener/TypeDecoratorListener.php

Spacing +2 added lines, -2 removed lines

@@ -87,7 +87,7 @@ 
         $this->decorateObjectTypeFields($type, $fieldsResolved, $resolverMap);
     }
 
-    private function decorateInterfaceOrUnionType(InterfaceType|UnionType $type, ResolverMapInterface $resolverMap): void
+    private function decorateInterfaceOrUnionType(InterfaceType | UnionType $type, ResolverMapInterface $resolverMap): void
     {
         $this->configTypeMapping($type, ResolverMapInterface::RESOLVE_TYPE, $resolverMap);
         $covered = $resolverMap->covered($type->name);
@@ -188,7 +188,7 @@ 
         $type->config['fields'] = is_callable($fields) ? $decoratedFields : $decoratedFields();
     }
 
-    private function configTypeMapping(ObjectType|InterfaceType|UnionType|CustomScalarType $type, string $fieldName, ResolverMapInterface $resolverMap): void
+    private function configTypeMapping(ObjectType | InterfaceType | UnionType | CustomScalarType $type, string $fieldName, ResolverMapInterface $resolverMap): void
     {
         if ($resolverMap->isResolvable($type->name, $fieldName)) {
             $type->config[substr($fieldName, 2)] = $resolverMap->resolve($type->name, $fieldName);

src/Validator/InputValidator.php

Spacing +4 added lines, -4 removed lines

@@ -62,7 +62,7 @@ 
     /**
      * @throws ArgumentsValidationException
      */
-    public function validate(string|array|null $groups = null, bool $throw = true): ?ConstraintViolationListInterface
+    public function validate(string | array | null $groups = null, bool $throw = true): ?ConstraintViolationListInterface
     {
         $rootNode = new ValidationNode(
             $this->info->parentType,
@@ -206,7 +206,7 @@ 
         return $rootObject;
     }
 
-    private static function isListOfType(GeneratedTypeInterface|ListOfType|NonNull $type): bool
+    private static function isListOfType(GeneratedTypeInterface | ListOfType | NonNull $type): bool
     {
         if ($type instanceof ListOfType || ($type instanceof NonNull && $type->getWrappedType() instanceof ListOfType)) {
             return true;
@@ -215,7 +215,7 @@ 
         return false;
     }
 
-    private function createCollectionNode(array $values, ObjectType|InputObjectType $type, ValidationNode $parent): array
+    private function createCollectionNode(array $values, ObjectType | InputObjectType $type, ValidationNode $parent): array
     {
         $collection = [];
 
@@ -226,7 +226,7 @@ 
         return $collection;
     }
 
-    private function createObjectNode(array $value, ObjectType|InputObjectType $type, ValidationNode $parent): ValidationNode
+    private function createObjectNode(array $value, ObjectType | InputObjectType $type, ValidationNode $parent): ValidationNode
     {
         /** @phpstan-ignore-next-line */
         $classValidation = static::normalizeConfig($type->config['validation'] ?? []);

tests/Resolver/TypeResolverTest.php

Spacing +2 added lines, -2 removed lines

@@ -18,8 +18,8 @@
     protected function getResolverSolutionsMapping(): array
     {
         return [
-            'Toto' => ['factory' => fn () => new ObjectType(['name' => 'Toto', 'fields' => []]), 'aliases' => ['foo']],
-            'Tata' => ['factory' => fn () => new ObjectType(['name' => 'Tata', 'fields' => []]), 'aliases' => ['bar']],
+            'Toto' => ['factory' => fn() => new ObjectType(['name' => 'Toto', 'fields' => []]), 'aliases' => ['foo']],
+            'Tata' => ['factory' => fn() => new ObjectType(['name' => 'Tata', 'fields' => []]), 'aliases' => ['bar']],
         ];
     }
 

tests/EventListener/TypeDecoratorListenerTest.php

Spacing +14 added lines, -14 removed lines

@@ -32,10 +32,10 @@ 
      *
      * @dataProvider specialTypeFieldProvider
      */
-    public function testSpecialField($fieldName, ObjectType|UnionType|InterfaceType|CustomScalarType $typeWithSpecialField, callable $fieldValueRetriever = null, $strict = true): void
+    public function testSpecialField($fieldName, ObjectType | UnionType | InterfaceType | CustomScalarType $typeWithSpecialField, callable $fieldValueRetriever = null, $strict = true): void
     {
         if (null === $fieldValueRetriever) {
-            $fieldValueRetriever = fn (ObjectType|UnionType|InterfaceType|CustomScalarType $type, $fieldName) => $type->config[$fieldName];
+            $fieldValueRetriever = fn(ObjectType | UnionType | InterfaceType | CustomScalarType $type, $fieldName) => $type->config[$fieldName];
         }
         $expected = static function (): void {
         };
@@ -68,8 +68,8 @@ 
                 ];
             },
         ]);
-        $barResolver = static fn () => 'bar';
-        $bazResolver = static fn () => 'baz';
+        $barResolver = static fn() => 'bar';
+        $bazResolver = static fn() => 'baz';
 
         $this->decorate(
             [$objectType->name => $objectType],
@@ -104,7 +104,7 @@ 
             [$objectType->name => $objectType],
             [
                 $objectType->name => [
-                    'bar' => fn ($value, $args) => $args,
+                    'bar' => fn($value, $args) => $args,
                 ],
             ]
         );
@@ -193,7 +193,7 @@ 
 
     public function testCustomScalarTypeUnknownField(): void
     {
-        $customScalarType = new CustomScalarType(['name' => 'Foo', 'scalarType' => Type::string(), 'serialize' => fn (mixed $input): mixed => '']);
+        $customScalarType = new CustomScalarType(['name' => 'Foo', 'scalarType' => Type::string(), 'serialize' => fn(mixed $input): mixed => '']);
         $this->assertDecorateException(
             [$customScalarType->name => $customScalarType],
             [
@@ -245,7 +245,7 @@ 
 
     public function specialTypeFieldProvider(): array
     {
-        $objectWithResolveField = new ObjectType(['name' => 'Bar', 'fields' => [], 'resolveField' => fn () => '']);
+        $objectWithResolveField = new ObjectType(['name' => 'Bar', 'fields' => [], 'resolveField' => fn() => '']);
 
         return [
             // isTypeOf
@@ -254,18 +254,18 @@ 
             [
                 ResolverMapInterface::RESOLVE_FIELD,
                 $objectWithResolveField,
-                fn (ObjectType $type) => $type->resolveFieldFn,
+                fn(ObjectType $type) => $type->resolveFieldFn,
                 false,
             ],
             [ResolverMapInterface::RESOLVE_FIELD, $objectWithResolveField, null, false],
             // resolveType
-            [ResolverMapInterface::RESOLVE_TYPE, new UnionType(['name' => 'Baz', 'resolveType' => fn () => '', 'types' => []])],
-            [ResolverMapInterface::RESOLVE_TYPE, new InterfaceType(['name' => 'Baz', 'fields' => [], 'resolveType' => fn (mixed $objectValue, mixed $context, ResolveInfo $resolveInfo): string => ''])],
+            [ResolverMapInterface::RESOLVE_TYPE, new UnionType(['name' => 'Baz', 'resolveType' => fn() => '', 'types' => []])],
+            [ResolverMapInterface::RESOLVE_TYPE, new InterfaceType(['name' => 'Baz', 'fields' => [], 'resolveType' => fn(mixed $objectValue, mixed $context, ResolveInfo $resolveInfo): string => ''])],
             // custom scalar
-            [ResolverMapInterface::SERIALIZE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn (mixed $input): mixed => ''])],
-            [ResolverMapInterface::PARSE_VALUE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn (mixed $input): mixed => '', 'parseValue' => fn (mixed $input): mixed => ''])],
-            [ResolverMapInterface::PARSE_LITERAL, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn (mixed $input): mixed => '', 'parseLiteral' => fn (Node $a, array|null $b): mixed => ''])],
-            [ResolverMapInterface::SCALAR_TYPE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn (mixed $input): mixed => ''])],
+            [ResolverMapInterface::SERIALIZE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn(mixed $input): mixed => ''])],
+            [ResolverMapInterface::PARSE_VALUE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn(mixed $input): mixed => '', 'parseValue' => fn(mixed $input): mixed => ''])],
+            [ResolverMapInterface::PARSE_LITERAL, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn(mixed $input): mixed => '', 'parseLiteral' => fn(Node $a, array | null $b): mixed => ''])],
+            [ResolverMapInterface::SCALAR_TYPE, new CustomScalarType(['name' => 'Custom', 'scalarType' => Type::string(), 'serialize' => fn(mixed $input): mixed => ''])],
         ];
     }
 

tests/Definition/Type/CustomScalarTypeTest.php

Spacing +8 added lines, -8 removed lines

@@ -22,12 +22,12 @@ 
     public function testScalarTypeConfig(): void
     {
         $this->assertScalarTypeConfig(new YearScalarType());
-        $this->assertScalarTypeConfig(fn () => new YearScalarType());
+        $this->assertScalarTypeConfig(fn() => new YearScalarType());
     }
 
     public function testWithoutScalarTypeConfig(): void
     {
-        $genericFunc = fn ($value) => $value;
+        $genericFunc = fn($value) => $value;
         /** @phpstan-ignore-next-line */
         $type = new CustomScalarType([
             'serialize' => $genericFunc,
@@ -57,7 +57,7 @@ 
             ScalarType::class,
             $got
         ));
-        $type = new CustomScalarType(['name' => $name, 'scalarType' => $scalarType, 'serialize' => fn (mixed $input): mixed => '']);
+        $type = new CustomScalarType(['name' => $name, 'scalarType' => $scalarType, 'serialize' => fn(mixed $input): mixed => '']);
         $type->assertValid();
     }
 
@@ -66,11 +66,11 @@ 
         yield [false, 'false'];
         yield [new stdClass(), 'instance of stdClass'];
         yield [
-            fn () => false,
+            fn() => false,
             'false',
         ];
         yield [
-            fn () => new stdClass(),
+            fn() => new stdClass(),
             'instance of stdClass',
         ];
     }
@@ -84,9 +84,9 @@ 
     {
         $type = new CustomScalarType([
             'scalarType' => $scalarType,
-            'serialize' => fn () => 'serialize',
-            'parseValue' => fn () => 'parseValue',
-            'parseLiteral' => fn () => 'parseLiteral',
+            'serialize' => fn() => 'serialize',
+            'parseValue' => fn() => 'parseValue',
+            'parseLiteral' => fn() => 'parseLiteral',
         ]);
 
         $this->assertSame('50 AC', $type->serialize(50));

src/Definition/Type/CustomScalarType.php

Spacing +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
             return parent::$type($value);
         }
 
-        $scalarType = match (true) {
+        $scalarType = match(true) {
             $this->config['scalarType'] instanceof ScalarType => $this->config['scalarType'],
             is_callable($this->config['scalarType']) => $this->config['scalarType'](),
             default => $this->config['scalarType'],
@@ -94,7 +94,7 @@ 
             return;
         }
 
-        $scalarType = match (true) {
+        $scalarType = match(true) {
             $this->config['scalarType'] instanceof ScalarType => $this->config['scalarType'],
             is_callable($this->config['scalarType']) => $this->config['scalarType'](),
             default => $this->config['scalarType'],

tests/Functional/Generator/TypeGeneratorTest.php

Indentation -35 removed lines

@@ -111,38 +111,3 @@
 
         // this is the part is why we must make this test run in separate process
         $query = <<<'EOF'
-            mutation {
-              conflictingValidatorNamespaces(test: "123", test2: "1", test3: "4")
-            }
-            EOF;
-
-        $response = static::query(
-            $query,
-            self::USER_RYAN,
-            'conflictingValidatorNamespaces'
-        )->getResponse()->getContent();
-
-        $this->assertEquals('{"data":{"conflictingValidatorNamespaces":true}}', $response);
-        // end part
-
-        // Validate definition file
-        /** @var string $definitionFile */
-        $definitionFile = file_get_contents($kernel->getCacheDir().'/overblog/graphql-bundle/__definitions__/MutationType.php');
-
-        $this->assertStringContainsString(
-            'use Symfony\Component\Validator\Constraints as SymfonyConstraints;',
-            $definitionFile,
-            'Generated definition file should contain import of Symfony\Component\Validator\Constraints aliased as SymfonyConstraints'
-        );
-        $this->assertStringNotContainsString(
-            'use '.Validator\CustomValidator1\Constraint::class,
-            $definitionFile,
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
-        );
-        $this->assertStringNotContainsString(
-            'use '.Validator\CustomValidator2\Constraint::class,
-            $definitionFile,
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
-        );
-    }
-}

Switch Indentation -35 removed lines

@@ -111,38 +111,3 @@
 
         // this is the part is why we must make this test run in separate process
         $query = <<<'EOF'
-            mutation {
-              conflictingValidatorNamespaces(test: "123", test2: "1", test3: "4")
-            }
-            EOF;
-
-        $response = static::query(
-            $query,
-            self::USER_RYAN,
-            'conflictingValidatorNamespaces'
-        )->getResponse()->getContent();
-
-        $this->assertEquals('{"data":{"conflictingValidatorNamespaces":true}}', $response);
-        // end part
-
-        // Validate definition file
-        /** @var string $definitionFile */
-        $definitionFile = file_get_contents($kernel->getCacheDir().'/overblog/graphql-bundle/__definitions__/MutationType.php');
-
-        $this->assertStringContainsString(
-            'use Symfony\Component\Validator\Constraints as SymfonyConstraints;',
-            $definitionFile,
-            'Generated definition file should contain import of Symfony\Component\Validator\Constraints aliased as SymfonyConstraints'
-        );
-        $this->assertStringNotContainsString(
-            'use '.Validator\CustomValidator1\Constraint::class,
-            $definitionFile,
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
-        );
-        $this->assertStringNotContainsString(
-            'use '.Validator\CustomValidator2\Constraint::class,
-            $definitionFile,
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
-        );
-    }
-}

Spacing -35 removed lines

@@ -111,38 +111,3 @@
 
         // this is the part is why we must make this test run in separate process
         $query = <<<'EOF'
-            mutation {
-              conflictingValidatorNamespaces(test: "123", test2: "1", test3: "4")
-            }
-            EOF;
-
-        $response = static::query(
-            $query,
-            self::USER_RYAN,
-            'conflictingValidatorNamespaces'
-        )->getResponse()->getContent();
-
-        $this->assertEquals('{"data":{"conflictingValidatorNamespaces":true}}', $response);
-        // end part
-
-        // Validate definition file
-        /** @var string $definitionFile */
-        $definitionFile = file_get_contents($kernel->getCacheDir().'/overblog/graphql-bundle/__definitions__/MutationType.php');
-
-        $this->assertStringContainsString(
-            'use Symfony\Component\Validator\Constraints as SymfonyConstraints;',
-            $definitionFile,
-            'Generated definition file should contain import of Symfony\Component\Validator\Constraints aliased as SymfonyConstraints'
-        );
-        $this->assertStringNotContainsString(
-            'use '.Validator\CustomValidator1\Constraint::class,
-            $definitionFile,
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
-        );
-        $this->assertStringNotContainsString(
-            'use '.Validator\CustomValidator2\Constraint::class,
-            $definitionFile,
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
-        );
-    }
-}

Braces -35 removed lines

@@ -111,38 +111,3 @@
 
         // this is the part is why we must make this test run in separate process
         $query = <<<'EOF'
-            mutation {
-              conflictingValidatorNamespaces(test: "123", test2: "1", test3: "4")
-            }
-            EOF;
-
-        $response = static::query(
-            $query,
-            self::USER_RYAN,
-            'conflictingValidatorNamespaces'
-        )->getResponse()->getContent();
-
-        $this->assertEquals('{"data":{"conflictingValidatorNamespaces":true}}', $response);
-        // end part
-
-        // Validate definition file
-        /** @var string $definitionFile */
-        $definitionFile = file_get_contents($kernel->getCacheDir().'/overblog/graphql-bundle/__definitions__/MutationType.php');
-
-        $this->assertStringContainsString(
-            'use Symfony\Component\Validator\Constraints as SymfonyConstraints;',
-            $definitionFile,
-            'Generated definition file should contain import of Symfony\Component\Validator\Constraints aliased as SymfonyConstraints'
-        );
-        $this->assertStringNotContainsString(
-            'use '.Validator\CustomValidator1\Constraint::class,
-            $definitionFile,
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
-        );
-        $this->assertStringNotContainsString(
-            'use '.Validator\CustomValidator2\Constraint::class,
-            $definitionFile,
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
-        );
-    }
-}

Upper-Lower-Casing -35 removed lines

@@ -111,38 +111,3 @@
 
         // this is the part is why we must make this test run in separate process
         $query = <<<'EOF'
-            mutation {
-              conflictingValidatorNamespaces(test: "123", test2: "1", test3: "4")
-            }
-            EOF;
-
-        $response = static::query(
-            $query,
-            self::USER_RYAN,
-            'conflictingValidatorNamespaces'
-        )->getResponse()->getContent();
-
-        $this->assertEquals('{"data":{"conflictingValidatorNamespaces":true}}', $response);
-        // end part
-
-        // Validate definition file
-        /** @var string $definitionFile */
-        $definitionFile = file_get_contents($kernel->getCacheDir().'/overblog/graphql-bundle/__definitions__/MutationType.php');
-
-        $this->assertStringContainsString(
-            'use Symfony\Component\Validator\Constraints as SymfonyConstraints;',
-            $definitionFile,
-            'Generated definition file should contain import of Symfony\Component\Validator\Constraints aliased as SymfonyConstraints'
-        );
-        $this->assertStringNotContainsString(
-            'use '.Validator\CustomValidator1\Constraint::class,
-            $definitionFile,
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
-        );
-        $this->assertStringNotContainsString(
-            'use '.Validator\CustomValidator2\Constraint::class,
-            $definitionFile,
-            'Generated definition file should not contain imports of custom constraints, FQCN should be used instead'
-        );
-    }
-}