Inspection of "Merge pull request #73 from mcg-web/promise" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( eed88d...353bdf )

by Jérémiah

created 2017-01-26 15:27 UTC

Status

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -20,14 +20,14 @@  discard block
 block discarded – undo
         return [
             new ExpressionFunction(
                 'hasRole',
-                function ($role) {
+                function($role) {
                     return sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s)', $role);
                 }
             ),
 
             new ExpressionFunction(
                 'hasAnyRole',
-                function ($roles) {
+                function($roles) {
                     $code = sprintf('array_reduce(%s, function ($isGranted, $role) use ($container) { return $isGranted || $container->get(\'security.authorization_checker\')->isGranted($role); }, false)', $roles);
 
                     return $code;
@@ -36,37 +36,37 @@  discard block
 block discarded – undo
 
             new ExpressionFunction(
                 'isAnonymous',
-                function () {
+                function() {
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_ANONYMOUSLY\')';
                 }
             ),
 
             new ExpressionFunction(
                 'isRememberMe',
-                function () {
+                function() {
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\')';
                 }
             ),
 
             new ExpressionFunction(
                 'isFullyAuthenticated',
-                function () {
+                function() {
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
                 },
-                function () {
+                function() {
                 }
             ),
 
             new ExpressionFunction(
                 'isAuthenticated',
-                function () {
+                function() {
                     return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\') || $container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
                 }
             ),
 
             new ExpressionFunction(
                 'hasPermission',
-                function ($object, $permission) {
+                function($object, $permission) {
                     $code = sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s, %s)', $permission, $object);
 
                     return $code;
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
 
             new ExpressionFunction(
                 'hasAnyPermission',
-                function ($object, $permissions) {
+                function($object, $permissions) {
                     $code = sprintf('array_reduce(%s, function ($isGranted, $permission) use ($container, $object) { return $isGranted || $container->get(\'security.authorization_checker\')->isGranted($permission, %s); }, false)', $permissions, $object);
 
                     return $code;

Please login to merge, or discard this patch.

ExpressionLanguage/ConfigExpressionProvider.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -21,35 +21,35 @@  discard block
 block discarded – undo
         return [
             new ExpressionFunction(
                 'service',
-                function ($value) {
+                function($value) {
                     return sprintf('$container->get(%s)', $value);
                 }
             ),
 
             new ExpressionFunction(
                 'parameter',
-                function ($value) {
+                function($value) {
                     return sprintf('$container->getParameter(%s)', $value);
                 }
             ),
 
             new ExpressionFunction(
                 'isTypeOf',
-                function ($className) {
+                function($className) {
                     return sprintf('($className = %s) && $value instanceof $className', $className);
                 }
             ),
 
             new ExpressionFunction(
                 'resolver',
-                function ($alias, $args = '[]') {
+                function($alias, $args = '[]') {
                     return sprintf('$container->get(\'overblog_graphql.resolver_resolver\')->resolve([%s, %s])', $alias, $args);
                 }
             ),
 
             new ExpressionFunction(
                 'mutateAndGetPayloadCallback',
-                function ($mutateAndGetPayload) {
+                function($mutateAndGetPayload) {
                     $code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
                     $code .= 'return '.$mutateAndGetPayload.'; }';
 
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
 
             new ExpressionFunction(
                 'idFetcherCallback',
-                function ($idFetcher) {
+                function($idFetcher) {
                     $code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
                     $code .= 'return '.$idFetcher.'; }';
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
 
             new ExpressionFunction(
                 'resolveSingleInputCallback',
-                function ($resolveSingleInput) {
+                function($resolveSingleInput) {
                     $code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
                     $code .= 'return '.$resolveSingleInput.'; }';
 
@@ -79,14 +79,14 @@  discard block
 block discarded – undo
 
             new ExpressionFunction(
                 'mutation',
-                function ($alias, $args = '[]') {
+                function($alias, $args = '[]') {
                     return sprintf('$container->get(\'overblog_graphql.mutation_resolver\')->resolve([%s, %s])', $alias, $args);
                 }
             ),
 
             new ExpressionFunction(
                 'globalId',
-                function ($id, $typeName = null) {
+                function($id, $typeName = null) {
                     $typeNameEmpty = null === $typeName || '""' === $typeName || 'null' === $typeName || 'false' === $typeName;
 
                     return sprintf(
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
 
             new ExpressionFunction(
                 'fromGlobalId',
-                function ($globalId) {
+                function($globalId) {
                     return sprintf(
                         '\\Overblog\\GraphQLBundle\\Relay\\Node\\GlobalId::fromGlobalId(%s)',
                         $globalId
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
 
             new ExpressionFunction(
                 'newObject',
-                function ($className, $args = '[]') {
+                function($className, $args = '[]') {
                     return sprintf('(new \ReflectionClass(%s))->newInstanceArgs(%s)', $className, $args);
                 }
             ),

Please login to merge, or discard this patch.

		@@ -20,14 +20,14 @@ discard block
		block discarded – undo
20	20	return [
21	21	new ExpressionFunction(
22	22	'hasRole',
23		- function ($role) {
	23	+ function($role) {
24	24	return sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s)', $role);
25	25	}
26	26	),
27	27
28	28	new ExpressionFunction(
29	29	'hasAnyRole',
30		- function ($roles) {
	30	+ function($roles) {
31	31	$code = sprintf('array_reduce(%s, function ($isGranted, $role) use ($container) { return $isGranted \|\| $container->get(\'security.authorization_checker\')->isGranted($role); }, false)', $roles);
32	32
33	33	return $code;
		@@ -36,37 +36,37 @@ discard block
		block discarded – undo
36	36
37	37	new ExpressionFunction(
38	38	'isAnonymous',
39		- function () {
	39	+ function() {
40	40	return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_ANONYMOUSLY\')';
41	41	}
42	42	),
43	43
44	44	new ExpressionFunction(
45	45	'isRememberMe',
46		- function () {
	46	+ function() {
47	47	return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\')';
48	48	}
49	49	),
50	50
51	51	new ExpressionFunction(
52	52	'isFullyAuthenticated',
53		- function () {
	53	+ function() {
54	54	return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
55	55	},
56		- function () {
	56	+ function() {
57	57	}
58	58	),
59	59
60	60	new ExpressionFunction(
61	61	'isAuthenticated',
62		- function () {
	62	+ function() {
63	63	return '$container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_REMEMBERED\') \|\| $container->get(\'security.authorization_checker\')->isGranted(\'IS_AUTHENTICATED_FULLY\')';
64	64	}
65	65	),
66	66
67	67	new ExpressionFunction(
68	68	'hasPermission',
69		- function ($object, $permission) {
	69	+ function($object, $permission) {
70	70	$code = sprintf('$container->get(\'security.authorization_checker\')->isGranted(%s, %s)', $permission, $object);
71	71
72	72	return $code;
		@@ -75,7 +75,7 @@ discard block
		block discarded – undo
75	75
76	76	new ExpressionFunction(
77	77	'hasAnyPermission',
78		- function ($object, $permissions) {
	78	+ function($object, $permissions) {
79	79	$code = sprintf('array_reduce(%s, function ($isGranted, $permission) use ($container, $object) { return $isGranted \|\| $container->get(\'security.authorization_checker\')->isGranted($permission, %s); }, false)', $permissions, $object);
80	80
81	81	return $code;

		@@ -21,35 +21,35 @@ discard block
		block discarded – undo
21	21	return [
22	22	new ExpressionFunction(
23	23	'service',
24		- function ($value) {
	24	+ function($value) {
25	25	return sprintf('$container->get(%s)', $value);
26	26	}
27	27	),
28	28
29	29	new ExpressionFunction(
30	30	'parameter',
31		- function ($value) {
	31	+ function($value) {
32	32	return sprintf('$container->getParameter(%s)', $value);
33	33	}
34	34	),
35	35
36	36	new ExpressionFunction(
37	37	'isTypeOf',
38		- function ($className) {
	38	+ function($className) {
39	39	return sprintf('($className = %s) && $value instanceof $className', $className);
40	40	}
41	41	),
42	42
43	43	new ExpressionFunction(
44	44	'resolver',
45		- function ($alias, $args = '[]') {
	45	+ function($alias, $args = '[]') {
46	46	return sprintf('$container->get(\'overblog_graphql.resolver_resolver\')->resolve([%s, %s])', $alias, $args);
47	47	}
48	48	),
49	49
50	50	new ExpressionFunction(
51	51	'mutateAndGetPayloadCallback',
52		- function ($mutateAndGetPayload) {
	52	+ function($mutateAndGetPayload) {
53	53	$code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
54	54	$code .= 'return '.$mutateAndGetPayload.'; }';
55	55
		@@ -59,7 +59,7 @@ discard block
		block discarded – undo
59	59
60	60	new ExpressionFunction(
61	61	'idFetcherCallback',
62		- function ($idFetcher) {
	62	+ function($idFetcher) {
63	63	$code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
64	64	$code .= 'return '.$idFetcher.'; }';
65	65
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69
70	70	new ExpressionFunction(
71	71	'resolveSingleInputCallback',
72		- function ($resolveSingleInput) {
	72	+ function($resolveSingleInput) {
73	73	$code = 'function ($value) use ('.TypeGenerator::USE_FOR_CLOSURES.', $args, $info) { ';
74	74	$code .= 'return '.$resolveSingleInput.'; }';
75	75
		@@ -79,14 +79,14 @@ discard block
		block discarded – undo
79	79
80	80	new ExpressionFunction(
81	81	'mutation',
82		- function ($alias, $args = '[]') {
	82	+ function($alias, $args = '[]') {
83	83	return sprintf('$container->get(\'overblog_graphql.mutation_resolver\')->resolve([%s, %s])', $alias, $args);
84	84	}
85	85	),
86	86
87	87	new ExpressionFunction(
88	88	'globalId',
89		- function ($id, $typeName = null) {
	89	+ function($id, $typeName = null) {
90	90	$typeNameEmpty = null === $typeName \|\| '""' === $typeName \|\| 'null' === $typeName \|\| 'false' === $typeName;
91	91
92	92	return sprintf(
		@@ -99,7 +99,7 @@ discard block
		block discarded – undo
99	99
100	100	new ExpressionFunction(
101	101	'fromGlobalId',
102		- function ($globalId) {
	102	+ function($globalId) {
103	103	return sprintf(
104	104	'\\Overblog\\GraphQLBundle\\Relay\\Node\\GlobalId::fromGlobalId(%s)',
105	105	$globalId
		@@ -109,7 +109,7 @@ discard block
		block discarded – undo
109	109
110	110	new ExpressionFunction(
111	111	'newObject',
112		- function ($className, $args = '[]') {
	112	+ function($className, $args = '[]') {
113	113	return sprintf('(new \ReflectionClass(%s))->newInstanceArgs(%s)', $className, $args);
114	114	}
115	115	),

Scrutinizer GitHub App not installed

Push — master ( eed88d...353bdf )

Status

Category

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Push — master ( eed88d...353bdf )

Status

Category

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch