FieldsTrait::getFields() - Code Metrics - Inspection of "Query complexity security" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#23)

by Jérémiah

created 2016-04-02 20:29 UTC

FieldsTrait::getFields() A

↳ Parent: FieldsTrait

Complexity

Conditions	4
Paths	5

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
ccs	7
cts	7
cp	1
rs	9.2
cc	4
eloc	6
nc	5
nop	0
crap	4

<?php

/*
 * This file is part of the OverblogGraphQLBundle package.
 *
 * (c) Overblog <http://github.com/overblog/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Overblog\GraphQLBundle\Definition;

use GraphQL\Type\Definition\Config;
use GraphQL\Utils;

trait FieldsTrait
{
    /**
     * @var FieldDefinition[]
     */
    private $_fields;

    /**
     * @return FieldDefinition[]
     */
    public function getFields()
    {
        if (null === $this->_fields) {
            $fields = isset($this->config['fields']) ? $this->config['fields'] : [];
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $fields = is_callable($fields) ? call_user_func($fields) : $fields;
            $this->_fields = FieldDefinition::createMap($fields);
        }

        return $this->_fields;
    }

    /**
     * @param string $name
     *
     * @return FieldDefinition
     *
     * @throws \Exception
     */
    public function getField($name)
    {
        if (null === $this->_fields) {
            $this->getFields();
        }
        Utils::invariant(isset($this->_fields[$name]), "Field '%s' is not defined for type '%s'", $name, $this->name);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this->_fields[$name];
    }
}


1		<?php
2
3		/*
4		* This file is part of the OverblogGraphQLBundle package.
5		*
6		* (c) Overblog <http://github.com/overblog/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Overblog\GraphQLBundle\Definition;
13
14		use GraphQL\Type\Definition\Config;
15		use GraphQL\Utils;
16
17		trait FieldsTrait
18		{
19		/**
20		* @var FieldDefinition[]
21		*/
22		private $_fields;
23
24		/**
25		* @return FieldDefinition[]
26		*/
27	80	public function getFields()
28		{
29	80	if (null === $this->_fields) {
30	37	$fields = isset($this->config['fields']) ? $this->config['fields'] : [];
		0 ignored issues – show Bug introduced 2016-04-02 20:15 UTC by Report Bug Copy Issue Report The property `config` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31	37	$fields = is_callable($fields) ? call_user_func($fields) : $fields;
32	37	$this->_fields = FieldDefinition::createMap($fields);
33	37	}
34
35	80	return $this->_fields;
36		}
37
38		/**
39		* @param string $name
40		*
41		* @return FieldDefinition
42		*
43		* @throws \Exception
44		*/
45		public function getField($name)
46		{
47		if (null === $this->_fields) {
48		$this->getFields();
49		}
50		Utils::invariant(isset($this->_fields[$name]), "Field '%s' is not defined for type '%s'", $name, $this->name);
		0 ignored issues – show Bug introduced 2016-04-02 20:15 UTC by Report Bug Copy Issue Report The property `name` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
51
52		return $this->_fields[$name];
53		}
54		}
55

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#23)

FieldsTrait::getFields() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like