Overblog\GraphQLBundle\Relay\Connection\Output\DeprecatedPropertyPublicAccessTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

95.24%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__get()	0	4	1
A	__set()	0	4	1
A	accessProperty()	0	29	3

<?php

declare(strict_types=1);

namespace Overblog\GraphQLBundle\Relay\Connection\Output;

/**
 * @internal
 */
trait DeprecatedPropertyPublicAccessTrait
{
    public function __get($name)
    {
        return $this->accessProperty('get', $name);
    }

    public function __set($name, $value)
    {
        return $this->accessProperty('set', $name, $value);
    }

    private function accessProperty(string $type, string $name, $value = null)
    {
        if (\in_array($name, \array_keys(\get_object_vars($this)))) {
            $method = $type.\ucfirst($name);

            @\trigger_error(

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                \sprintf(
                    '%sting directly property %s::$%s value is deprecated as of 0.12 and will be removed in 0.13. '.
                    'You should now use method %s::%s.',
                    \ucfirst($type),
                    __CLASS__,
                    $name,
                    __CLASS__,
                    $method
                ),
                \E_USER_DEPRECATED
            );

            return $this->$method($value);
        }

        if ('set' === $type) {
            $this->$name = $value;

            return null;
        } else {
            return $this->$name;
        }
    }
}