GraphController::treatNormalQuery() - Code Metrics - Inspection of "Add a batching layer" - overblog/GraphQLBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#18)

by Jérémiah

created 2016-03-24 16:28 UTC

GraphController::treatNormalQuery() A

↳ Parent: GraphController

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	7
ccs	4
cts	4
cp	1
rs	9.4285
cc	1
eloc	4
nc	1
nop	1
crap	1

<?php

/*
 * This file is part of the OverblogGraphQLBundle package.
 *
 * (c) Overblog <http://github.com/overblog/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Overblog\GraphQLBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;

class GraphController extends Controller
{
    public function endpointAction(Request $request)
    {
        if ($request->query->has('batch')) {
            $data = $this->treatBatchQuery($request);
        } else {
            $data = $this->treatNormalQuery($request);
        }

        return new JsonResponse($data, 200);
    }

    private function treatBatchQuery(Request $request)
    {
        $params = $this->get('overblog_graphql.request_batch_parser')->parse($request);
        $data = [];

        foreach ($params as $i => $entry) {
            $data[$i] = $this->get('overblog_graphql.request_executor')->execute($entry)->toArray();
        }

        return $data;
    }

    private function treatNormalQuery(Request $request)
    {
        $params = $this->get('overblog_graphql.request_parser')->parse($request);
        $data = $this->get('overblog_graphql.request_executor')->execute($params)->toArray();

        return $data;
    }
}


1		<?php
2
3		/*
4		* This file is part of the OverblogGraphQLBundle package.
5		*
6		* (c) Overblog <http://github.com/overblog/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Overblog\GraphQLBundle\Controller;
13
14		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
15		use Symfony\Component\HttpFoundation\JsonResponse;
16		use Symfony\Component\HttpFoundation\Request;
17
18		class GraphController extends Controller
19		{
20	11	public function endpointAction(Request $request)
21		{
22	11	if ($request->query->has('batch')) {
23	5	$data = $this->treatBatchQuery($request);
24	1	} else {
25	6	$data = $this->treatNormalQuery($request);
26		}
27
28	4	return new JsonResponse($data, 200);
29		}
30
31	5	private function treatBatchQuery(Request $request)
32		{
33	5	$params = $this->get('overblog_graphql.request_batch_parser')->parse($request);
34	1	$data = [];
35
36	1	foreach ($params as $i => $entry) {
37	1	$data[$i] = $this->get('overblog_graphql.request_executor')->execute($entry)->toArray();
38	1	}
39
40	1	return $data;
41		}
42
43	6	private function treatNormalQuery(Request $request)
44		{
45	6	$params = $this->get('overblog_graphql.request_parser')->parse($request);
46	3	$data = $this->get('overblog_graphql.request_executor')->execute($params)->toArray();
47
48	3	return $data;
49		}
50		}
51

overblog / GraphQLBundle

Scrutinizer GitHub App not installed

Pull Request — master (#18)

GraphController::treatNormalQuery() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like