StorageArrayTest::testSetError() - Code Metrics - Inspection of "Added StorageList class and unitTest. Refactoring." - ossbrownie/util - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 579a8b...9acb0f )

by Oss

created 2017-10-25 15:24 UTC

StorageArrayTest::testSetError() A

↳ Parent: StorageArrayTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	0

<?php

use Brownie\Util\StorageArray;

class StorageArrayTest extends PHPUnit_Framework_TestCase
namespace YourVendor;

class YourClass { }
{

    protected function setUp()
    {
    }

    protected function tearDown()
    {
    }

    public function testConstructorOk1()

    {
        $fields = array(
            'question1' => 'answer1',
            'question2' => 'answer2',
        );
        $arrayList = new StorageArray($fields, true);
        $this->assertEquals($fields, $arrayList->toArray());
    }

    public function testConstructorOk2()
    {
        $fields = array();
        $arrayList = new StorageArray($fields, false);
        $this->assertEquals($fields, $arrayList->toArray());
    }

    /**
     * @expectedException \Brownie\Util\Exception\UndefinedMethodException
     */
    public function testConstructorError()

    {
        $fields = array(
            'question1' => 'answer1',
            'question2' => 'answer2',
        );
        $arrayList = new StorageArray($fields);
        $this->assertEquals($fields, $arrayList->toArray());
    }

    public function testSetGetOk()
    {
        $fields = array(
            'question1' => 'answer1',
            'question2' => 'answer2',
        );
        $newvalue = 'answer3';
        $arrayList = new StorageArray($fields, true);
        $arrayList->setQuestion2('answer3');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $fields['question2'] = $newvalue;
        $this->assertEquals($fields, $arrayList->toArray());
        $this->assertEquals($newvalue, $arrayList->getQuestion2());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * @expectedException \Brownie\Util\Exception\UndefinedMethodException
     */
    public function testSetError()

    {
        $fields = array(
            'question1' => 'answer1',
            'question2' => 'answer2',
        );
        $arrayList = new StorageArray($fields, true);
        $arrayList->setQuestion3('answer3');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->assertEquals($fields, $arrayList->toArray());
    }

    /**
     * @expectedException \Brownie\Util\Exception\UndefinedMethodException
     */
    public function testGetError()

    {
        $fields = array(
            'question1' => 'answer1',
            'question2' => 'answer2',
        );
        $newvalue = 'answer3';
        $arrayList = new StorageArray($fields, true);
        $this->assertEquals($newvalue, $arrayList->getQuestion3('answer3'));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
}


1		<?php
2
3		use Brownie\Util\StorageArray;
4
5		class StorageArrayTest extends PHPUnit_Framework_TestCase
		0 ignored issues – show Coding Style Compatibility introduced 2017-10-25 15:26 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6		{
7
8		protected function setUp()
9		{
10		}
11
12		protected function tearDown()
13		{
14		}
15
16	View Code Duplication	public function testConstructorOk1()
		0 ignored issues – show Duplication introduced 2017-10-25 15:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18		$fields = array(
19		'question1' => 'answer1',
20		'question2' => 'answer2',
21		);
22		$arrayList = new StorageArray($fields, true);
23		$this->assertEquals($fields, $arrayList->toArray());
24		}
25
26		public function testConstructorOk2()
27		{
28		$fields = array();
29		$arrayList = new StorageArray($fields, false);
30		$this->assertEquals($fields, $arrayList->toArray());
31		}
32
33		/**
34		* @expectedException \Brownie\Util\Exception\UndefinedMethodException
35		*/
36	View Code Duplication	public function testConstructorError()
		0 ignored issues – show Duplication introduced 2017-10-12 16:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		$fields = array(
39		'question1' => 'answer1',
40		'question2' => 'answer2',
41		);
42		$arrayList = new StorageArray($fields);
43		$this->assertEquals($fields, $arrayList->toArray());
44		}
45
46		public function testSetGetOk()
47		{
48		$fields = array(
49		'question1' => 'answer1',
50		'question2' => 'answer2',
51		);
52		$newvalue = 'answer3';
53		$arrayList = new StorageArray($fields, true);
54		$arrayList->setQuestion2('answer3');
		0 ignored issues – show Documentation Bug introduced 2017-10-25 15:26 UTC by Report Bug Copy Issue Report The method `setQuestion2` does not exist on `object<Brownie\Util\StorageArray>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
55		$fields['question2'] = $newvalue;
56		$this->assertEquals($fields, $arrayList->toArray());
57		$this->assertEquals($newvalue, $arrayList->getQuestion2());
		0 ignored issues – show Documentation Bug introduced 2017-10-25 15:26 UTC by Report Bug Copy Issue Report The method `getQuestion2` does not exist on `object<Brownie\Util\StorageArray>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
58		}
59
60		/**
61		* @expectedException \Brownie\Util\Exception\UndefinedMethodException
62		*/
63	View Code Duplication	public function testSetError()
		0 ignored issues – show Duplication introduced 2017-10-12 16:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$fields = array(
66		'question1' => 'answer1',
67		'question2' => 'answer2',
68		);
69		$arrayList = new StorageArray($fields, true);
70		$arrayList->setQuestion3('answer3');
		0 ignored issues – show Documentation Bug introduced 2017-10-25 15:26 UTC by Report Bug Copy Issue Report The method `setQuestion3` does not exist on `object<Brownie\Util\StorageArray>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
71		$this->assertEquals($fields, $arrayList->toArray());
72		}
73
74		/**
75		* @expectedException \Brownie\Util\Exception\UndefinedMethodException
76		*/
77	View Code Duplication	public function testGetError()
		0 ignored issues – show Duplication introduced 2017-10-12 16:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		{
79		$fields = array(
80		'question1' => 'answer1',
81		'question2' => 'answer2',
82		);
83		$newvalue = 'answer3';
84		$arrayList = new StorageArray($fields, true);
85		$this->assertEquals($newvalue, $arrayList->getQuestion3('answer3'));
		0 ignored issues – show Documentation Bug introduced 2017-10-25 15:26 UTC by Report Bug Copy Issue Report The method `getQuestion3` does not exist on `object<Brownie\Util\StorageArray>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
86		}
87		}
88

ossbrownie / util

Push — master ( 579a8b...9acb0f )

StorageArrayTest::testSetError() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like