CookieList::getCookieParams() - Code Metrics - Inspection of "Refactoring." - ossbrownie/http-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c65e58...1194b0 )

by Oss

created 2017-11-03 04:44 UTC

CookieList::getCookieParams() A

↳ Parent: CookieList

Complexity

Conditions	4
Paths	5

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	4

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	16
ccs	13
cts	13
cp	1
rs	9.2
cc	4
eloc	12
nc	5
nop	1
crap	4

<?php
/**
 * @category    Brownie/HttpClient
 * @author      Brownie <[email protected]>
 * @license     http://www.gnu.org/copyleft/lesser.html
 */

namespace Brownie\HttpClient\Cookie;

use Brownie\HttpClient\HeadList;

class CookieList extends HeadList
{

    /**
     * Initializing the cookies container.
     */
    protected function initList()

    {
        $cookieList = array();
        foreach (explode("\r\n", trim($this->getInitData())) as $headerLine) {
            if (empty($headerLine)) {
                $cookieList = array();
                continue;
            }
            if (!$this->isHeaderSetCookie($headerLine)) {
                continue;
            }
            $cookieParams = $this->getCookieParams($headerLine);
            $cookieList[$cookieParams['name']] = new Cookie($cookieParams);
        }
        $this->setList($cookieList);
    }

    /**
     * Splits HTTP header on the parameters.
     *
     * @param string    $headerLine     HTTP header line Set-Cookie.
     *
     * @return array
     */
    private function getCookieParams($headerLine)
    {
        $cookieParamsStrings = explode(':', trim($headerLine), 2);
        $params = array();
        foreach (explode(';', trim($cookieParamsStrings[1])) as $index => $paramString) {
            $pairParam = explode('=', trim($paramString), 2);
            $name = trim($pairParam[0]);
            $value = (!empty($pairParam[1]) ? trim($pairParam[1]) : true);
            if (0 == $index) {
                $params['name'] = $name;
                $params['value'] = $value;
                continue;
            }
            $params[$name] = $value;
        }
        return $params;
    }
}


1			<?php
2			/**
3			* @category Brownie/HttpClient
4			* @author Brownie <[email protected]>
5			* @license http://www.gnu.org/copyleft/lesser.html
6			*/
7
8			namespace Brownie\HttpClient\Cookie;
9
10			use Brownie\HttpClient\HeadList;
11
12			class CookieList extends HeadList
13			{
14
15			/**
16			* Initializing the cookies container.
17			*/
18	3	View Code Duplication	protected function initList()
			0 ignored issues – show Duplication introduced 2017-11-03 04:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19			{
20	3		$cookieList = array();
21	3		foreach (explode("\r\n", trim($this->getInitData())) as $headerLine) {
22	3		if (empty($headerLine)) {
23	2		$cookieList = array();
24	2		continue;
25			}
26	2		if (!$this->isHeaderSetCookie($headerLine)) {
27	2		continue;
28			}
29	2		$cookieParams = $this->getCookieParams($headerLine);
30	2		$cookieList[$cookieParams['name']] = new Cookie($cookieParams);
31			}
32	3		$this->setList($cookieList);
33	3		}
34
35			/**
36			* Splits HTTP header on the parameters.
37			*
38			* @param string $headerLine HTTP header line Set-Cookie.
39			*
40			* @return array
41			*/
42	2		private function getCookieParams($headerLine)
43			{
44	2		$cookieParamsStrings = explode(':', trim($headerLine), 2);
45	2		$params = array();
46	2		foreach (explode(';', trim($cookieParamsStrings[1])) as $index => $paramString) {
47	2		$pairParam = explode('=', trim($paramString), 2);
48	2		$name = trim($pairParam[0]);
49	2		$value = (!empty($pairParam[1]) ? trim($pairParam[1]) : true);
50	2		if (0 == $index) {
51	2		$params['name'] = $name;
52	2		$params['value'] = $value;
53	2		continue;
54			}
55	1		$params[$name] = $value;
56			}
57	2		return $params;
58			}
59			}
60

ossbrownie / http-client

Push — master ( c65e58...1194b0 )

CookieList::getCookieParams() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like