Parameter::__construct() - Code Metrics - Inspection of "Added unit tests and refactoring." - ossbrownie/bpm-online - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 475bfc...ca0e1d )

by Oss

created 2019-03-11 17:00 UTC

Parameter::__construct() A

↳ Parent: Parameter

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	1

<?php
/**
 * @category    Brownie/BpmOnline
 * @author      Brownie <[email protected]>
 * @license     https://opensource.org/licenses/MIT
 */

namespace Brownie\BpmOnline\DataService\Column\Expression;

use Brownie\BpmOnline\DataService\Type\DataValueType;
use Brownie\BpmOnline\Exception\ValidateException;
use Brownie\BpmOnline\DataService\Column\Expression;

/**
 * The Parameter class is defined in the Terrasoft.Nui.ServiceModel.DataContract namespace.
 *
 * @method bool         getArrayValue()                     Returns an array of column values.
 * @method bool         setArrayValue(array $values)        Sets an array of values column.
 * @method bool         getShouldSkipConvertion()           Returns the flag to skip the cast process.
 * @method Parameter    setShouldSkipConvertion($isSkip)    Sets the flag to skip the cast process.
 *                                                          for the Value property.
 */
class Parameter extends Expression
{

    const GUID = 0;

    const TEXT = 1;

    const INTEGER = 4;

    const FLOAT = 5;

    const MONEY = 6;

    const DATE_TIME = 7;

    const DATE = 8;

    const TIME = 9;

    const LOOKUP = 10;

    const ENUM = 11;

    const BOOLEAN = 12;

    const BLOB = 13;

    const IMAGE = 14;

    const IMAGE_LOOKUP = 16;

    const COLOR = 18;

    const MAPPING = 26;

    protected $keyName = 'Parameter';

    /**
     * Sets the input values.
     *
     * @param mixed     $value          Value.
     * @param int       $valueType      Data value type.
     */
    public function __construct($value, $valueType = self::TEXT)
    {
        parent::__construct([
            'dataValueType' => $valueType,
            'value' => $value,
        ]);
    }

    /**
     * List of supported fields.
     *
     * @var array
     */
    protected $fields = [
        'dataValueType' => self::TEXT,
        'value' => '',
        'arrayValue' => [],
        'shouldSkipConvertion' => false,
    ];

    /**
     * Returns data as an associative array.
     *
     * @return array
     *
     * @throws ValidateException
     */
    public function getValue()
    {
        $data = [
            'DataValueType' => $this->getDataValueType(),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            'Value' => parent::getValue(),
        ];
        if (!empty($this->getArrayValue()) && is_array($this->getArrayValue())) {
            $data['ArrayValue'] = $this->getArrayValue();
        }
        if (!empty($this->getShouldSkipConvertion())) {
            $data['ShouldSkipConvertion'] = true;
        }
        return $data;
    }
}


1		<?php
2		/**
3		* @category Brownie/BpmOnline
4		* @author Brownie <[email protected]>
5		* @license https://opensource.org/licenses/MIT
6		*/
7
8		namespace Brownie\BpmOnline\DataService\Column\Expression;
9
10		use Brownie\BpmOnline\DataService\Type\DataValueType;
11		use Brownie\BpmOnline\Exception\ValidateException;
12		use Brownie\BpmOnline\DataService\Column\Expression;
13
14		/**
15		* The Parameter class is defined in the Terrasoft.Nui.ServiceModel.DataContract namespace.
16		*
17		* @method bool getArrayValue() Returns an array of column values.
18		* @method bool setArrayValue(array $values) Sets an array of values column.
19		* @method bool getShouldSkipConvertion() Returns the flag to skip the cast process.
20		* @method Parameter setShouldSkipConvertion($isSkip) Sets the flag to skip the cast process.
21		* for the Value property.
22		*/
23		class Parameter extends Expression
24		{
25
26		const GUID = 0;
27
28		const TEXT = 1;
29
30		const INTEGER = 4;
31
32		const FLOAT = 5;
33
34		const MONEY = 6;
35
36		const DATE_TIME = 7;
37
38		const DATE = 8;
39
40		const TIME = 9;
41
42		const LOOKUP = 10;
43
44		const ENUM = 11;
45
46		const BOOLEAN = 12;
47
48		const BLOB = 13;
49
50		const IMAGE = 14;
51
52		const IMAGE_LOOKUP = 16;
53
54		const COLOR = 18;
55
56		const MAPPING = 26;
57
58		protected $keyName = 'Parameter';
59
60		/**
61		* Sets the input values.
62		*
63		* @param mixed $value Value.
64		* @param int $valueType Data value type.
65		*/
66	4	public function __construct($value, $valueType = self::TEXT)
67		{
68	4	parent::__construct([
69	4	'dataValueType' => $valueType,
70	4	'value' => $value,
71		]);
72	4	}
73
74		/**
75		* List of supported fields.
76		*
77		* @var array
78		*/
79		protected $fields = [
80		'dataValueType' => self::TEXT,
81		'value' => '',
82		'arrayValue' => [],
83		'shouldSkipConvertion' => false,
84		];
85
86		/**
87		* Returns data as an associative array.
88		*
89		* @return array
90		*
91		* @throws ValidateException
92		*/
93	3	public function getValue()
94		{
95		$data = [
96	3	'DataValueType' => $this->getDataValueType(),
		0 ignored issues – show Documentation Bug introduced 2019-03-11 17:05 UTC by Report Bug Copy Issue Report The method `getDataValueType` does not exist on `object<Brownie\BpmOnline...n\Expression\Parameter>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
97	3	'Value' => parent::getValue(),
98		];
99	3	if (!empty($this->getArrayValue()) && is_array($this->getArrayValue())) {
100	1	$data['ArrayValue'] = $this->getArrayValue();
101		}
102	3	if (!empty($this->getShouldSkipConvertion())) {
103	1	$data['ShouldSkipConvertion'] = true;
104		}
105	3	return $data;
106		}
107		}
108

ossbrownie / bpm-online

Push — master ( 475bfc...ca0e1d )

Parameter::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like