ParameterTest - Code Metrics - Inspection of "Added unit tests and refactoring." - ossbrownie/bpm-online - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 475bfc...ca0e1d )

by Oss

created 2019-03-11 17:00 UTC

ParameterTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	59
Duplicated Lines	32.2 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	2
dl	19
loc	59
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	tearDown()	0	4	1
A	testGetKeyName()	0	4	1
A	testSetGetValue()	9	9	1
A	testArrayValue()	0	14	1
A	testShouldSkipConvertion()	10	10	1

How to fix Duplicated Code

<?php

namespace Test\Brownie\BpmOnline\DataService\Column\Expression;

use Brownie\BpmOnline\DataService\Column\Expression\Parameter;
use PHPUnit\Framework\TestCase;

class ParameterTest extends TestCase
{

    /**
     * @var Parameter
     */
    private $parameter;

    protected function setUp()
    {
        $this->parameter = new Parameter('Test', Parameter::TEXT);
    }

    protected function tearDown()
    {
        $this->parameter = null;
    }

    public function testGetKeyName()
    {
        $this->assertEquals('Parameter', $this->parameter->getKeyName());
    }

    public function testSetGetValue()

    {
        $parameter = $this->parameter->setValue('TestString');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->assertInstanceOf(Parameter::class, $parameter);
        $this->assertEquals([
            'DataValueType' => 1,
            'Value' => 'TestString'
        ], $this->parameter->getValue());
    }

    public function testArrayValue()
    {
        $parameter = $this->parameter->setArrayValue([
            'test' => 'ok'
        ]);
        $this->assertInstanceOf(Parameter::class, $parameter);
        $this->assertEquals([
            'DataValueType' => 1,
            'Value' => 'Test',
            'ArrayValue' => [
                'test' => 'ok',
            ],
        ], $this->parameter->getValue());
    }

    public function testShouldSkipConvertion()

    {
        $parameter = $this->parameter->setShouldSkipConvertion(true);
        $this->assertInstanceOf(Parameter::class, $parameter);
        $this->assertEquals([
            'DataValueType' => 1,
            'Value' => 'Test',
            'ShouldSkipConvertion' => true,
        ], $this->parameter->getValue());
    }
}


1		<?php
2
3		namespace Test\Brownie\BpmOnline\DataService\Column\Expression;
4
5		use Brownie\BpmOnline\DataService\Column\Expression\Parameter;
6		use PHPUnit\Framework\TestCase;
7
8		class ParameterTest extends TestCase
9		{
10
11		/**
12		* @var Parameter
13		*/
14		private $parameter;
15
16		protected function setUp()
17		{
18		$this->parameter = new Parameter('Test', Parameter::TEXT);
19		}
20
21		protected function tearDown()
22		{
23		$this->parameter = null;
24		}
25
26		public function testGetKeyName()
27		{
28		$this->assertEquals('Parameter', $this->parameter->getKeyName());
29		}
30
31	View Code Duplication	public function testSetGetValue()
		0 ignored issues – show Duplication introduced 2019-03-11 17:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33		$parameter = $this->parameter->setValue('TestString');
		0 ignored issues – show Documentation Bug introduced 2019-03-11 17:05 UTC by Report Bug Copy Issue Report The method `setValue` does not exist on `object<Brownie\BpmOnline...n\Expression\Parameter>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
34		$this->assertInstanceOf(Parameter::class, $parameter);
35		$this->assertEquals([
36		'DataValueType' => 1,
37		'Value' => 'TestString'
38		], $this->parameter->getValue());
39		}
40
41		public function testArrayValue()
42		{
43		$parameter = $this->parameter->setArrayValue([
44		'test' => 'ok'
45		]);
46		$this->assertInstanceOf(Parameter::class, $parameter);
47		$this->assertEquals([
48		'DataValueType' => 1,
49		'Value' => 'Test',
50		'ArrayValue' => [
51		'test' => 'ok',
52		],
53		], $this->parameter->getValue());
54		}
55
56	View Code Duplication	public function testShouldSkipConvertion()
		0 ignored issues – show Duplication introduced 2019-03-11 17:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		{
58		$parameter = $this->parameter->setShouldSkipConvertion(true);
59		$this->assertInstanceOf(Parameter::class, $parameter);
60		$this->assertEquals([
61		'DataValueType' => 1,
62		'Value' => 'Test',
63		'ShouldSkipConvertion' => true,
64		], $this->parameter->getValue());
65		}
66		}
67

ossbrownie / bpm-online

Push — master ( 475bfc...ca0e1d )

ParameterTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like