osci.dialog.FleetsOverviewDlg.FleetsOverviewDlg.show() - Code Metrics - Inspection of "Cleaning scrut hotspots" - ospaceteam/outerspace - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#291)

by Marek

created 2020-01-25 19:03 UTC

FleetsOverviewDlg.show() F

↳ Parent: osci.dialog.FleetsOverviewDlg

Complexity

Conditions

Size

Total Lines	100
Code Lines	77

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	24
eloc	77
nop	1
dl	0
loc	100
rs	0
c	0
b	0
f	0

How to fix Long Method Complexity

#
#  Copyright 2001 - 2016 Ludek Smid [http://www.ospace.net/]
#
#  This file is part of Outer Space.
#
#  Outer Space is free software; you can redistribute it and/or modify
#  it under the terms of the GNU General Public License as published by
#  the Free Software Foundation; either version 2 of the License, or
#  (at your option) any later version.
#
#  Outer Space is distributed in the hope that it will be useful,
#  but WITHOUT ANY WARRANTY; without even the implied warranty of
#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
#  GNU General Public License for more details.
#
#  You should have received a copy of the GNU General Public License
#  along with Outer Space; if not, write to the Free Software
#  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
#

import pygameui as ui
from osci.StarMapWidget import StarMapWidget
from osci import gdata, res, client
import ige.ospace.Const as Const
from ige.ospace import Rules
import math

class FleetsOverviewDlg:

    def __init__(self, app):
        self.app = app
        self.createUI()

    def display(self):
        if gdata.config.defaults.showredirects != None:
            val = gdata.config.defaults.showredirects
            self.win.vRedirects.checked = val == 'yes'

        self.show()
        self.win.show()
        # register for updates
        if self not in gdata.updateDlgs:
            gdata.updateDlgs.append(self)

    def hide(self):
        self.win.setStatus(_("Ready."))
        self.win.hide()
        # unregister updates
        if self in gdata.updateDlgs:
            gdata.updateDlgs.remove(self)

    def update(self):
        self.show()

    def _analyzeRelations(self, playerID, fleet):
        # this evaluates color, and if it should be shown at all
        # get check box selections
        mine = self.win.vMine.checked
        enemy = self.win.vEnemy.checked
        unfriendly = self.win.vUnfriendy.checked
        neutral = self.win.vNeutral.checked
        friendly = self.win.vFriendly.checked
        allied = self.win.vAllied.checked
        redirects = self.win.vRedirects.checked

        # check fleet color and decide if display the fleet
        if hasattr(fleet, 'owner'):
            plRelation = client.getRelationTo(fleet.owner)
            fgColor = res.getPlayerColor(fleet.owner)
            ok = 0
            if mine and fleet.owner == playerID:
                ok = 1
            elif enemy and plRelation >= Const.REL_ENEMY_LO and plRelation < Const.REL_ENEMY_HI:
                ok = 1
            elif unfriendly and plRelation >= Const.REL_UNFRIENDLY_LO and plRelation < Const.REL_UNFRIENDLY_HI:
                ok = 1
            elif neutral and plRelation >= Const.REL_NEUTRAL_LO and plRelation < Const.REL_NEUTRAL_HI:
                ok = 1
            elif friendly and plRelation >= Const.REL_FRIENDLY_LO and plRelation < Const.REL_FRIENDLY_HI:
                ok = 1
            elif allied and plRelation >= Const.REL_ALLY_LO and plRelation < Const.REL_ALLY_HI:
                ok = 1

            if not ok:
                return None
        else:
            if not enemy:
                return None
            # with no owner assume enemy
            fgColor = res.getFFColorCode(0) #enemy
        return fgColor

    def show(self):
        player = client.getPlayer()
        items = []
        for fleetID in client.db.keys():
            fleet = client.get(fleetID, noUpdate = 1)
            # skip non-fleets
            if not hasattr(fleet, "type") or fleet.type != Const.T_FLEET:
                continue
            fgColor = self._analyzeRelations(player.oid, fleet)
            if fgColor is None:
                # nothing to show
                continue

            if hasattr(fleet, 'owner') and player.oid != fleet.owner:
                owner = getattr(client.get(fleet.owner, noUpdate = 1), "name", res.getUnknownName())
                ownerName = " (%s)" % owner
                ownerNameTip = owner
                ownerTipTitle = _("Owner")
            else:
                ownerName = ""
                ownerNameTip = ""
                ownerTipTitle = ""

            # check position of fleet
            system = None
            systemName = "-"
            if hasattr(fleet, 'orbiting') and fleet.orbiting:
                system = client.get(fleet.orbiting, noUpdate = 1)
                systemName = getattr(system, "name", res.getUnknownName())
            elif hasattr(fleet, 'closeSystem'):
                system = client.get(fleet.closeSystem, noUpdate = 1)
                systemName = _("%s (dst)") % getattr(system, "name", res.getUnknownName())

            # get fleet current action and target of action
            order = "-"
            targetName = "-"
            if hasattr(fleet, 'actions') and fleet.actionIndex < len(fleet.actions):
                action, target, data  = fleet.actions[fleet.actionIndex]
                if action == Const.FLACTION_REDIRECT and not redirects:

                    continue
                order = gdata.fleetActions[action]
                if target != Const.OID_NONE:
                    targetName = getattr(client.get(target, noUpdate = 1), 'name', res.getUnknownName())
                    order = "%s %s" % (order, targetName)
            # eta
            if hasattr(fleet, "eta"): eta = res.formatTime(fleet.eta)
            else: eta = "?"

            # fuel
            if hasattr(fleet, "storEn"):
                if fleet.maxEn > 0: fuel = 100 * fleet.storEn / fleet.maxEn
                else: fuel = 0
            else:
                fuel = "?"

            # operational time
            if hasattr(fleet, 'storEn') and hasattr(fleet, 'operEn'):
                turns = 100000
                if fleet.operEn > 0: turns = fleet.storEn / fleet.operEn
                rawRange = turns * fleet.speed / Rules.turnsPerDay
                range = "%.2f" % rawRange
                opTime = res.formatTime(turns)
            else:
                rawRange = 0
                range = "?"
                opTime = "?"

            # last upgrade
            if hasattr(fleet, "lastUpgrade"):
                lastUpgrade = res.formatTime(fleet.lastUpgrade)
            else:
                lastUpgrade = "?"

            if hasattr(fleet,'customname') and fleet.customname:
                fleetname = fleet.customname
            else:
                fleetname = getattr(fleet, 'name', res.getUnknownName())

            # create ListBox Item for fleet
            item = ui.Item(
                "%s %s" % (fleetname, ownerName),
                tooltipTitle = ownerTipTitle,
                tooltip = ownerNameTip,
                tLocation = systemName,
                tOrder = order,
                tMP = getattr(fleet, "combatPwr", "?"),
                tETA = eta,
                tETA_raw = getattr(fleet, "eta", 0),
                tSignature = getattr(fleet, "signature", "?"),
                tFuel = fuel,
                tOpTime = opTime,
                tRange = range,
                tRange_raw = rawRange,
                tLastUpgrade = lastUpgrade,
                tFleetID = fleetID,
                foreground = fgColor)
            items.append(item)

        self.win.vFleets.items = items
        self.win.vFleets.itemsChanged()

    def onSelectFleet(self, widget, action, data):
        item = self.win.vFleets.selection[0]
        fleet = client.get(item.tFleetID, noUpdate = 1)
        if hasattr(fleet, "owner") and fleet.owner == client.getPlayerID():
            # show dialog
            gdata.mainGameDlg.onSelectMapObj(None, None, item.tFleetID)
        else:
            # center fleet on map
            if hasattr(fleet, "x"):
                gdata.mainGameDlg.win.vStarMap.highlightPos = (fleet.x, fleet.y)
                gdata.mainGameDlg.win.vStarMap.setPos(fleet.x, fleet.y)
                self.hide()
                return
            self.win.setStatus(_("Cannot show location"))

    def onShowLocation(self, widget, action, data):
        item = self.win.vFleets.selection[0]
        fleet = client.get(item.tFleetID, noUpdate = 1)
        # center on map
        if hasattr(fleet, "x"):
            gdata.mainGameDlg.win.vStarMap.highlightPos = (fleet.x, fleet.y)
            gdata.mainGameDlg.win.vStarMap.setPos(fleet.x, fleet.y)
            self.hide()
            return
        self.win.setStatus(_("Cannot show location"))

    def onToggleCondition(self, widget, action, data):
        self.update()

    def onClose(self, widget, action, data):
        self.hide()

    def createUI(self):
        w, h = gdata.scrnSize
        self.win = ui.Window(self.app,
            modal = 1,
            escKeyClose = 1,
            titleOnly = w == 800 and h == 600,
            movable = 0,
            title = _('Fleets Overview'),
            rect = ui.Rect((w - 800 - 4 * (w != 800)) / 2, (h - 600 - 4 * (h != 600)) / 2, 800 + 4 * (w != 800), 580 + 4 * (h != 600)),
            layoutManager = ui.SimpleGridLM(),
        )
        self.win.subscribeAction('*', self)
        # playets listbox
        ui.Listbox(self.win, layout = (0, 0, 40, 26), id = 'vFleets',
            columns = [
                (_('Fleet'), 'text', 5, ui.ALIGN_W),
                (_('Location'), 'tLocation', 6.5, ui.ALIGN_W),
                (_('Current order'), 'tOrder', 7, ui.ALIGN_W),
                (_('ETA'), 'tETA', 3, ui.ALIGN_E),
                (_('Fuel %'), 'tFuel', 3, ui.ALIGN_E),
                (_('Op. time'), 'tOpTime', 3, ui.ALIGN_E),
                (_('Range'), 'tRange', 3, ui.ALIGN_E),
                (_('MP'), 'tMP', 3, ui.ALIGN_E),
                (_('Sign'), 'tSignature', 2, ui.ALIGN_E),
                (_("Last upgr."), "tLastUpgrade", 3.5, ui.ALIGN_E),
            ],
            columnLabels = 1, action = 'onSelectFleet', rmbAction = "onShowLocation")

        ui.Check(self.win, layout = (0, 26, 5, 1), text = _('Mine'), id = "vMine",
            checked = 1, action = "onToggleCondition")
        ui.Check(self.win, layout = (5, 26, 5, 1), text = _('Enemy'), id = "vEnemy",
            checked = 0, action = "onToggleCondition")
        ui.Check(self.win, layout = (10, 26, 5, 1), text = _('Unfriendly'), id = "vUnfriendy",
            checked = 0, action = "onToggleCondition")
        ui.Check(self.win, layout = (15, 26, 5, 1), text = _('Neutral'), id = "vNeutral",
            checked = 0, action = "onToggleCondition")
        ui.Check(self.win, layout = (20, 26, 5, 1), text = _('Friendly'), id = "vFriendly",
            checked = 0, action = "onToggleCondition")
        ui.Check(self.win, layout = (25, 26, 5, 1), text = _('Allied'), id = "vAllied",
            checked = 0, action = "onToggleCondition")
        ui.Check(self.win, layout = (34, 26, 6, 1), text = _('Show redirects'), id = "vRedirects",
            checked = 0, action = "onToggleCondition")
        # status bar + submit/cancel
        ui.TitleButton(self.win, layout = (35, 27, 5, 1), text = _('Close'), action = 'onClose')
        ui.Title(self.win, id = 'vStatusBar', layout = (0, 27, 35, 1), align = ui.ALIGN_W)
        #self.win.statusBar = self.win.vStatusBar


1			#
2			# Copyright 2001 - 2016 Ludek Smid [http://www.ospace.net/]
3			#
4			# This file is part of Outer Space.
5			#
6			# Outer Space is free software; you can redistribute it and/or modify
7			# it under the terms of the GNU General Public License as published by
8			# the Free Software Foundation; either version 2 of the License, or
9			# (at your option) any later version.
10			#
11			# Outer Space is distributed in the hope that it will be useful,
12			# but WITHOUT ANY WARRANTY; without even the implied warranty of
13			# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14			# GNU General Public License for more details.
15			#
16			# You should have received a copy of the GNU General Public License
17			# along with Outer Space; if not, write to the Free Software
18			# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
19			#
20
21			import pygameui as ui
22			from osci.StarMapWidget import StarMapWidget
23			from osci import gdata, res, client
24			import ige.ospace.Const as Const
25			from ige.ospace import Rules
26			import math
27
28			class FleetsOverviewDlg:
29
30			def __init__(self, app):
31			self.app = app
32			self.createUI()
33
34			def display(self):
35			if gdata.config.defaults.showredirects != None:
36			val = gdata.config.defaults.showredirects
37			self.win.vRedirects.checked = val == 'yes'
38
39			self.show()
40			self.win.show()
41			# register for updates
42			if self not in gdata.updateDlgs:
43			gdata.updateDlgs.append(self)
44
45			def hide(self):
46			self.win.setStatus(_("Ready."))
47			self.win.hide()
48			# unregister updates
49			if self in gdata.updateDlgs:
50			gdata.updateDlgs.remove(self)
51
52			def update(self):
53			self.show()
54
55			def _analyzeRelations(self, playerID, fleet):
56			# this evaluates color, and if it should be shown at all
57			# get check box selections
58			mine = self.win.vMine.checked
59			enemy = self.win.vEnemy.checked
60			unfriendly = self.win.vUnfriendy.checked
61			neutral = self.win.vNeutral.checked
62			friendly = self.win.vFriendly.checked
63			allied = self.win.vAllied.checked
64			redirects = self.win.vRedirects.checked
65
66			# check fleet color and decide if display the fleet
67			if hasattr(fleet, 'owner'):
68			plRelation = client.getRelationTo(fleet.owner)
69			fgColor = res.getPlayerColor(fleet.owner)
70			ok = 0
71			if mine and fleet.owner == playerID:
72			ok = 1
73			elif enemy and plRelation >= Const.REL_ENEMY_LO and plRelation < Const.REL_ENEMY_HI:
74			ok = 1
75			elif unfriendly and plRelation >= Const.REL_UNFRIENDLY_LO and plRelation < Const.REL_UNFRIENDLY_HI:
76			ok = 1
77			elif neutral and plRelation >= Const.REL_NEUTRAL_LO and plRelation < Const.REL_NEUTRAL_HI:
78			ok = 1
79			elif friendly and plRelation >= Const.REL_FRIENDLY_LO and plRelation < Const.REL_FRIENDLY_HI:
80			ok = 1
81			elif allied and plRelation >= Const.REL_ALLY_LO and plRelation < Const.REL_ALLY_HI:
82			ok = 1
83
84			if not ok:
85			return None
86			else:
87			if not enemy:
88			return None
89			# with no owner assume enemy
90			fgColor = res.getFFColorCode(0) #enemy
91			return fgColor
92
93			def show(self):
94			player = client.getPlayer()
95			items = []
96			for fleetID in client.db.keys():
97			fleet = client.get(fleetID, noUpdate = 1)
98			# skip non-fleets
99			if not hasattr(fleet, "type") or fleet.type != Const.T_FLEET:
100			continue
101			fgColor = self._analyzeRelations(player.oid, fleet)
102			if fgColor is None:
103			# nothing to show
104			continue
105
106			if hasattr(fleet, 'owner') and player.oid != fleet.owner:
107			owner = getattr(client.get(fleet.owner, noUpdate = 1), "name", res.getUnknownName())
108			ownerName = " (%s)" % owner
109			ownerNameTip = owner
110			ownerTipTitle = _("Owner")
111			else:
112			ownerName = ""
113			ownerNameTip = ""
114			ownerTipTitle = ""
115
116			# check position of fleet
117			system = None
118			systemName = "-"
119			if hasattr(fleet, 'orbiting') and fleet.orbiting:
120			system = client.get(fleet.orbiting, noUpdate = 1)
121			systemName = getattr(system, "name", res.getUnknownName())
122			elif hasattr(fleet, 'closeSystem'):
123			system = client.get(fleet.closeSystem, noUpdate = 1)
124			systemName = _("%s (dst)") % getattr(system, "name", res.getUnknownName())
125
126			# get fleet current action and target of action
127			order = "-"
128			targetName = "-"
129			if hasattr(fleet, 'actions') and fleet.actionIndex < len(fleet.actions):
130			action, target, data = fleet.actions[fleet.actionIndex]
131			if action == Const.FLACTION_REDIRECT and not redirects:
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-01-25 19:05 UTC by Report Bug Copy Issue Report The variable `redirects` does not seem to be defined. Loading history...
132			continue
133			order = gdata.fleetActions[action]
134			if target != Const.OID_NONE:
135			targetName = getattr(client.get(target, noUpdate = 1), 'name', res.getUnknownName())
136			order = "%s %s" % (order, targetName)
137			# eta
138			if hasattr(fleet, "eta"): eta = res.formatTime(fleet.eta)
139			else: eta = "?"
140
141			# fuel
142			if hasattr(fleet, "storEn"):
143			if fleet.maxEn > 0: fuel = 100 * fleet.storEn / fleet.maxEn
144			else: fuel = 0
145			else:
146			fuel = "?"
147
148			# operational time
149			if hasattr(fleet, 'storEn') and hasattr(fleet, 'operEn'):
150			turns = 100000
151			if fleet.operEn > 0: turns = fleet.storEn / fleet.operEn
152			rawRange = turns * fleet.speed / Rules.turnsPerDay
153			range = "%.2f" % rawRange
154			opTime = res.formatTime(turns)
155			else:
156			rawRange = 0
157			range = "?"
158			opTime = "?"
159
160			# last upgrade
161			if hasattr(fleet, "lastUpgrade"):
162			lastUpgrade = res.formatTime(fleet.lastUpgrade)
163			else:
164			lastUpgrade = "?"
165
166			if hasattr(fleet,'customname') and fleet.customname:
167			fleetname = fleet.customname
168			else:
169			fleetname = getattr(fleet, 'name', res.getUnknownName())
170
171			# create ListBox Item for fleet
172			item = ui.Item(
173			"%s %s" % (fleetname, ownerName),
174			tooltipTitle = ownerTipTitle,
175			tooltip = ownerNameTip,
176			tLocation = systemName,
177			tOrder = order,
178			tMP = getattr(fleet, "combatPwr", "?"),
179			tETA = eta,
180			tETA_raw = getattr(fleet, "eta", 0),
181			tSignature = getattr(fleet, "signature", "?"),
182			tFuel = fuel,
183			tOpTime = opTime,
184			tRange = range,
185			tRange_raw = rawRange,
186			tLastUpgrade = lastUpgrade,
187			tFleetID = fleetID,
188			foreground = fgColor)
189			items.append(item)
190
191			self.win.vFleets.items = items
192			self.win.vFleets.itemsChanged()
193
194			def onSelectFleet(self, widget, action, data):
195			item = self.win.vFleets.selection[0]
196			fleet = client.get(item.tFleetID, noUpdate = 1)
197			if hasattr(fleet, "owner") and fleet.owner == client.getPlayerID():
198			# show dialog
199			gdata.mainGameDlg.onSelectMapObj(None, None, item.tFleetID)
200			else:
201			# center fleet on map
202			if hasattr(fleet, "x"):
203			gdata.mainGameDlg.win.vStarMap.highlightPos = (fleet.x, fleet.y)
204			gdata.mainGameDlg.win.vStarMap.setPos(fleet.x, fleet.y)
205			self.hide()
206			return
207			self.win.setStatus(_("Cannot show location"))
208
209			def onShowLocation(self, widget, action, data):
210			item = self.win.vFleets.selection[0]
211			fleet = client.get(item.tFleetID, noUpdate = 1)
212			# center on map
213			if hasattr(fleet, "x"):
214			gdata.mainGameDlg.win.vStarMap.highlightPos = (fleet.x, fleet.y)
215			gdata.mainGameDlg.win.vStarMap.setPos(fleet.x, fleet.y)
216			self.hide()
217			return
218			self.win.setStatus(_("Cannot show location"))
219
220			def onToggleCondition(self, widget, action, data):
221			self.update()
222
223			def onClose(self, widget, action, data):
224			self.hide()
225
226			def createUI(self):
227			w, h = gdata.scrnSize
228			self.win = ui.Window(self.app,
229			modal = 1,
230			escKeyClose = 1,
231			titleOnly = w == 800 and h == 600,
232			movable = 0,
233			title = _('Fleets Overview'),
234			rect = ui.Rect((w - 800 - 4 * (w != 800)) / 2, (h - 600 - 4 * (h != 600)) / 2, 800 + 4 * (w != 800), 580 + 4 * (h != 600)),
235			layoutManager = ui.SimpleGridLM(),
236			)
237			self.win.subscribeAction('*', self)
238			# playets listbox
239			ui.Listbox(self.win, layout = (0, 0, 40, 26), id = 'vFleets',
240			columns = [
241			(_('Fleet'), 'text', 5, ui.ALIGN_W),
242			(_('Location'), 'tLocation', 6.5, ui.ALIGN_W),
243			(_('Current order'), 'tOrder', 7, ui.ALIGN_W),
244			(_('ETA'), 'tETA', 3, ui.ALIGN_E),
245			(_('Fuel %'), 'tFuel', 3, ui.ALIGN_E),
246			(_('Op. time'), 'tOpTime', 3, ui.ALIGN_E),
247			(_('Range'), 'tRange', 3, ui.ALIGN_E),
248			(_('MP'), 'tMP', 3, ui.ALIGN_E),
249			(_('Sign'), 'tSignature', 2, ui.ALIGN_E),
250			(_("Last upgr."), "tLastUpgrade", 3.5, ui.ALIGN_E),
251			],
252			columnLabels = 1, action = 'onSelectFleet', rmbAction = "onShowLocation")
253
254			ui.Check(self.win, layout = (0, 26, 5, 1), text = _('Mine'), id = "vMine",
255			checked = 1, action = "onToggleCondition")
256			ui.Check(self.win, layout = (5, 26, 5, 1), text = _('Enemy'), id = "vEnemy",
257			checked = 0, action = "onToggleCondition")
258			ui.Check(self.win, layout = (10, 26, 5, 1), text = _('Unfriendly'), id = "vUnfriendy",
259			checked = 0, action = "onToggleCondition")
260			ui.Check(self.win, layout = (15, 26, 5, 1), text = _('Neutral'), id = "vNeutral",
261			checked = 0, action = "onToggleCondition")
262			ui.Check(self.win, layout = (20, 26, 5, 1), text = _('Friendly'), id = "vFriendly",
263			checked = 0, action = "onToggleCondition")
264			ui.Check(self.win, layout = (25, 26, 5, 1), text = _('Allied'), id = "vAllied",
265			checked = 0, action = "onToggleCondition")
266			ui.Check(self.win, layout = (34, 26, 6, 1), text = _('Show redirects'), id = "vRedirects",
267			checked = 0, action = "onToggleCondition")
268			# status bar + submit/cancel
269			ui.TitleButton(self.win, layout = (35, 27, 5, 1), text = _('Close'), action = 'onClose')
270			ui.Title(self.win, id = 'vStatusBar', layout = (0, 27, 35, 1), align = ui.ALIGN_W)
271			#self.win.statusBar = self.win.vStatusBar
272

ospaceteam / outerspace

Pull Request — master (#291)

FleetsOverviewDlg.show() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like