ResetPasswordController::showResetForm() - Code Metrics - Inspection of "Refactor to oscer" - oscer-io/oscer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#141)

by Manuel

created 2020-04-23 15:57 UTC

ResetPasswordController::showResetForm() A

↳ Parent: ResetPasswordController

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

namespace Oscer\Cms\Backend\Http\Controllers\Auth;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Cache;
use Oscer\Cms\Backend\Http\Requests\Auth\ResetPasswordRequest;
use Oscer\Cms\Core\Users\Models\User;
use Throwable;

class ResetPasswordController
{
    public function showResetForm(Request $request, $encryptedToken)

    {
        $user = $this->getUserFromEncryptedToken($encryptedToken);

        if ($user === false) {
            return redirect()->route('cms.password.forgot')->with('invalidResetToken', true);
        }

        return view('cms::auth.reset-password', compact('encryptedToken', 'user'));
    }

    public function update(ResetPasswordRequest $request)
    {
        $user = $this->getUserFromEncryptedToken($request->input('encrypted_token'));
        if ($user === false) {
            return redirect()->route('cms.password.forgot')->with('invalidResetToken', true);
        }
        $user->update(['password' => $request->input('password')]);

        Auth::guard()->login($user);

        return redirect()->route('cms.backend.start');
    }

    protected function getUserFromEncryptedToken($encryptedToken)
    {
        try {
            $token = decrypt($encryptedToken);
            [$userId, $token] = explode('|', $token);

            $user = User::query()->findOrFail($userId);
        } catch (Throwable $exception) {
            return false;
        }
        if (Cache::get("password.reset.{$userId}") != $token) {
            return false;
        }

        return $user;
    }
}


1			<?php
2
3			namespace Oscer\Cms\Backend\Http\Controllers\Auth;
4
5			use Illuminate\Http\Request;
6			use Illuminate\Support\Facades\Auth;
7			use Illuminate\Support\Facades\Cache;
8			use Oscer\Cms\Backend\Http\Requests\Auth\ResetPasswordRequest;
9			use Oscer\Cms\Core\Users\Models\User;
10			use Throwable;
11
12			class ResetPasswordController
13			{
14			public function showResetForm(Request $request, $encryptedToken)
			0 ignored issues – show Unused Code introduced 2020-04-23 14:53 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
15			{
16			$user = $this->getUserFromEncryptedToken($encryptedToken);
17
18			if ($user === false) {
19			return redirect()->route('cms.password.forgot')->with('invalidResetToken', true);
20			}
21
22			return view('cms::auth.reset-password', compact('encryptedToken', 'user'));
23			}
24
25			public function update(ResetPasswordRequest $request)
26			{
27			$user = $this->getUserFromEncryptedToken($request->input('encrypted_token'));
28			if ($user === false) {
29			return redirect()->route('cms.password.forgot')->with('invalidResetToken', true);
30			}
31			$user->update(['password' => $request->input('password')]);
32
33			Auth::guard()->login($user);
34
35			return redirect()->route('cms.backend.start');
36			}
37
38			protected function getUserFromEncryptedToken($encryptedToken)
39			{
40			try {
41			$token = decrypt($encryptedToken);
42			[$userId, $token] = explode('\|', $token);
			0 ignored issues – show Bug introduced 2020-04-23 14:53 UTC by Report Bug Copy Issue Report The variable `$userId` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
43			$user = User::query()->findOrFail($userId);
44			} catch (Throwable $exception) {
45			return false;
46			}
47			if (Cache::get("password.reset.{$userId}") != $token) {
48			return false;
49			}
50
51			return $user;
52			}
53			}
54

oscer-io / oscer

Pull Request — master (#141)

ResetPasswordController::showResetForm() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like