Post::booted() - Code Metrics - Inspection of "Merge pull request #141 from oscer-io/refactor-to-..." - oscer-io/oscer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a76360...3b8ebd )

by Manuel

created 2020-04-23 15:57 UTC

Post::booted() A

↳ Parent: Post

Complexity

Conditions	2
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0
cc	2
nc	1
nop	0

<?php

namespace Oscer\Cms\Core\Posts\Models;

use Illuminate\Database\Eloquent\Relations\BelongsToMany;
use Illuminate\Support\Carbon;
use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Storage;
use League\CommonMark\Block\Element\FencedCode;
use League\CommonMark\Block\Element\IndentedCode;
use League\CommonMark\CommonMarkConverter;
use League\CommonMark\Environment;
use Oscer\Cms\Core\Models\BaseModel;
use Spatie\CommonMarkHighlighter\FencedCodeRenderer;
use Spatie\CommonMarkHighlighter\IndentedCodeRenderer;
use Spatie\Sluggable\HasSlug;
use Spatie\Sluggable\SlugOptions;

/**
 * @property int id
 * @property string name
 * @property string slug
 * @property string body
 * @property \Oscer\Cms\Core\Users\Models\User author
 * @property int author_id
 * @property Collection tags
 * @property Carbon|null published_at
 * @property Carbon updated_at
 * @property Carbon created_at
 */
class Post extends BaseModel
{
    use HasSlug;

    protected $table = 'cms_posts';

    protected $with = ['tags', 'author'];

    protected static function booted()
    {
        static::creating(function (self $post) {
            if (! $post->author_id) {
                $post->author_id = auth()->user()->id;
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            }
            $post->type = $post->getType();
        });
    }

    public function getType()
    {
        return 'post';
    }

    /**
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    public function author()
    {
        return $this->belongsTo(\Oscer\Cms\Core\Users\Models\User::class);
    }

    public function getSlugOptions(): SlugOptions
    {
        return SlugOptions::create()
            ->generateSlugsFrom('name')
            ->saveSlugsTo('slug')
            ->doNotGenerateSlugsOnUpdate();
    }

    public function tags(): BelongsToMany
    {
        return $this->belongsToMany(Tag::class);
    }

    /**
     * This method allows to set the tags on a post via the property.
     * If it is a new model they will be synced in a event callback.
     */
    public function setTagsAttribute(array $value)
    {
        /*
         * First we retrieve or create all used tags and pluck the id's
         */
        $tags = collect($value)
            ->map(function (string $name) {
                return Tag::query()->firstOrCreate(['name' => $name]);
            })
            ->pluck('id');

        /*
         * If the post exists we can simply sync the tags with the post. But if
         * we do not have the required id for the pivot table, we register a
         * `created` callback which syncs the tags with the post.
         */
        if ($this->id !== null) {
            $this->tags()->sync($tags);
        } else {
            self::created(function (self $post) use ($tags) {
                $post->tags()->sync($tags);
            });
        }
    }

    public function getRenderedBody()
    {
        $languages = ['php', 'bash', 'yaml', 'ini', 'dockerfile'];
        $env = Environment::createCommonMarkEnvironment();
        $env->addBlockRenderer(FencedCode::class, new FencedCodeRenderer($languages));
        $env->addBlockRenderer(IndentedCode::class, new IndentedCodeRenderer($languages));
        $converter = new CommonMarkConverter([], $env);

        return $converter->convertToHtml($this->body);
    }

    public function joiningTableSegment()
    {
        return 'post';
    }

    public function getFeaturedImageAttribute($value)
    {
        return $value ? Storage::url($value) : null;
    }
}


1			<?php
2
3			namespace Oscer\Cms\Core\Posts\Models;
4
5			use Illuminate\Database\Eloquent\Relations\BelongsToMany;
6			use Illuminate\Support\Carbon;
7			use Illuminate\Support\Collection;
8			use Illuminate\Support\Facades\Storage;
9			use League\CommonMark\Block\Element\FencedCode;
10			use League\CommonMark\Block\Element\IndentedCode;
11			use League\CommonMark\CommonMarkConverter;
12			use League\CommonMark\Environment;
13			use Oscer\Cms\Core\Models\BaseModel;
14			use Spatie\CommonMarkHighlighter\FencedCodeRenderer;
15			use Spatie\CommonMarkHighlighter\IndentedCodeRenderer;
16			use Spatie\Sluggable\HasSlug;
17			use Spatie\Sluggable\SlugOptions;
18
19			/**
20			* @property int id
21			* @property string name
22			* @property string slug
23			* @property string body
24			* @property \Oscer\Cms\Core\Users\Models\User author
25			* @property int author_id
26			* @property Collection tags
27			* @property Carbon\|null published_at
28			* @property Carbon updated_at
29			* @property Carbon created_at
30			*/
31			class Post extends BaseModel
32			{
33			use HasSlug;
34
35			protected $table = 'cms_posts';
36
37			protected $with = ['tags', 'author'];
38
39			protected static function booted()
40			{
41			static::creating(function (self $post) {
42			if (! $post->author_id) {
43			$post->author_id = auth()->user()->id;
			0 ignored issues – show Bug introduced 2020-04-23 14:53 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
44			}
45			$post->type = $post->getType();
46			});
47			}
48
49			public function getType()
50			{
51			return 'post';
52			}
53
54			/**
55			* @return \Illuminate\Database\Eloquent\Relations\BelongsTo
56			*/
57			public function author()
58			{
59			return $this->belongsTo(\Oscer\Cms\Core\Users\Models\User::class);
60			}
61
62			public function getSlugOptions(): SlugOptions
63			{
64			return SlugOptions::create()
65			->generateSlugsFrom('name')
66			->saveSlugsTo('slug')
67			->doNotGenerateSlugsOnUpdate();
68			}
69
70			public function tags(): BelongsToMany
71			{
72			return $this->belongsToMany(Tag::class);
73			}
74
75			/**
76			* This method allows to set the tags on a post via the property.
77			* If it is a new model they will be synced in a event callback.
78			*/
79			public function setTagsAttribute(array $value)
80			{
81			/*
82			* First we retrieve or create all used tags and pluck the id's
83			*/
84			$tags = collect($value)
85			->map(function (string $name) {
86			return Tag::query()->firstOrCreate(['name' => $name]);
87			})
88			->pluck('id');
89
90			/*
91			* If the post exists we can simply sync the tags with the post. But if
92			* we do not have the required id for the pivot table, we register a
93			* `created` callback which syncs the tags with the post.
94			*/
95			if ($this->id !== null) {
96			$this->tags()->sync($tags);
97			} else {
98			self::created(function (self $post) use ($tags) {
99			$post->tags()->sync($tags);
100			});
101			}
102			}
103
104			public function getRenderedBody()
105			{
106			$languages = ['php', 'bash', 'yaml', 'ini', 'dockerfile'];
107			$env = Environment::createCommonMarkEnvironment();
108			$env->addBlockRenderer(FencedCode::class, new FencedCodeRenderer($languages));
109			$env->addBlockRenderer(IndentedCode::class, new IndentedCodeRenderer($languages));
110			$converter = new CommonMarkConverter([], $env);
111
112			return $converter->convertToHtml($this->body);
113			}
114
115			public function joiningTableSegment()
116			{
117			return 'post';
118			}
119
120			public function getFeaturedImageAttribute($value)
121			{
122			return $value ? Storage::url($value) : null;
123			}
124			}
125

oscer-io / oscer

Push — master ( a76360...3b8ebd )

Post::booted() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like