Oscer\Cms\Api\Http\Controllers\MenuOrderController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	update()	0	12	2

<?php

namespace Oscer\Cms\Api\Http\Controllers;

use Oscer\Cms\Api\Http\Requests\SaveMenuOrderRequest;
use Oscer\Cms\Core\Menus\Models\Menu;
use Oscer\Cms\Core\Menus\Models\MenuItem;

class MenuOrderController
{
    public function update(SaveMenuOrderRequest $request, int $id)
    {
        // this is n+1 query and should be refactored
        foreach ($request->validated()['order'] as $item) {
            MenuItem::query()
                ->where('menu_id', $id)
                ->where('id', $item['id'])
                ->update(['order' => $item['order']]);
        }

        return ['data' => Menu::query()->findOrFail($id)];
    }
}